similar to: [PATCH hivex] build: pass $(MAKE) to run-perl-tests

Remaining issue: The C file that is generated from XS is still built in the source directory --- configure.ac | 1 + perl/Makefile.PL.in | 2 +- perl/Makefile.am | 16 ++++++++++++---- perl/run-perl-tests | 21 --------------------- perl/run-perl-tests.in | 21 +++++++++++++++++++++ 5 files changed, 35 insertions(+), 26 deletions(-) delete mode 100755

version 2: - Fixed handling of clean & distclean. - Use 'all-local' instead of 'all'. - Don't use abs_* paths in Build.PL.in. Rich.

Switch from 'ExtUtils::MakeMaker' to 'Module::Build'. There's not really a huge difference here. The interfacing gymnastics that we have to do to make Makefile.am and Module::Build talk to each other is probably a little bit simpler. I compared the output of 'make install' before and after, and there's not much difference. 'perllocal.pod' is not

version 3: - Split requires into configure_requires/etc. - Use lists for extra_compiler_flags, extra_linker_flags. - Suppress .packlist file. - Set the release_status field. Rich.

This reverts commit 4ea016dae96ed4fc3ca6d057f17fde9697f0e627. --- .gitignore | 1 - configure.ac | 2 -- perl/Makefile.PL.in | 6 +++--- perl/Makefile.am | 14 ++------------ perl/run-perl-tests | 21 +++++++++++++++++++++ perl/run-perl-tests.in | 21 --------------------- run.in | 4 ++-- 7 files changed, 28 insertions(+), 41

--- perl/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/perl/Makefile.am b/perl/Makefile.am index 7b8f5d3..1eb0469 100644 --- a/perl/Makefile.am +++ b/perl/Makefile.am @@ -67,6 +67,7 @@ all: Makefile-pl src_deps $(MAKE) -f Makefile-pl Makefile-pl: Makefile.PL + -[ $(srcdir) != $(builddir) ] && cp -rsu $(abs_srcdir)/. $(builddir)/. perl Makefile.PL

For convenience you can pull it from the 'build' branch in: git://heisenbug.com/matthew/libguestfs.git Matt

Here are some of the patches that I have maintained in the patch queue of my packages that I maintain within the Debian distribution (http://packages.qa.debian.org/libg/libguestfs.html). All of them address FTBFS (fail to build from source) errors that happened with the particular configuration that is used for building the Debian package. Cheers, -Hilko

(This is the same change as 87c9ec881cb695724e01d9f6fc9df996d4c67cb6 in libguestfs.) --- ruby/Makefile.am | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/ruby/Makefile.am b/ruby/Makefile.am index e78ab59..7a5fe42 100644 --- a/ruby/Makefile.am +++ b/ruby/Makefile.am @@ -45,13 +45,17 @@ all: $(RAKE) build $(RAKE) rdoc -RUBY_SITELIB := $(shell $(RUBY)

Overwriting LD_LIBRARY_PATH broke some tests when running with fakeroot. --- align/Makefile.am | 2 +- cat/Makefile.am | 2 +- clone/Makefile.am | 2 +- df/Makefile.am | 2 +- edit/Makefile.am | 2 +- fish/Makefile.am | 2 +- haskell/Makefile.am | 2 +- ocaml/Makefile.am |

--- python/Makefile.am | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/python/Makefile.am b/python/Makefile.am index 8599863..89e66f8 100644 --- a/python/Makefile.am +++ b/python/Makefile.am @@ -36,6 +36,7 @@ libhivexmod_la_SOURCES = hivex-py.c libhivexmod_la_CFLAGS = -Wall -I$(PYTHON_INCLUDEDIR) \ -I$(top_srcdir)/lib -I$(top_builddir)/lib

--- configure.ac | 15 +++++++++++++-- generator/generator.ml | 12 ++++++++++-- ruby/Makefile.am | 11 ++++++----- ruby/Rakefile.in | 2 +- ruby/run-ruby-tests | 4 ++-- 5 files changed, 32 insertions(+), 12 deletions(-) diff --git a/configure.ac b/configure.ac index 8651c7b..33c09db 100644 --- a/configure.ac +++ b/configure.ac @@ -312,8 +312,19 @@

--- perl/Makefile.am | 4 ++-- resize/Makefile.am | 8 +++++--- sparsify/Makefile.am | 8 +++++--- 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/perl/Makefile.am b/perl/Makefile.am index eff0059..5e29bbd 100644 --- a/perl/Makefile.am +++ b/perl/Makefile.am @@ -40,11 +40,9 @@ if HAVE_PERL # a nightmare, news at 11. # src/ dependencies -.PHONY: src_deps

Building against multiple versions of Python is a lot of fun as it is. Add autoconf/automake/libtool (and possible distribution-specific stuff) to the mix and things get really interesting: On Debian and Ubuntu, building against python 3.3 requires an extra include path as documented in <http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=692387>. As discussed in

--- configure.ac | 2 +- golang/Makefile.am | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 4e2bc65..9abec95 100644 --- a/configure.ac +++ b/configure.ac @@ -1530,7 +1530,7 @@ AS_IF([test "x$enable_golang" != "xno"],[ AC_CHECK_PROG([GOLANG],[go],[go],[no]) AS_IF([test "x$GOLANG" !=

Signed-off-by: Alex Nelson <ajnelson at cs.ucsc.edu> --- generator/generator.ml | 6 ++++++ lib/hivex.c | 6 ++++++ xml/hivexml.c | 9 +++++++++ 3 files changed, 21 insertions(+), 0 deletions(-) diff --git a/generator/generator.ml b/generator/generator.ml index fc7b483..9e53f4e 100755 --- a/generator/generator.ml +++ b/generator/generator.ml @@ -159,6 +159,12

This patch adds value_data_cell_offset to the hivex ABI, to report the hive space used for long (>4 bytes) value data. Signed-off-by: Alex Nelson <ajnelson at cs.ucsc.edu> --- generator/generator.ml | 12 +++++++++ lib/hivex.c | 60 ++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 72 insertions(+), 0 deletions(-) diff --git a/generator/generator.ml

This patch adds value_data_cell_offset to the hivex ABI, to report the hive space used for long (>4 bytes) value data. Signed-off-by: Alex Nelson <ajnelson at cs.ucsc.edu> --- generator/generator.ml | 12 +++++++++ lib/hivex.c | 60 ++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 72 insertions(+), 0 deletions(-) diff --git a/generator/generator.ml

This patch addresses a build failure in OS X. Running git-bisect on a straightforward build (bootstrap, autogen.sh, configure, make, make install) showed this as the "Bad commit:" 3e7c039799cddc45517350cc917eb10715f33fec The issue is that hivex-internal.h uses le32toh in a static inline function. In case `configure` doesn't find le32toh, byte_conversions.h defines it. But

This is quite a serious issue in hivex, since large/complex modifications will typically segfault unless this patch is applied. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://et.redhat.com/~rjones/libguestfs/ See what it can do: