similar to: [PATCH] daemon: use str_udevadm in udev_settle

On Thursday, 13 April 2017 16:55:26 CEST Pavel Butsykin wrote: > Add udev_settle_file() to run 'udevadm settle' with --exit-if-exists option. It > will slightly reduce the waiting-time for pending events if we need to wait > for events related to a particular device/file. > > Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com> > --- > daemon/daemon.h | 2

udevadm is included in all reasonable recent distributions. This avoids 'command not found' errors in verbose mode. Signed-off-by: Olaf Hering <olaf at aepfle.de> diff --git a/daemon/guestfsd.c b/daemon/guestfsd.c index e6d5fde..0db56e4 100644 --- a/daemon/guestfsd.c +++ b/daemon/guestfsd.c @@ -54,7 +54,6 @@ #include "daemon.h" GUESTFSD_EXT_CMD(str_udevadm, udevadm);

On Wed, Apr 12, 2017 at 05:01:10PM +0300, Pavel Butsykin wrote: > Add udev_settle_file() to run 'udevadm settle' with --exit-if-exists option. It > will slightly reduce the waiting-time for pending events if we need to wait > for events related to a particular device/file. > > Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com> > --- > daemon/daemon.h |

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com> --- appliance/packagelist.in | 1 + daemon/daemon.h | 2 ++ daemon/guestfsd.c | 19 +++++++++++++++++++ 3 files changed, 22 insertions(+) diff --git a/appliance/packagelist.in b/appliance/packagelist.in index 76c7293..d218a37 100644 --- a/appliance/packagelist.in +++ b/appliance/packagelist.in @@ -97,6 +97,7 @@ dnl

add udev_settle calls to print_partition_table and sgdisk_info_extract_field because the inspect-os calls guestfs_part_get_parttype and guestfs_part_get_gpt_guid for all parition devices found and this causes intermittent with opening block devices that are certainly present yet RESOLVE_DEVICE macro would fail wiht ENOENT. --- daemon/parted.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff

guestfsd calls many different tools. Keeping track of all of them is error prone. This patch introduces a new helper macro to put the command string into its own ELF section: GUESTFSD_EXT_CMD(C_variable, command_name); This syntax makes it still possible to grep for used command names. The actual usage of the collected list could be like this: objcopy -j .guestfsd_ext_cmds -O binary

- Btrfs-progs v4.1 introduced new feature of changing uuid of btrfs partition. This patch add support of this. - Introduce set_uuid_random - uuids.c did a lot of deplicated work for changing uuid of fs. Use existing functions. v4: introduce get_random_uuid improve testcases squash internal API patches v3.1: fix typos v3: set errno if feature is not available. Chen Hanxiao (7):

-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v -------------- next part -------------- >From 5c6147ecc7ee3cf657edb1e19ad5ab4e973424e0 Mon Sep 17 00:00:00 2001 From: Richard Jones

-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones New in Fedora 11: Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 70 libraries supprt'd http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw -------------- next part -------------- >From 018e8b562b3980a002bd2f9c42cf7dab541ac005 Mon Sep 17

On Friday, 14 July 2017 15:39:10 CEST Richard W.M. Jones wrote: > .gitignore | 6 +- > Makefile.am | 2 +- > common/mlutils/Makefile.am | 4 - > daemon/Makefile.am | 103 +++++++++++++++++++++++-- > daemon/chroot.ml | 85 +++++++++++++++++++++ > daemon/chroot.mli | 35 +++++++++ > daemon/daemon-c.c |

GUESTFSD_EXT_CMD is used by OpenSUSE to track which external commands are run by the daemon and package those commands into the appliance. However because this uses linker trickery it won't work from OCaml code. Replace it with a [nearly] standard C mechanism. Files still have to declare the external commands they will use, eg: DECLARE_EXTERNAL_COMMANDS ("btrfs",

GUESTFSD_EXT_CMD was used by OpenSUSE to track which external commands are run by the daemon and package those commands into the appliance. It is no longer used by recent SUSE builds, so remove it. Thanks: Pino Toscano, Olaf Hering. --- daemon/9p.c | 3 +- daemon/available.c | 7 +-- daemon/base64.c | 6 +-- daemon/blkid.c | 10 ++---

From: "Richard W.M. Jones" <rjones at redhat.com> This reverts commit a9c8123c72db47bcab8dd738e8d5256a9ae87f11. --- daemon/file.c | 18 +++--------------- daemon/parted.c | 3 +-- 2 files changed, 4 insertions(+), 17 deletions(-) diff --git a/daemon/file.c b/daemon/file.c index 057e15d..91746e0 100644 --- a/daemon/file.c +++ b/daemon/file.c @@ -525,7 +525,7 @@

This patch series is just FYI at the moment. However it does pass the tests. The daemon is a self-contained program. We don't need to write it all in C. Writing parts of it in OCaml would make it simpler and less error-prone. In particular if the daemon was written in a more sane programming language then we could move the inspection code to run entirely inside the appliance, which would

Replace GUESTFSD_EXT_CMD with a command line option ‘./guestfsd --print-external-commands’

Windows server 2012 sets partition names with spaces. ><fs> part-get-name /dev/sda 3 libguestfs: trace: part_get_name "/dev/sda" 3 guestfsd: main_loop: new request, len 0x38 parted -s -m /dev/null Error: The device /dev/null is so small that it cannot possibly store a file system or partition table. Perhaps you selected the wrong device? Warning: Error fsyncing/closing

After this change the debugging output looks like this: guestfsd: enter: mount (0x1) request length 64 bytes commandrvf: stdout=n stderr=y flags=0x0 commandrvf: udevadm --debug settle -E /dev/sda1 calling: settle command: mount '/dev/sda1' '/sysroot//' [ 0.951731] EXT4-fs (sda1): mounting ext2 file system using the ext4 subsystem [ 0.954585] EXT4-fs (sda1):

I'm getting a lot of this at boottime: udev still not settled. Waiting. udevadm settle - timeout of 0 seconds reached, the event queue contains: /sys/module/scsi_wait_scan (11707) udev still not settled. Waiting. udevadm settle - timeout of 0 seconds reached, the event queue contains: /sys/module/scsi_wait_scan (11709) udev still not settled. Waiting. udevadm settle - timeout of 0

This is a simpler patch that removes GUESTFSD_EXT_CMD completely.

guestfsd calls many different tools. Keeping track of all of them is error prone. This patch introduces a new helper macro to put the command string into its own ELF section: GUESTFS_EXT_CMD(C_variable, command_name); This syntax makes it still possible to grep for used command names. The actual usage of the collected list could be like this: objcopy -j .guestfs_ext_cmds -O binary