similar to: [PATCH 1/2] ocaml: Use ocamlfind to run ocamldoc.

On Wednesday 30 September 2015 10:19:10 Richard W.M. Jones wrote: > Miscellaneous improvements to the ocamldoc: > > - Generate more sub-headings. > > - Document the object-oriented API. > > - Use a common function to generate the doc for module and OO APIs. > --- Mostly OK, except ... > + let generate_doc ?(indent = "") f = > + if is_documented f

Miscellaneous improvements to the ocamldoc: - Generate more sub-headings. - Document the object-oriented API. - Use a common function to generate the doc for module and OO APIs. --- generator/ocaml.ml | 84 +++++++++++++++++++++++++++++++----------------------- 1 file changed, 49 insertions(+), 35 deletions(-) diff --git a/generator/ocaml.ml b/generator/ocaml.ml index 465df3c..2be3b7e

Generate proper deprecation markers for API documentation and introspection annotations. --- generator/gobject.ml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/generator/gobject.ml b/generator/gobject.ml index 5b07edd..e563610 100644 --- a/generator/gobject.ml +++ b/generator/gobject.ml @@ -961,7 +961,8 @@ guestfs_session_close (GuestfsSession *session, GError **err)

This way the version string of each API can be used also in other generator modules. Mostly code motion, no actual behaviour changes. --- generator/c.ml | 21 ++++++++++----------- generator/docstrings.ml | 6 ++++++ 2 files changed, 16 insertions(+), 11 deletions(-) diff --git a/generator/c.ml b/generator/c.ml index 63dc09a..a2b9c94 100644 --- a/generator/c.ml +++ b/generator/c.ml @@

There is precisely one such function at the moment (guestfs_wait_ready). --- generator/GObject.ml | 6 +- generator/OCaml.ml | 7 +- generator/actions_core_deprecated.ml | 102 ++++++++++++++--------------- generator/actions_inspection_deprecated.ml | 2 +- generator/actions_properties_deprecated.ml | 12 ++-- generator/c.ml

--- generator/ocaml.ml | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/generator/ocaml.ml b/generator/ocaml.ml index f8707ae..9284005 100644 --- a/generator/ocaml.ml +++ b/generator/ocaml.ml @@ -144,9 +144,14 @@ end fun ({ name = name; style = style; deprecated_by = deprecated_by; non_c_aliases = non_c_aliases; shortdesc = shortdesc

- fix the syntax of hyperlinks - replace the deprecation text with a simplier named list item, so it's more visible - use a named list item for the pointer to the C documentation of each API - add a named list item for the version of each API --- generator/ruby.ml | 27 ++++++++++++++++----------- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/generator/ruby.ml

Per my previous email: https://www.redhat.com/archives/libguestfs/2017-September/msg00203.html I'd like to talk about requiring a more modern version of the OCaml compiler. These commits show some of the code changes which would be possible with OCaml >= 3.12 [which it turns out we already require by accident] and also with OCaml >= 4.02. The latter is my favoured option. Rich.

By splitting up large C files we can make parallel compiles a bit faster. Rich.

This rather complex set of patches allow non-optargs functions to gain optional arguments, while preserving source and binary backwards compatibility. The problem is that we cannot add an optional argument to an existing function. For example, we might want to add flags to the 'lvresize' API which currently has no optional arguments.

Jon, LLVM seems to be now dependant by default on OCAML and ocamldoc. Can you please change this so OCAML is only built and enabled when an '--enable-ocaml' flag is set on 'configure'. As I cannot do 'make install' on Cygwin as ocamldoc is not availiable on Cygwin. Also really 95% of LLVM users are not either going to have ocaml installed or are going to be using it.

> On Thu, Jul 2, 2009 at 11:46 AM, Aaron > Gray<aaronngray.lists at googlemail.com> wrote: >> Jon, >> >> LLVM seems to be now dependant by default on OCAML and ocamldoc. Can you >> please change this so OCAML is only built and enabled when an >> '--enable-ocaml' flag is set on 'configure'. As I cannot do 'make >> install'

On Jul 2, 2009, at 1:27 PM, Aaron Gray wrote: >> On Thu, Jul 2, 2009 at 11:46 AM, Aaron >> Gray<aaronngray.lists at googlemail.com> wrote: >>> Jon, >>> >>> LLVM seems to be now dependant by default on OCAML and ocamldoc. >>> Can you >>> please change this so OCAML is only built and enabled when an >>>

On Thu, Jul 2, 2009 at 11:46 AM, Aaron Gray<aaronngray.lists at googlemail.com> wrote: > Jon, > > LLVM seems to be now dependant by default on OCAML and ocamldoc. Can you > please change this so OCAML is only built and enabled when an > '--enable-ocaml' flag is set on 'configure'. As I cannot do 'make install' > on Cygwin as ocamldoc is not

erick-- I noticed in the OCamldoc entries for [declare_qualified_global] and [define_qualified_global] that you've given the address space parameter the name [as], which is a reserved word in OCaml. The actual code doesn't use this name, which is why it compiles, but the OCamldoc output looks weird. — j h woodyatt <jhw at conjury.org> http://jhw.vox.com/

On Friday, 3 March 2017 11:18:26 CET Richard W.M. Jones wrote: > There is precisely one such function at the moment > (guestfs_wait_ready). > --- Mostly LGTM, few notes below. > diff --git a/generator/GObject.ml b/generator/GObject.ml > index eada33c..fd2c07c 100644 > --- a/generator/GObject.ml > +++ b/generator/GObject.ml > @@ -1118,9 +1118,11 @@ guestfs_session_close

The visibility field in action replaces in_fish, in_docs and internal. The defined types are: VPublic: A public API. This is exported and documented in all language bindings, and in guestfish. VStateTest: A public API which queries the library state machine. It is exported and documented in all language bindings, but not guestfish. VBindTest: An internal API used only for testing

This patch cleans up the code so that it formats nicely with ocamldoc. It does not yet hook into the build system, though. --- bindings/ocaml/analysis/llvm_analysis.mli | 21 +- bindings/ocaml/bitreader/llvm_bitreader.mli | 13 +- bindings/ocaml/bitwriter/llvm_bitwriter.mli | 11 +- .../ocaml/executionengine/llvm_executionengine.mli | 118 ++--

> Aaron, I don't have ocaml installed and llvm builds fine for me. Yeah, its only a problem if you have OCaML installed but not ocamldoc. Sorry for the noise, Aaron

Document which feature, if any, is needed for a function; this should help users in properly checking feature availability when using certain functions. --- generator/c.ml | 6 ++++++ generator/fish.ml | 10 +++++++++- generator/gobject.ml | 8 ++++++++ generator/java.ml | 7 +++++++ generator/ocaml.ml | 7 +++++++ generator/perl.ml | 6 ++++++ generator/python.ml | 5