similar to: [PATCH] daemon: umount-all: Give a "second chance" for temporary umount failures (RHBZ#1246032).

Useful for debugging unmount failures. Note that we include lsof in the appliance already. --- daemon/mount.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/daemon/mount.c b/daemon/mount.c index c5b7d89..e139482 100644 --- a/daemon/mount.c +++ b/daemon/mount.c @@ -424,6 +424,10 @@ do_umount_all (void) r = command (NULL, &err, str_umount, mounts.argv[i], NULL); if (r == -1)

On Thu, Jul 23, 2015 at 05:29:43PM +0200, Pino Toscano wrote: > On Thursday 23 July 2015 16:24:23 Richard W.M. Jones wrote: > > Useful for debugging unmount failures. Note that we include lsof in > > the appliance already. > > --- > > daemon/mount.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/daemon/mount.c b/daemon/mount.c

On Thursday 23 July 2015 16:24:23 Richard W.M. Jones wrote: > Useful for debugging unmount failures. Note that we include lsof in > the appliance already. > --- > daemon/mount.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/daemon/mount.c b/daemon/mount.c > index c5b7d89..e139482 100644 > --- a/daemon/mount.c > +++ b/daemon/mount.c > @@ -424,6

Declare most of the stringsbuf as CLEANUP_FREE_STRINGSBUF, so they are freed completely on stack unwind: use take_stringsbuf() in return places to take away from the stringsbuf its content, and remove all the manual calls to free_stringslen (no more needed now). This requires to not use free_stringslen anymore on failure in the helper functions of stringsbuf, which now leave the content as-is

Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> --- daemon/btrfs.c | 106 +++++++++++++++++++++++++++++++-------------------------- 1 file changed, 58 insertions(+), 48 deletions(-) diff --git a/daemon/btrfs.c b/daemon/btrfs.c index 754fdcd..514ba37 100644 --- a/daemon/btrfs.c +++ b/daemon/btrfs.c @@ -326,6 +326,58 @@ do_btrfs_subvolume_create (const char *dest, const char *qgroupid)

Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> --- daemon/btrfs.c | 104 +++++++++++++++++++++++++++++++-------------------------- 1 file changed, 56 insertions(+), 48 deletions(-) diff --git a/daemon/btrfs.c b/daemon/btrfs.c index 754fdcd..2e9859d 100644 --- a/daemon/btrfs.c +++ b/daemon/btrfs.c @@ -326,6 +326,56 @@ do_btrfs_subvolume_create (const char *dest, const char *qgroupid)

On Thu, Dec 11, 2014 at 02:11:29PM +0800, Hu Tao wrote: > Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> > --- > daemon/btrfs.c | 104 +++++++++++++++++++++++++++++++-------------------------- > 1 file changed, 56 insertions(+), 48 deletions(-) > > diff --git a/daemon/btrfs.c b/daemon/btrfs.c > index 754fdcd..2e9859d 100644 > --- a/daemon/btrfs.c > +++

If add_string_nodup fails free the passed string instead of leaking it, as that string would have been owned by the stringbuf. Adapt few places to this behaviour. --- daemon/btrfs.c | 4 +--- daemon/devsparts.c | 8 ++++---- daemon/guestfsd.c | 1 + 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/daemon/btrfs.c b/daemon/btrfs.c index 9b52aa8..d70565a 100644 ---

Also: * Un-duplicate device detection code by creating a common mapping function. * Add some more comments. --- daemon/devsparts.c | 209 +++++++++++++++++++++++++++++----------------------- 1 files changed, 116 insertions(+), 93 deletions(-) diff --git a/daemon/devsparts.c b/daemon/devsparts.c index 33579ba..0e056a1 100644 --- a/daemon/devsparts.c +++ b/daemon/devsparts.c @@ -29,57 +29,38 @@

I''ve only had the briefest play with wxSugar and already I like it a lot. One small question - have you considered some more ''convention over configuration'' like they do in rails, in particular for event connectors? So instead of listen(:button, my_button, my_button_pressed) you can leave it out entirely and rely on the convention that a button has a _pressed

As Pino's comment, we should take advantage of macro CLEANUP_FREE_STRING_LIST. Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com> --- daemon/btrfs.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/daemon/btrfs.c b/daemon/btrfs.c index 39392f7..fd93d43 100644 --- a/daemon/btrfs.c +++ b/daemon/btrfs.c @@ -409,7 +409,7 @@ umount (char *fs_buf, const

As Pino's comment, we should take advantage of macro CLEANUP_FREE_STRING_LIST. Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com> --- v2: initialize variable of CLEANUP_FREE_STRING_LIST to null daemon/btrfs.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/daemon/btrfs.c b/daemon/btrfs.c index 39392f7..3ca39ab 100644 --- a/daemon/btrfs.c +++

Simply a file rename, no other change. --- daemon/Makefile.am | 2 +- daemon/command.c | 319 ----------------------------------------------------- daemon/sh.c | 319 +++++++++++++++++++++++++++++++++++++++++++++++++++++ po/POTFILES | 2 +- 4 files changed, 321 insertions(+), 321 deletions(-) delete mode 100644 daemon/command.c create mode 100644 daemon/sh.c diff --git

Hello, all. We are having a problem where audio for sip channels is dropping upon reinvite. Perhaps it reflects a misunderstanding of what reinvite does. We are running Asterisk 1.6.1.1 on CentOS 5.3. SIP is set to canreinvite=nonat. We have tried RTP with strictrtp set to both yes and no. We have also tried extending the Asterisk rtp port range to accommodate the differing default ranges of

--On Friday, March 27, 2020 4:00 PM -0500 Tom Bishop <bishoptf at gmail.com> wrote: > I know I rarely post but can we keep it civil on the list, with everything > that's going on in the world is it really necessary? I urge everyone to apply Hanlon's Razor. ;) Also, please trim. We don't need to see all that went before. This is a mailing list, not a business email with

Oh please. It was all in light of people being anal. Therefore? I highly suggest that people refrain from being anal on the list. People can also go to the archives to see that top or bottom posting?nobody cares. > On Mar 27, 2020, at 8:46 PM, Kenneth Porter <shiva at sewingwitch.com> wrote: > > --On Friday, March 27, 2020 4:00 PM -0500 Tom Bishop <bishoptf at

These two patches are probably not completely independent, but separating them is a lot of work. With *both* patches applied, all the tests and extra-tests pass. That's no guarantee however that there isn't a mistake, so I don't think this patch is a candidate for the 1.16 branch, until it's had a lot more testing in development. Rich.

guestfsd calls many different tools. Keeping track of all of them is error prone. This patch introduces a new helper macro to put the command string into its own ELF section: GUESTFSD_EXT_CMD(C_variable, command_name); This syntax makes it still possible to grep for used command names. The actual usage of the collected list could be like this: objcopy -j .guestfsd_ext_cmds -O binary

If either zcat or cpio fails when spawned in initrd-list, pclose will return the actual return value of it, but reply_with_perror still uses errno regardless; thus, the reported error is: libguestfs: error: initrd_list: pclose: Success which is not much helpful. Instead, when pclose returns > 0, extract the actual return value of the subprocess, and print that. Thus now we get for example:

We should not use temporary lines buffer as return value, for lines buffer will be freed. Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com> --- v5: modify according to Pino's comments v4: take advantage of sscanf's '%m'. v3: fix test case failure daemon/btrfs.c | 34 ++++++++++++++-------------------- 1 file changed, 14 insertions(+), 20 deletions(-) diff --git