similar to: URI Handling Patch

So far, passwords in URLs (eg http://user:password@host..) have been handled as part of the username, and thus passing add-drive path username:username:password ... instead of add-drive path username:username secret:password ... Fix the parsing of URLs to handle passwords as separate elements, properly passing it as "secret" parameter for add-drive, and properly readd it when

Parse the query string from URLs, and pass it as new add_drive optarg; use it when building the file= URL for qemu. Accept query string only for http and https protocols, for now. --- Possibly it looks like an ad-hoc solution for http(s), although I'm not sure how it could possibly be generalized somehow (maybe "extra params" which would be the query string for http(s)?).

Hi All, Here's the latest patch. I think this should address the problem. The query string is now only appended to the end of a URI in the HTTP and HTTPS cases. The add-uri test now passes, and 'make check' still passes. -- Gabriel

> > > By default, when saving a URI using xmlSaveUri it escapes everything in > the URI. QEMU doesn't want anything escaped, so now I unescape > everything after the URI is generated. Unfortunately there's no flag to > change the default behavior. > > I'm not sure that's the actual issue here, but I'm somehow included to > think this is another

Hi, In data giovedì 25 giugno 2015 18:44:50, Gabriel Hartmann ha scritto: > I have written a patch (please see attached) which fixes both of these bugs: > > https://bugzilla.redhat.com/show_bug.cgi?id=1092583 > https://bugzilla.redhat.com/show_bug.cgi?id=1232477 > > By default, when saving a URI using xmlSaveUri it escapes everything in the > URI. QEMU doesn't want

Miscellaneous fixes to: - Handling of Ceph drives now works end-to-end (RHBZ#1026688). - In particular, you can now use rbd:/// URIs in guestfish (and they work). - Parse Ceph & NBD network drives from libvirt XML correctly, so that existing domains with Ceph/NBD drives can be added (eg. using guestfish -d option). - Add more testing of the above.

In the kernel and qemu communities it is routine for patches that will be backported to stable branches to be posted for review. I'm proposing we do the same for libguestfs stable branches. All of the attached have been tested with 'make check-release'. Rich.

When parsing the URI, drop the leading '/' from the path also when the protocol is 'nbd': in this case, the path represents the export name, which does not need the '/' coming from the URI format. Improve the coverage for nbd in test-add-uri.sh, adding a couple of tests, and adjusting the result of an existing one. --- fish/test-add-uri.sh | 8 +++++++- fish/uri.c

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.

On Thu, Jun 25, 2015 at 06:44:50PM +0000, Gabriel Hartmann wrote: > I have written a patch (please see attached) which fixes both of these bugs: > > https://bugzilla.redhat.com/show_bug.cgi?id=1092583 > https://bugzilla.redhat.com/show_bug.cgi?id=1232477 > > By default, when saving a URI using xmlSaveUri it escapes everything in the > URI. QEMU doesn't want anything

+Snesha Foss <sneshaf@microsoft.com> who is taking over this work. It definitely looks like adding the query string to every path is just wrong. I'm not sure I understand why we'd want to parse, deconstruct key value pairs and then reconstruct the query string from these values and append them to the path selectively. This seems like added complexity for a benefit I don't

v1 -> v2: - Rebase on top of Pino's version work. Two patches went upstream, these are the two remaining patches. Note the generation number is still inside the qemu.stat file. We could put it in the filename, I have no particular preference. Rich.

Hello List, I''m using blktap on XCP 1.1 and developing a difference copy program for easy backup and remote archival. The idea is to read the BAT of VHD1 and sync it to BAT of VHD2 with BITMAP and the data blocks. Other way would be by adding a sha1 signature in each data block and comparing it with remote VHD. I tried to get some info from below programs but could not get required

Hi list, I have recently migrated to XCP from Vmware Server 2 and have run into issues importing the VM''s Following citrix''s guide I tried using XenCenter to do the import directly on the vmdk files this resulted in XenCenter logging this error: "Failed to import. ---> System.Exception: Failed to import virtual disk file. ---> System.Xml.XmlException: Root element

Hi all, I am getting this annoying "SR_BACKEND_FAILURE_40", have any of you seen some error like this before? I found a post here: http://discussions.citrix.com/topic/283705-internal-error-when-scanning-sr/ But, following those steps did not work out to me. I am using XCP 1.6 over, hen hypervisor 4.1.1 on Ubuntu 12.10. And as the management tool, I am using Cloudstack 4.1.1. The error

An alternate solution to: https://www.redhat.com/archives/libguestfs/2017-December/msg00035.html "[PATCH] v2v: -i vmx: Allow ssh URLs to use spaces." is to classify all URLs processed by libguestfs as either ordinary URLs or the special non-standard URLs that we use for things like ‘virt-v2v -i vmx’ and ‘guestfish --add’. For the non-standard URLs, provide a wrapper around

Hi, this series update libguestfs to a recent gnulib version, so that we can use its new getprogname module, and solve altogether one of the porting issues (the need for 'program_name' by the error module of gnulib), and have a single way to get the name of the current program. A number of changes in tools mostly, although mechanical. Thanks, Pino Toscano (3): Update gnulib to latest

(apologies if you see this twice, forgot the CC the first time) In data venerdì 26 giugno 2015 18:50:16, Gabriel Hartmann ha scritto: > > > > > By default, when saving a URI using xmlSaveUri it escapes everything in > > the URI. QEMU doesn't want anything escaped, so now I unescape > > everything after the URI is generated. Unfortunately there's no flag to

Doing qemu feature detection in the direct backend takes ~100ms because we need to run `qemu -help' and `qemu -devices ?', and each of those interacts with glibc's very slow link loader. Fixing the link loader is really hard. Instead memoize the output of those two commands. This patch series first separates all the code dealing with qemu into a separate module (src/qemu.c) and

Previously posted: https://www.redhat.com/archives/libguestfs/2017-December/msg00046.html Rich.