similar to: [PATCH 3/8] vhost scsi: alloc cmds per vq instead of session

Hi Mike, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on vhost/linux-next] [also build test WARNING on v5.9-rc6 next-20200921] [cannot apply to target/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url:

On Mon, Sep 21, 2020 at 01:23:03PM -0500, Mike Christie wrote: > We currently are limited to 256 cmds per session. This leads to problems > where if the user has increased virtqueue_size to more than 2 or > cmd_per_lun to more than 256 vhost_scsi_get_tag can fail and the guest > will get IO errors. > > This patch moves the cmd allocation to per vq so we can easily match >

From: Matthew Wilcox <mawilcox at microsoft.com> The sbitmap and the percpu_ida perform essentially the same task, allocating tags for commands. Since the sbitmap is more used than the percpu_ida, convert the percpu_ida users to the sbitmap API. Signed-off-by: Matthew Wilcox <mawilcox at microsoft.com> --- drivers/scsi/qla2xxx/qla_target.c | 16 ++++++-----

From: Markus Elfring <elfring at users.sourceforge.net> Date: Sat, 20 May 2017 13:48:44 +0200 Replace the specification of four data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring <elfring at

From: Nicholas Bellinger <nab at linux-iscsi.org> This patch contains the post RFC-v5 (post-merge) changes, this includes: - Add locking comment - Move vhost_scsi_complete_cmd ahead of TFO callbacks in order to drop forward declarations - Drop extra '!= NULL' usage in vhost_scsi_complete_cmd_work() - Change vhost_scsi_*_handle_kick() to use pr_debug - Fix possible race in

From: Nicholas Bellinger <nab at linux-iscsi.org> This patch contains the post RFC-v5 (post-merge) changes, this includes: - Add locking comment - Move vhost_scsi_complete_cmd ahead of TFO callbacks in order to drop forward declarations - Drop extra '!= NULL' usage in vhost_scsi_complete_cmd_work() - Change vhost_scsi_*_handle_kick() to use pr_debug - Fix possible race in

From: Nicholas Bellinger <nab at linux-iscsi.org> Hello KVM + QEMU folks, This is -v5 of the in-flight tcm_vhost fabric driver for KVM host virtualized target support using the in-kernel storage stack with for-3.6 code. The changes since -v4 have been pretty minimal. A new GET_ABI_VERSION ioctl has been added as requested by Anthony & Co, and after some back <-> forth on the

From: Nicholas Bellinger <nab at linux-iscsi.org> Hello KVM + QEMU folks, This is -v5 of the in-flight tcm_vhost fabric driver for KVM host virtualized target support using the in-kernel storage stack with for-3.6 code. The changes since -v4 have been pretty minimal. A new GET_ABI_VERSION ioctl has been added as requested by Anthony & Co, and after some back <-> forth on the

On Mon, 2014-05-19 at 22:15 +0300, Michael S. Tsirkin wrote: > On Mon, May 19, 2014 at 12:07:03PM -0700, Nicholas A. Bellinger wrote: > > On Wed, 2014-05-07 at 12:13 +0300, Michael S. Tsirkin wrote: > > > On Mon, Apr 07, 2014 at 01:56:59AM -0700, Nicholas A. Bellinger wrote: > > > > On Mon, 2014-04-07 at 11:45 +0300, Michael S. Tsirkin wrote: > > > > >

On Mon, May 19, 2014 at 12:07:03PM -0700, Nicholas A. Bellinger wrote: > On Wed, 2014-05-07 at 12:13 +0300, Michael S. Tsirkin wrote: > > On Mon, Apr 07, 2014 at 01:56:59AM -0700, Nicholas A. Bellinger wrote: > > > On Mon, 2014-04-07 at 11:45 +0300, Michael S. Tsirkin wrote: > > > > On Sun, Apr 06, 2014 at 09:32:09PM +0000, Nicholas A. Bellinger wrote: > > >

On Mon, May 19, 2014 at 12:07:03PM -0700, Nicholas A. Bellinger wrote: > On Wed, 2014-05-07 at 12:13 +0300, Michael S. Tsirkin wrote: > > On Mon, Apr 07, 2014 at 01:56:59AM -0700, Nicholas A. Bellinger wrote: > > > On Mon, 2014-04-07 at 11:45 +0300, Michael S. Tsirkin wrote: > > > > On Sun, Apr 06, 2014 at 09:32:09PM +0000, Nicholas A. Bellinger wrote: > > >

On Mon, Apr 07, 2014 at 01:56:59AM -0700, Nicholas A. Bellinger wrote: > On Mon, 2014-04-07 at 11:45 +0300, Michael S. Tsirkin wrote: > > On Sun, Apr 06, 2014 at 09:32:09PM +0000, Nicholas A. Bellinger wrote: > > > From: Nicholas Bellinger <nab at linux-iscsi.org> > > > > > > This patch updates virtscsi_probe() to setup necessary Scsi_Host > > >

On Mon, Apr 07, 2014 at 01:56:59AM -0700, Nicholas A. Bellinger wrote: > On Mon, 2014-04-07 at 11:45 +0300, Michael S. Tsirkin wrote: > > On Sun, Apr 06, 2014 at 09:32:09PM +0000, Nicholas A. Bellinger wrote: > > > From: Nicholas Bellinger <nab at linux-iscsi.org> > > > > > > This patch updates virtscsi_probe() to setup necessary Scsi_Host > > >

On Mon, 2014-04-07 at 12:02 +0300, Michael S. Tsirkin wrote: > On Mon, Apr 07, 2014 at 01:56:59AM -0700, Nicholas A. Bellinger wrote: > > On Mon, 2014-04-07 at 11:45 +0300, Michael S. Tsirkin wrote: > > > On Sun, Apr 06, 2014 at 09:32:09PM +0000, Nicholas A. Bellinger wrote: > > > > From: Nicholas Bellinger <nab at linux-iscsi.org> > > > > > >

On Wed, 2014-05-07 at 12:13 +0300, Michael S. Tsirkin wrote: > On Mon, Apr 07, 2014 at 01:56:59AM -0700, Nicholas A. Bellinger wrote: > > On Mon, 2014-04-07 at 11:45 +0300, Michael S. Tsirkin wrote: > > > On Sun, Apr 06, 2014 at 09:32:09PM +0000, Nicholas A. Bellinger wrote: > > > > From: Nicholas Bellinger <nab at linux-iscsi.org> > > > > > >

You need to tell us what compare() in S-PLUS does; i.e., what does it take as input and what does it output. Presumably the information would be in the help page for compare(). Telling us what the function looks like in S-PLUS is of no use, since most likely the code cannot be used in R without violating S-PLUS copyright and/or license. Even if that wasn't an obstacle, the fact that it

On Mon, Apr 07, 2014 at 01:56:59AM -0700, Nicholas A. Bellinger wrote: > On Mon, 2014-04-07 at 11:45 +0300, Michael S. Tsirkin wrote: > > On Sun, Apr 06, 2014 at 09:32:09PM +0000, Nicholas A. Bellinger wrote: > > > From: Nicholas Bellinger <nab at linux-iscsi.org> > > > > > > This patch updates virtscsi_probe() to setup necessary Scsi_Host > > >

On Mon, Apr 07, 2014 at 01:56:59AM -0700, Nicholas A. Bellinger wrote: > On Mon, 2014-04-07 at 11:45 +0300, Michael S. Tsirkin wrote: > > On Sun, Apr 06, 2014 at 09:32:09PM +0000, Nicholas A. Bellinger wrote: > > > From: Nicholas Bellinger <nab at linux-iscsi.org> > > > > > > This patch updates virtscsi_probe() to setup necessary Scsi_Host > > >

On Mon, 2014-04-07 at 11:45 +0300, Michael S. Tsirkin wrote: > On Sun, Apr 06, 2014 at 09:32:09PM +0000, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger <nab at linux-iscsi.org> > > > > This patch updates virtscsi_probe() to setup necessary Scsi_Host > > level protection resources. (currently hardcoded to 1) > > > > It changes

From: Nicholas Bellinger <nab at linux-iscsi.org> This patch addresses a long-standing bug where the get_user_pages_fast() write parameter used for setting the underlying page table entry permission bits was incorrectly set to write=1 for data_direction=DMA_TO_DEVICE, and passed into get_user_pages_fast() via vhost_scsi_map_iov_to_sgl(). However, this parameter is intended to signal WRITEs