similar to: [PATCH 1/3] virtio-balloon: Constify id_table

On 11.09.20 22:35, Rikard Falkeborn wrote: > id_table is not modified, so make it const to allow the compiler to put > it in read-only memory. > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn at gmail.com> > --- > drivers/virtio/virtio_input.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/virtio/virtio_input.c

On 11.09.20 22:35, Rikard Falkeborn wrote: > mem_id_table is not modified, so make it const to allow the compiler to > put it in read-only memory. > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn at gmail.com> > --- > drivers/virtio/virtio_mem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/virtio/virtio_mem.c

On Wed, Jul 01, 2020 at 10:29:36PM +0200, Rikard Falkeborn wrote: > features[] and id_table[] are not modified and can be made const to > allow the compiler to put them in read-only memory. > > Before: > text data bss dec hex filename > 11534 2056 160 13750 35b6 drivers/crypto/virtio/virtio_crypto_core.o > > After: > text data

On (Wed) 01 Jul 2020 [22:09:50], Rikard Falkeborn wrote: > The id_table and feature_table pointers in struct virtio_driver are > pointers to const. Mark the corresponding static variables const to > allow the compiler to put them in read-only memory. > > Before: > text data bss dec hex filename > 25447 713 76 26236 667c

On Wed, Jul 1, 2020 at 11:48 PM Rikard Falkeborn <rikard.falkeborn at gmail.com> wrote: > > Constify some static variables (mostly structs) that are not modified. > > Rikard Falkeborn (5): > hwrng: bcm2835 - Constify bcm2835_rng_devtype[] > hwrng: nomadik - Constify nmk_rng_ids[] > hwrng: virtio - Constify id_table[] > ipmi: watchdog: Constify ident >

On Wed, Jul 01, 2020 at 10:09:45PM +0200, Rikard Falkeborn wrote: > Constify some static variables (mostly structs) that are not modified. > > Rikard Falkeborn (5): > hwrng: bcm2835 - Constify bcm2835_rng_devtype[] > hwrng: nomadik - Constify nmk_rng_ids[] > hwrng: virtio - Constify id_table[] > ipmi: watchdog: Constify ident > virtio_console: Constify some

Fix sparse warning: drivers/virtio/virtio_balloon.c:168:5: warning: symbol 'virtballoon_free_page_report' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci at huawei.com> Signed-off-by: YueHaibing <yuehaibing at huawei.com> --- drivers/virtio/virtio_balloon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Fix sparse warning: drivers/virtio/virtio_balloon.c:168:5: warning: symbol 'virtballoon_free_page_report' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci at huawei.com> Signed-off-by: YueHaibing <yuehaibing at huawei.com> --- drivers/virtio/virtio_balloon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

On Thu, Apr 02, 2020 at 10:43:02AM +0800, YueHaibing wrote: > Fix sparse warning: > > drivers/virtio/virtio_balloon.c:168:5: warning: > symbol 'virtballoon_free_page_report' was not declared. Should it be static? > > Reported-by: Hulk Robot <hulkci at huawei.com> > Signed-off-by: YueHaibing <yuehaibing at huawei.com> This is for the mm tree right? You

Commit 71994620bb25 ("virtio_balloon: replace oom notifier with shrinker") changed the behavior when deflation happens automatically. Instead of deflating when called by the OOM handler, the shrinker is used. However, the balloon is not simply some other slab cache that should be shrunk when under memory pressure. The shrinker does not have a concept of priorities yet, so this behavior

On Tue, Mar 10, 2020 at 11:39:03AM +0100, David Hildenbrand wrote: > Commit 71994620bb25 ("virtio_balloon: replace oom notifier with shrinker") > changed the behavior when deflation happens automatically. Instead of > deflating when called by the OOM handler, the shrinker is used. > > However, the balloon is not simply some other slab cache that should be > shrunk when

Commit 71994620bb25 ("virtio_balloon: replace oom notifier with shrinker") changed the behavior when deflation happens automatically. Instead of deflating when called by the OOM handler, the shrinker is used. However, the balloon is not simply some other slab cache that should be shrunk when under memory pressure. The shrinker does not have a concept of priorities yet, so this behavior

Commit 71994620bb25 ("virtio_balloon: replace oom notifier with shrinker") changed the behavior when deflation happens automatically. Instead of deflating when called by the OOM handler, the shrinker is used. However, the balloon is not simply some other slab cache that should be shrunk when under memory pressure. The shrinker does not have a concept of priorities yet, so this behavior

Commit 71994620bb25 ("virtio_balloon: replace oom notifier with shrinker") changed the behavior when deflation happens automatically. Instead of deflating when called by the OOM handler, the shrinker is used. However, the balloon is not simply some other slab cache that should be shrunk when under memory pressure. The shrinker does not have a concept of priorities yet, so this behavior

Commit 71994620bb25 ("virtio_balloon: replace oom notifier with shrinker") changed the behavior when deflation happens automatically. Instead of deflating when called by the OOM handler, the shrinker is used. However, the balloon is not simply some other slab cache that should be shrunk when under memory pressure. The shrinker does not have a concept of priorities yet, so this behavior

On 31.03.20 18:27, Nadav Amit wrote: >> On Mar 31, 2020, at 6:32 AM, David Hildenbrand <david at redhat.com> wrote: >> >> On 31.03.20 15:24, Michael S. Tsirkin wrote: >>> On Tue, Mar 31, 2020 at 12:35:24PM +0200, David Hildenbrand wrote: >>>> On 26.03.20 10:49, Michael S. Tsirkin wrote: >>>>> On Thu, Mar 26, 2020 at 08:54:04AM +0100,

Balloon is LE, it's cleaner to access it as such directly. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio_balloon.c | 26 +++++++++----------------- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 8bc1704ffdf3..31cc97f2f515 100644 --- a/drivers/virtio/virtio_balloon.c

>> static void virtio_balloon_unregister_shrinker(struct virtio_balloon *vb) >> @@ -971,7 +950,22 @@ static int virtballoon_probe(struct virtio_device *vdev) >> VIRTIO_BALLOON_CMD_ID_STOP); >> spin_lock_init(&vb->free_page_list_lock); >> INIT_LIST_HEAD(&vb->free_page_list); >> + /* >> + * We're allowed to reuse any free

On Tue, Mar 10, 2020 at 12:12:50PM +0100, David Hildenbrand wrote: > >> static void virtio_balloon_unregister_shrinker(struct virtio_balloon *vb) > >> @@ -971,7 +950,22 @@ static int virtballoon_probe(struct virtio_device *vdev) > >> VIRTIO_BALLOON_CMD_ID_STOP); > >> spin_lock_init(&vb->free_page_list_lock); > >>

>> static void virtio_balloon_unregister_shrinker(struct virtio_balloon *vb) >> @@ -971,7 +950,22 @@ static int virtballoon_probe(struct virtio_device *vdev) >> VIRTIO_BALLOON_CMD_ID_STOP); >> spin_lock_init(&vb->free_page_list_lock); >> INIT_LIST_HEAD(&vb->free_page_list); >> + /* >> + * We're allowed to reuse any free