similar to: [PATCH] char: virtio: Select VIRTIO from VIRTIO_CONSOLE.

fix a code style in drivers/char/virtio_console.c Signed-off-by: Liu Qi <lingjiujianke at gmail.com> --- drivers/char/virtio_console.c | 7 +------ 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 196428c..61dad7e 100644 --- a/drivers/char/virtio_console.c +++ b/drivers/char/virtio_console.c @@ -1299,36

fix a code style in drivers/char/virtio_console.c Signed-off-by: Liu Qi <lingjiujianke at gmail.com> --- drivers/char/virtio_console.c | 7 +------ 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 196428c..61dad7e 100644 --- a/drivers/char/virtio_console.c +++ b/drivers/char/virtio_console.c @@ -1299,36

On Tue, Dec 03, 2019 at 03:46:50PM +0100, Amit Shah wrote: > On Thu, 2019-11-14 at 13:25 +0100, Laurent Vivier wrote: > > When we hot unplug a virtserialport and then try to hot plug again, > > it fails: > > > > (qemu) chardev-add socket,id=serial0,path=/tmp/serial0,server,nowait > > (qemu) device_add virtserialport,bus=virtio-serial0.0,nr=2,\ > >

From: Sjur Br?ndeland <sjur.brandeland at stericsson.com> Remove buffers from the out-queue when a port is removed. Rproc_serial communicates with remote processors that may crash and leave buffers in the out-queue. The virtio serial ports may have buffers in the out-queue as well, e.g. for non-blocking ports and the host didn't consume them yet. [Amit: Remove WARN_ON for generic ports

From: Sjur Br?ndeland <sjur.brandeland at stericsson.com> Remove buffers from the out-queue when a port is removed. Rproc_serial communicates with remote processors that may crash and leave buffers in the out-queue. The virtio serial ports may have buffers in the out-queue as well, e.g. for non-blocking ports and the host didn't consume them yet. [Amit: Remove WARN_ON for generic ports

On (Wed) 01 Jul 2020 [22:09:50], Rikard Falkeborn wrote: > The id_table and feature_table pointers in struct virtio_driver are > pointers to const. Mark the corresponding static variables const to > allow the compiler to put them in read-only memory. > > Before: > text data bss dec hex filename > 25447 713 76 26236 667c

Amit Shah <amit.shah at redhat.com> writes: > On (Sat) 28 Feb 2015 [18:42:25], Michael S. Tsirkin wrote: >> when multiport is off, virtio console invokes config access from irq >> context, config access is blocking on s390. >> Fix this up by scheduling work from config irq - similar to what we do >> for multiport configs. >> >> Signed-off-by: Michael

Amit Shah <amit.shah at redhat.com> writes: > On (Sat) 28 Feb 2015 [18:42:25], Michael S. Tsirkin wrote: >> when multiport is off, virtio console invokes config access from irq >> context, config access is blocking on s390. >> Fix this up by scheduling work from config irq - similar to what we do >> for multiport configs. >> >> Signed-off-by: Michael

On (Sat) 28 Feb 2015 [18:41:34], Michael S. Tsirkin wrote: > when multiport is off, we don't initialize config work, > but we then cancel uninitialized control_work on freeze. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Reviewed-by: Amit Shah <amit.shah at redhat.com> Amit

On (Sat) 28 Feb 2015 [18:42:25], Michael S. Tsirkin wrote: > when multiport is off, virtio console invokes config access from irq > context, config access is blocking on s390. > Fix this up by scheduling work from config irq - similar to what we do > for multiport configs. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Reviewed-by: Amit Shah <amit.shah at

On (Sat) 28 Feb 2015 [18:41:34], Michael S. Tsirkin wrote: > when multiport is off, we don't initialize config work, > but we then cancel uninitialized control_work on freeze. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Reviewed-by: Amit Shah <amit.shah at redhat.com> Amit

On (Sat) 28 Feb 2015 [18:42:25], Michael S. Tsirkin wrote: > when multiport is off, virtio console invokes config access from irq > context, config access is blocking on s390. > Fix this up by scheduling work from config irq - similar to what we do > for multiport configs. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Reviewed-by: Amit Shah <amit.shah at

On (Mon) 16 Jan 2017 [10:45:02], G. Campana wrote: > Using control_work instead of config_work as the 3rd argument to > container_of results in an invalid portdev pointer. Indeed, the work > structure is initialized as below: > > INIT_WORK(&portdev->config_work, &config_work_handler); > > It leads to a crash when portdev->vdev is dereferenced later. This

On Tue, 2020-03-10 at 14:05 +0300, Alexander Lobakin wrote: > rproc_serial_id_table lacks an exposure to module devicetable, so > when remoteproc firmware requests VIRTIO_ID_RPROC_SERIAL, no uevent > is generated and no module autoloading occurs. > Add missing MODULE_DEVICE_TABLE() annotation and move the existing > one for VIRTIO_ID_CONSOLE right to the table itself. > >

Christian tested the patch on s390 and found that the output was very slow. He tracked it down to put_chars never getting init'ed to the final value. Signed-off-by: Amit Shah <amit.shah at redhat.com> --- drivers/char/virtio_console.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index

Christian tested the patch on s390 and found that the output was very slow. He tracked it down to put_chars never getting init'ed to the final value. Signed-off-by: Amit Shah <amit.shah at redhat.com> --- drivers/char/virtio_console.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index

Am 08.05.2015 11:56, schrieb Amit Shah: > On (Fri) 08 May 2015 [11:30:09], walter harms wrote: >> >> >> Am 08.05.2015 11:16, schrieb Dan Carpenter: >>> My static checker complains that this sprintf() can overflow but really >>> it can't. Just silence the warning by using snprintf(). >>> >>> Signed-off-by: Dan Carpenter <dan.carpenter

Am 08.05.2015 11:56, schrieb Amit Shah: > On (Fri) 08 May 2015 [11:30:09], walter harms wrote: >> >> >> Am 08.05.2015 11:16, schrieb Dan Carpenter: >>> My static checker complains that this sprintf() can overflow but really >>> it can't. Just silence the warning by using snprintf(). >>> >>> Signed-off-by: Dan Carpenter <dan.carpenter

On Thu, 2019-11-14 at 13:25 +0100, Laurent Vivier wrote: > When we hot unplug a virtserialport and then try to hot plug again, > it fails: > > (qemu) chardev-add socket,id=serial0,path=/tmp/serial0,server,nowait > (qemu) device_add virtserialport,bus=virtio-serial0.0,nr=2,\ > chardev=serial0,id=serial0,name=serial0 > (qemu) device_del serial0 > (qemu)

From: Sjur Br?ndeland <sjur.brandeland at stericsson.com> Add a simple serial connection driver called VIRTIO_ID_RPROC_SERIAL (11) for communicating with a remote processor in an asymmetric multi-processing configuration. This implementation reuses the existing virtio_console implementation, and adds support for DMA allocation of data buffers and disables use of tty console and the virtio