similar to: [vhost:vhost 38/45] include/linux/vdpa.h:43:28: sparse: sparse: expected ; at end of declaration

tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost head: 84d40e4b4bc64456abf5ef5663871053b40e84ac commit: fee8fe6bd8ccacd27e963b71b4f943be3721779e [38/45] vdpa: make sure set_features in invoked for legacy config: x86_64-randconfig-a014-20200727 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project

tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost head: 84d40e4b4bc64456abf5ef5663871053b40e84ac commit: fee8fe6bd8ccacd27e963b71b4f943be3721779e [38/45] vdpa: make sure set_features in invoked for legacy config: m68k-randconfig-r022-20200727 (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget

On 2020/7/28 ??2:32, Eli Cohen wrote: > On Tue, Jul 28, 2020 at 02:18:16PM +0800, Jason Wang wrote: >> On 2020/7/28 ??2:05, Eli Cohen wrote: >>> Hi Michael, >>> please note that this series depends on mlx5 core device driver patches >>> in mlx5-next branch in >>> git://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git. >>> >>>

On 2020/7/28 ??2:32, Eli Cohen wrote: > On Tue, Jul 28, 2020 at 02:18:16PM +0800, Jason Wang wrote: >> On 2020/7/28 ??2:05, Eli Cohen wrote: >>> Hi Michael, >>> please note that this series depends on mlx5 core device driver patches >>> in mlx5-next branch in >>> git://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git. >>> >>>

On 2020/4/26 ??4:42, Zhu Lingshan wrote: > This commit implements config interrupt support > in IFC VF > > Signed-off-by: Zhu Lingshan <lingshan.zhu at intel.com> > --- > drivers/vdpa/ifcvf/ifcvf_base.c | 3 +++ > drivers/vdpa/ifcvf/ifcvf_base.h | 3 +++ > drivers/vdpa/ifcvf/ifcvf_main.c | 22 +++++++++++++++++++++- > 3 files changed, 27 insertions(+), 1

On 2020/4/1 ??3:19, Michael S. Tsirkin wrote: > We have both vhost and virtio drivers that depend on vdpa. > It's easier to locate it at a top level directory otherwise > we run into issues e.g. if vhost is built-in but virtio > is modular. Let's just move it up a level. > > Reported-by: Randy Dunlap <rdunlap at infradead.org> > Signed-off-by: Michael S. Tsirkin

Rather than former lazy-initialization mechanism, now the virtqueue operations and driver_features related ops access the virtio registers directly to take immediate actions. So ifcvf_start_datapath() should retire. ifcvf_add_status() is retierd because we should not change device status by a vendor driver's decision, this driver should only set device status which is from virito drivers upon

On 2020/4/24 ??6:04, Zhu Lingshan wrote: > This commit implements config interrupt support > in IFC VF > > Signed-off-by: Zhu Lingshan <lingshan.zhu at intel.com> > --- > drivers/vdpa/ifcvf/ifcvf_base.c | 3 +++ > drivers/vdpa/ifcvf/ifcvf_base.h | 2 ++ > drivers/vdpa/ifcvf/ifcvf_main.c | 22 +++++++++++++++++++++- > 3 files changed, 26 insertions(+), 1

This commit implements a new function ifcvf_get_driver_feature() which read driver_features from virtio registers. To be less ambiguous, ifcvf_set_features() is renamed to ifcvf_set_driver_features(), and ifcvf_get_features() is renamed to ifcvf_get_dev_features() which returns the provisioned vDPA device features. Signed-off-by: Zhu Lingshan <lingshan.zhu at intel.com> ---

This commit synchronize irqs of the virtqueues and config space in the reset routine. Thus ifcvf_stop_hw() and reset() are refactored as well. Signed-off-by: Zhu Lingshan <lingshan.zhu at intel.com> --- drivers/vdpa/ifcvf/ifcvf_base.c | 41 +++++++++++++++++++++-------- drivers/vdpa/ifcvf/ifcvf_base.h | 1 + drivers/vdpa/ifcvf/ifcvf_main.c | 46 +++++---------------------------- 3 files

In this commit, virtqueue operations including: set_vq_num(), set_vq_address(), set_vq_ready() and get_vq_ready() access PCI registers directly to take immediate actions. Signed-off-by: Zhu Lingshan <lingshan.zhu at intel.com> --- drivers/vdpa/ifcvf/ifcvf_base.c | 58 ++++++++++++++++++++------------- drivers/vdpa/ifcvf/ifcvf_base.h | 10 +++--- drivers/vdpa/ifcvf/ifcvf_main.c | 16

On Mon, May 8, 2023 at 6:05?PM Zhu Lingshan <lingshan.zhu at intel.com> wrote: > > This commit synchronize irqs of the virtqueues > and config space in the reset routine. > Thus ifcvf_stop_hw() and reset() are refactored as well. > > Signed-off-by: Zhu Lingshan <lingshan.zhu at intel.com> > --- > drivers/vdpa/ifcvf/ifcvf_base.c | 41

This commit implements a new function ifcvf_get_driver_feature() which read driver_features from virtio registers. To be less ambiguous, ifcvf_set_features() is renamed to ifcvf_set_driver_features(), and ifcvf_get_features() is renamed to ifcvf_get_dev_features() which returns the provisioned vDPA device features. Signed-off-by: Zhu Lingshan <lingshan.zhu at intel.com> ---

In this commit, virtqueue operations including: set_vq_num(), set_vq_address(), set_vq_ready() and get_vq_ready() access PCI registers directly to take immediate actions. Signed-off-by: Zhu Lingshan <lingshan.zhu at intel.com> --- drivers/vdpa/ifcvf/ifcvf_base.c | 58 ++++++++++++++++++++------------- drivers/vdpa/ifcvf/ifcvf_base.h | 10 +++--- drivers/vdpa/ifcvf/ifcvf_main.c | 16

drivers/vdpa/ifcvf/ifcvf_main.c:34:24: warning: variable ?ifcvf? set but not used [-Wunused-but-set-variable] drivers/vdpa/ifcvf/ifcvf_base.c:304:31: warning: variable ?ifcvf_lm? set but not used [-Wunused-but-set-variable] Reported-by: Hulk Robot <hulkci at huawei.com> Signed-off-by: YueHaibing <yuehaibing at huawei.com> Acked-by: Jason Wang <jasowang at redhat.com> --- v2:

On Tue, Nov 05, 2019 at 05:37:39PM +0800, Zhu Lingshan wrote: > This commit introduced ifcvf_base layer, which handles hardware > operations and configurations. > > Signed-off-by: Zhu Lingshan <lingshan.zhu at intel.com> > --- > drivers/vhost/ifcvf/ifcvf_base.c | 344 +++++++++++++++++++++++++++++++++++++++ > drivers/vhost/ifcvf/ifcvf_base.h | 132 +++++++++++++++ >

On Tue, Nov 05, 2019 at 05:37:39PM +0800, Zhu Lingshan wrote: > This commit introduced ifcvf_base layer, which handles hardware > operations and configurations. > > Signed-off-by: Zhu Lingshan <lingshan.zhu at intel.com> > --- > drivers/vhost/ifcvf/ifcvf_base.c | 344 +++++++++++++++++++++++++++++++++++++++ > drivers/vhost/ifcvf/ifcvf_base.h | 132 +++++++++++++++ >

On Tue, Nov 05, 2019 at 05:37:39PM +0800, Zhu Lingshan wrote: > This commit introduced ifcvf_base layer, which handles hardware > operations and configurations. > > Signed-off-by: Zhu Lingshan <lingshan.zhu at intel.com> > --- > drivers/vhost/ifcvf/ifcvf_base.c | 344 +++++++++++++++++++++++++++++++++++++++ > drivers/vhost/ifcvf/ifcvf_base.h | 132 +++++++++++++++ >

On 2019/11/5 ??5:37, Zhu Lingshan wrote: > This commit introduced ifcvf_base layer, which handles hardware > operations and configurations. It looks like the PCI layout is pretty similar to virtio. Can we reuse e.g virtio_pci_modern_probe() (or helpers in virtio_pci_modern.c) to do the probing? > > Signed-off-by: Zhu Lingshan <lingshan.zhu at intel.com> > --- >

On 2019/10/16 ??9:30, Zhu Lingshan wrote: > This commit introduced ifcvf_base layer, which handles IFC VF NIC > hardware operations and configurations. It's better to describe the difference between ifc vf and virtio in the commit log or is there a open doc for this? > > Signed-off-by: Zhu Lingshan <lingshan.zhu at intel.com> > --- >