similar to: [PATCH] crypto: virtio - constify features and id_table

On Wed, Jul 01, 2020 at 10:09:45PM +0200, Rikard Falkeborn wrote: > Constify some static variables (mostly structs) that are not modified. > > Rikard Falkeborn (5): > hwrng: bcm2835 - Constify bcm2835_rng_devtype[] > hwrng: nomadik - Constify nmk_rng_ids[] > hwrng: virtio - Constify id_table[] > ipmi: watchdog: Constify ident > virtio_console: Constify some

On 11.09.20 22:35, Rikard Falkeborn wrote: > id_table is not modified, so make it const to allow the compiler to put > it in read-only memory. > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn at gmail.com> > --- > drivers/virtio/virtio_balloon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/virtio/virtio_balloon.c

On 11.09.20 22:35, Rikard Falkeborn wrote: > id_table is not modified, so make it const to allow the compiler to put > it in read-only memory. > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn at gmail.com> > --- > drivers/virtio/virtio_input.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/virtio/virtio_input.c

On (Wed) 01 Jul 2020 [22:09:50], Rikard Falkeborn wrote: > The id_table and feature_table pointers in struct virtio_driver are > pointers to const. Mark the corresponding static variables const to > allow the compiler to put them in read-only memory. > > Before: > text data bss dec hex filename > 25447 713 76 26236 667c

On Wed, Jul 1, 2020 at 11:48 PM Rikard Falkeborn <rikard.falkeborn at gmail.com> wrote: > > Constify some static variables (mostly structs) that are not modified. > > Rikard Falkeborn (5): > hwrng: bcm2835 - Constify bcm2835_rng_devtype[] > hwrng: nomadik - Constify nmk_rng_ids[] > hwrng: virtio - Constify id_table[] > ipmi: watchdog: Constify ident >

On 11.09.20 22:35, Rikard Falkeborn wrote: > mem_id_table is not modified, so make it const to allow the compiler to > put it in read-only memory. > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn at gmail.com> > --- > drivers/virtio/virtio_mem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/virtio/virtio_mem.c

Regards, -Gonglei > -----Original Message----- > From: Zeng, Xin [mailto:xin.zeng at intel.com] > Sent: Thursday, December 15, 2016 8:59 AM > To: Gonglei (Arei); Halil Pasic; linux-kernel at vger.kernel.org; > qemu-devel at nongnu.org; virtio-dev at lists.oasis-open.org; > virtualization at lists.linux-foundation.org; linux-crypto at vger.kernel.org > Cc: Huangweidong (C);

On Thu, Dec 15, 2016 at 01:08:51AM +0000, Gonglei (Arei) wrote: > > > > > Regards, > -Gonglei > > > > -----Original Message----- > > From: Zeng, Xin [mailto:xin.zeng at intel.com] > > Sent: Thursday, December 15, 2016 8:59 AM > > To: Gonglei (Arei); Halil Pasic; linux-kernel at vger.kernel.org; > > qemu-devel at nongnu.org; virtio-dev at

On Thu, Dec 15, 2016 at 01:08:51AM +0000, Gonglei (Arei) wrote: > > > > > Regards, > -Gonglei > > > > -----Original Message----- > > From: Zeng, Xin [mailto:xin.zeng at intel.com] > > Sent: Thursday, December 15, 2016 8:59 AM > > To: Gonglei (Arei); Halil Pasic; linux-kernel at vger.kernel.org; > > qemu-devel at nongnu.org; virtio-dev at

crypto engine was introduced since 'commit 735d37b5424b ("crypto: engine - Introduce the block request crypto engine framework")' which uses work queue to realize the asynchronous processing for ablk_cipher and ahash. For virtio-crypto device, I register an engine for each data virtqueue so that we can use the capability of multiple data queues in future. Cc: Baolin Wang

crypto engine was introduced since 'commit 735d37b5424b ("crypto: engine - Introduce the block request crypto engine framework")' which uses work queue to realize the asynchronous processing for ablk_cipher and ahash. For virtio-crypto device, I register an engine for each data virtqueue so that we can use the capability of multiple data queues in future. Cc: Baolin Wang

On 12/12/2016 11:05 PM, Michael S. Tsirkin wrote: > On Mon, Dec 12, 2016 at 06:54:07PM +0800, Herbert Xu wrote: >> On Mon, Dec 12, 2016 at 06:25:12AM +0000, Gonglei (Arei) wrote: >>> Hi, Michael & Herbert >>> >>> Because the virtio-crypto device emulation had been in QEMU 2.8, >>> would you please merge the virtio-crypto driver for 4.10 if no other

On Mon, Dec 12, 2016 at 06:25:12AM +0000, Gonglei (Arei) wrote: > Hi, Michael & Herbert > > Because the virtio-crypto device emulation had been in QEMU 2.8, > would you please merge the virtio-crypto driver for 4.10 if no other > comments? If so, Miachel pls ack and/or review the patch, then > Herbert will take it (I asked him last week). Thank you! > > Ps: Note on

On Tue, Dec 06, 2016 at 09:01:49AM +0000, Gonglei (Arei) wrote: > > Would you please review and/or ack the virtio_crypto_algs.c? > It is the realization of specified algs based on Linux Crypto Framework. I have no issues with it. If the virtio folks are happy with the interface with the host then I'll take this patch. Thanks, -- Email: Herbert Xu <herbert at

On Wed, Nov 29, 2017 at 09:41:18AM +0100, Corentin Labbe wrote: > The crypto engine could actually only enqueue hash and ablkcipher request. > This patch permit it to enqueue any type of crypto_async_request. > > Signed-off-by: Corentin Labbe <clabbe.montjoie at gmail.com> This is going the wrong way. We do not want to expose any of the base types such as crypto_alg,

On Wed, Nov 29, 2017 at 09:41:18AM +0100, Corentin Labbe wrote: > The crypto engine could actually only enqueue hash and ablkcipher request. > This patch permit it to enqueue any type of crypto_async_request. > > Signed-off-by: Corentin Labbe <clabbe.montjoie at gmail.com> This is going the wrong way. We do not want to expose any of the base types such as crypto_alg,

On Fri, Jan 26, 2018 at 08:15:28PM +0100, Corentin Labbe wrote: > Hello > > The current crypto_engine support only ahash and ablkcipher request. > My first patch which try to add skcipher was Nacked, it will add too many functions > and adding other algs(aead, asymetric_key) will make the situation worst. > > This patchset remove all algs specific stuff and now only process

On Fri, Dec 22, 2017 at 09:41:48AM +0100, Corentin Labbe wrote: > > It's you that was suggesting using crypto_async_request: > https://www.mail-archive.com/linux-kernel at vger.kernel.org/msg1474434.html > "The only wart with this scheme is that the drivers end up seeing > struct crypto_async_request and will need to convert that to the > respective request types but I

On Wed, Mar 07, 2018 at 12:53:15AM +0100, Peter Wu wrote: > virtio_crypto does not use function crypto_authenc_extractkeys, remove > this unnecessary dependency. Compiles fine and passes cryptodev-linux > cipher and speed tests from https://wiki.qemu.org/Features/VirtioCrypto > > Fixes: dbaf0624ffa5 ("crypto: add virtio-crypto driver") > Signed-off-by: Peter Wu

On Mon, Jul 23, 2018 at 04:43:46PM +0800, Jia-Ju Bai wrote: > __virtio_crypto_ablkcipher_do_req() is never called in atomic context. > > __virtio_crypto_ablkcipher_do_req() is only called by > virtio_crypto_ablkcipher_crypt_req(), which is only called by > virtcrypto_find_vqs() that is never called in atomic context. > > __virtio_crypto_ablkcipher_do_req() calls