similar to: [PATCH AUTOSEL 5.4 42/78] iommu/virtio: Fix freeing of incomplete domains

From: Jean-Philippe Brucker <jean-philippe at linaro.org> [ Upstream commit 7062af3ed2ba451029e3733d9f677c68f5ea9e77 ] Calling viommu_domain_free() on a domain that hasn't been finalised (not attached to any device, for example) can currently cause an Oops, because we attempt to call ida_free() on ID 0, which may either be unallocated or used by another domain. Only initialise the

From: Jean-Philippe Brucker <jean-philippe at linaro.org> [ Upstream commit 7062af3ed2ba451029e3733d9f677c68f5ea9e77 ] Calling viommu_domain_free() on a domain that hasn't been finalised (not attached to any device, for example) can currently cause an Oops, because we attempt to call ida_free() on ID 0, which may either be unallocated or used by another domain. Only initialise the

From: Jean-Philippe Brucker <jean-philippe at linaro.org> [ Upstream commit 7062af3ed2ba451029e3733d9f677c68f5ea9e77 ] Calling viommu_domain_free() on a domain that hasn't been finalised (not attached to any device, for example) can currently cause an Oops, because we attempt to call ida_free() on ID 0, which may either be unallocated or used by another domain. Only initialise the

From: Jean-Philippe Brucker <jean-philippe at linaro.org> [ Upstream commit 7062af3ed2ba451029e3733d9f677c68f5ea9e77 ] Calling viommu_domain_free() on a domain that hasn't been finalised (not attached to any device, for example) can currently cause an Oops, because we attempt to call ida_free() on ID 0, which may either be unallocated or used by another domain. Only initialise the

From: Jean-Philippe Brucker <jean-philippe at linaro.org> [ Upstream commit 7062af3ed2ba451029e3733d9f677c68f5ea9e77 ] Calling viommu_domain_free() on a domain that hasn't been finalised (not attached to any device, for example) can currently cause an Oops, because we attempt to call ida_free() on ID 0, which may either be unallocated or used by another domain. Only initialise the

On Mon, Jul 22, 2019 at 03:40:07PM +0100, Jean-Philippe Brucker wrote: > Following specification review a few things were changed in v8 of the > virtio-iommu series [1], but have been omitted when merging the base > driver. Add them now: > > * Remove the EXEC flag. > * Add feature bit for the MMIO flag. > * Change domain_bits to domain_range. > * Add NOMEM status flag.

Hi Jean, On 7/22/19 4:40 PM, Jean-Philippe Brucker wrote: > Following specification review a few things were changed in v8 of the > virtio-iommu series [1], but have been omitted when merging the base > driver. Add them now: > > * Remove the EXEC flag. > * Add feature bit for the MMIO flag. > * Change domain_bits to domain_range. > * Add NOMEM status flag. > > [1]

Following specification review a few things were changed in v8 of the virtio-iommu series [1], but have been omitted when merging the base driver. Add them now: * Remove the EXEC flag. * Add feature bit for the MMIO flag. * Change domain_bits to domain_range. * Add NOMEM status flag. [1] https://lore.kernel.org/linux-iommu/20190530170929.19366-1-jean-philippe.brucker at arm.com/ Fixes:

Following specification review a few things were changed in v8 of the virtio-iommu series [1], but have been omitted when merging the base driver. Add them now: * Remove the EXEC flag. * Add feature bit for the MMIO flag. * Change domain_bits to domain_range. * Add NOMEM status flag. [1] https://lore.kernel.org/linux-iommu/20190530170929.19366-1-jean-philippe.brucker at arm.com/ Fixes:

The virtio IOMMU is a para-virtualized device, allowing to send IOMMU requests such as map/unmap over virtio transport without emulating page tables. This implementation handles ATTACH, DETACH, MAP and UNMAP requests. The bulk of the code transforms calls coming from the IOMMU API into corresponding virtio requests. Mappings are kept in an interval tree instead of page tables. A little more work

On 2020-04-01 12:38 pm, Bharat Bhushan wrote: > Different endpoint can support different page size, probe > endpoint if it supports specific page size otherwise use > global page sizes. > > Signed-off-by: Bharat Bhushan <bbhushan2 at marvell.com> > --- > drivers/iommu/virtio-iommu.c | 33 +++++++++++++++++++++++++++---- > include/uapi/linux/virtio_iommu.h |

On Tue, May 05, 2020 at 03:00:04PM +0530, Bharat Bhushan wrote: > Different endpoint can support different page size, probe > endpoint if it supports specific page size otherwise use > global page sizes. > > Signed-off-by: Bharat Bhushan <bbhushan2 at marvell.com> > --- > v4->v5: > - Rebase to Linux v5.7-rc4 > > v3->v4: > - Fix whitespace error >

Hi Bharat, On 5/7/20 1:24 PM, Bharat Bhushan wrote: > > >> -----Original Message----- >> From: Michael S. Tsirkin <mst at redhat.com> >> Sent: Wednesday, May 6, 2020 5:53 AM >> To: Bharat Bhushan <bbhushan2 at marvell.com> >> Cc: jean-philippe at linaro.org; joro at 8bytes.org; jasowang at redhat.com; >> virtualization at

Hi, On 5/7/20 1:32 PM, Michael S. Tsirkin wrote: > On Thu, May 07, 2020 at 11:24:29AM +0000, Bharat Bhushan wrote: >> >> >>> -----Original Message----- >>> From: Michael S. Tsirkin <mst at redhat.com> >>> Sent: Wednesday, May 6, 2020 5:53 AM >>> To: Bharat Bhushan <bbhushan2 at marvell.com> >>> Cc: jean-philippe at

On Tue, May 05, 2020 at 03:00:04PM +0530, Bharat Bhushan wrote: > Different endpoint can support different page size, probe > endpoint if it supports specific page size otherwise use > global page sizes. > > Signed-off-by: Bharat Bhushan <bbhushan2 at marvell.com> > --- > v4->v5: > - Rebase to Linux v5.7-rc4 > > v3->v4: > - Fix whitespace error >

On Thu, May 14, 2020 at 01:22:37PM +0530, Bharat Bhushan wrote: > Different endpoint can support different page size, probe > endpoint if it supports specific page size otherwise use > global page sizes. > > Device attached to domain should support a minimum of > domain supported page sizes. If device supports more > than domain supported page sizes then device is limited

On Thu, May 14, 2020 at 01:22:37PM +0530, Bharat Bhushan wrote: > Different endpoint can support different page size, probe > endpoint if it supports specific page size otherwise use > global page sizes. > > Device attached to domain should support a minimum of > domain supported page sizes. If device supports more > than domain supported page sizes then device is limited

On Thu, May 07, 2020 at 11:24:29AM +0000, Bharat Bhushan wrote: > > > > -----Original Message----- > > From: Michael S. Tsirkin <mst at redhat.com> > > Sent: Wednesday, May 6, 2020 5:53 AM > > To: Bharat Bhushan <bbhushan2 at marvell.com> > > Cc: jean-philippe at linaro.org; joro at 8bytes.org; jasowang at redhat.com; > > virtualization at

Virtio iommu is modern-only. Use LE accessors for config space. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/iommu/virtio-iommu.c | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/iommu/virtio-iommu.c b/drivers/iommu/virtio-iommu.c index f6f07489a9aa..b4da396cce60 100644 --- a/drivers/iommu/virtio-iommu.c

Implement the virtio-iommu driver, following specification v0.12 [1]. Since last version [2] we've worked on improving the specification, which resulted in the following changes to the interface: * Remove the EXEC flag. * Add feature bit for the MMIO flag. * Change domain_bits to domain_range. Given that there were small changes to patch 5/7, I removed the review and test tags. Please find