similar to: [PATCH] virtio-balloon: Disable free page hinting/reporting if page poison is disabled

From: Alexander Duyck <alexander.h.duyck at linux.intel.com> We should disable free page reporting if page poisoning is enabled in the kernel but we cannot report it via the balloon interface. This way we can avoid the possibility of corrupting guest memory. Normally the page poison reporting feature should always be present when free page reporting is enabled on the hypervisor, however

From: Alexander Duyck <alexander.h.duyck at linux.intel.com> We should disable free page reporting if page poisoning is enabled in the kernel but we cannot report it via the balloon interface. This way we can avoid the possibility of corrupting guest memory. Normally the page poison reporting feature should always be present when free page reporting is enabled on the hypervisor, however

From: Alexander Duyck <alexander.h.duyck at linux.intel.com> We should disable free page reporting if page poisoning is enabled but we cannot report it via the balloon interface. This way we can avoid the possibility of corrupting guest memory. Normally the page poisoning feature should always be present when free page reporting is enabled on the hypervisor, however this allows us to

From: Alexander Duyck <alexander.h.duyck at linux.intel.com> We should disable free page reporting if page poisoning is enabled but we cannot report it via the balloon interface. This way we can avoid the possibility of corrupting guest memory. Normally the page poisoning feature should always be present when free page reporting is enabled on the hypervisor, however this allows us to

On Mon, Apr 27, 2020 at 1:08 AM David Hildenbrand <david at redhat.com> wrote: > > On 24.04.20 18:24, Alexander Duyck wrote: > > From: Alexander Duyck <alexander.h.duyck at linux.intel.com> > > > > We should disable free page reporting if page poisoning is enabled in the > > kernel but we cannot report it via the balloon interface. This way we can >

On Mon, Apr 27, 2020 at 1:08 AM David Hildenbrand <david at redhat.com> wrote: > > On 24.04.20 18:24, Alexander Duyck wrote: > > From: Alexander Duyck <alexander.h.duyck at linux.intel.com> > > > > We should disable free page reporting if page poisoning is enabled in the > > kernel but we cannot report it via the balloon interface. This way we can >

Do I need to resubmit this patch? It has been over two weeks now since it was originally submitted, and a week and a half since I last sent out an email following up. I'm just wondering if there is some list I missed as I am assuming the maintainers and lists I contacted here are correct? It looks like we are at RC7 now so I am worried this won't make it in before LInus releases 5.7.

On Mon, Apr 27, 2020 at 8:09 AM David Hildenbrand <david at redhat.com> wrote: > > On 27.04.20 16:58, Alexander Duyck wrote: > > On Mon, Apr 27, 2020 at 1:08 AM David Hildenbrand <david at redhat.com> wrote: > >> > >> On 24.04.20 18:24, Alexander Duyck wrote: > >>> From: Alexander Duyck <alexander.h.duyck at linux.intel.com> >

Page reporting features were never supported by legacy hypervisors. Supporting them poses a problem: should we use native endian-ness (like current code assumes)? Or little endian-ness like the virtio spec says? Rather than try to figure out, and since results of incorrect endian-ness are dire, let's just block this configuration. Cc: stable at vger.kernel.org Signed-off-by: Michael S.

Page reporting features were never supported by legacy hypervisors. Supporting them poses a problem: should we use native endian-ness (like current code assumes)? Or little endian-ness like the virtio spec says? Rather than try to figure out, and since results of incorrect endian-ness are dire, let's just block this configuration. Cc: stable at vger.kernel.org Signed-off-by: Michael S.

On Thu, Apr 16, 2020 at 12:30:38PM -0700, Alexander Duyck wrote: > From: Alexander Duyck <alexander.h.duyck at linux.intel.com> > > If we have free page hinting or page reporting enabled we should disable it > if the pages are poisoned or initialized on free and we cannot notify the > hypervisor. > > Fixes: 5d757c8d518d ("virtio-balloon: add support for providing

On Fri, Jul 10, 2020 at 09:13:41AM -0700, Alexander Duyck wrote: > On Fri, Jul 10, 2020 at 4:31 AM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > Page reporting features were never supported by legacy hypervisors. > > Supporting them poses a problem: should we use native endian-ness (like > > current code assumes)? Or little endian-ness like the virtio spec

On Fri, Jul 10, 2020 at 09:13:41AM -0700, Alexander Duyck wrote: > On Fri, Jul 10, 2020 at 4:31 AM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > Page reporting features were never supported by legacy hypervisors. > > Supporting them poses a problem: should we use native endian-ness (like > > current code assumes)? Or little endian-ness like the virtio spec

On Mon, Jul 13, 2020 at 08:10:14AM -0700, Alexander Duyck wrote: > On Sun, Jul 12, 2020 at 8:10 AM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > On Fri, Jul 10, 2020 at 09:13:41AM -0700, Alexander Duyck wrote: > > > On Fri, Jul 10, 2020 at 4:31 AM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > > > > > Page reporting

On Mon, Jul 13, 2020 at 08:10:14AM -0700, Alexander Duyck wrote: > On Sun, Jul 12, 2020 at 8:10 AM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > On Fri, Jul 10, 2020 at 09:13:41AM -0700, Alexander Duyck wrote: > > > On Fri, Jul 10, 2020 at 4:31 AM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > > > > > Page reporting

From: Alexander Duyck <alexander.h.duyck at linux.intel.com> It can be confusing to have multiple features within the same driver that are using the same verbage. As such this patch is creating a union of free_page_report_cmd_id with free_page_hint_cmd_id so that we can clean-up the userspace code a bit in terms of readability while maintaining the functionality of legacy code.

On 24.04.20 18:24, Alexander Duyck wrote: > From: Alexander Duyck <alexander.h.duyck at linux.intel.com> > > We should disable free page reporting if page poisoning is enabled in the > kernel but we cannot report it via the balloon interface. This way we can > avoid the possibility of corrupting guest memory. Normally the page poison > reporting feature should always be

On 27.04.20 16:58, Alexander Duyck wrote: > On Mon, Apr 27, 2020 at 1:08 AM David Hildenbrand <david at redhat.com> wrote: >> >> On 24.04.20 18:24, Alexander Duyck wrote: >>> From: Alexander Duyck <alexander.h.duyck at linux.intel.com> >>> >>> We should disable free page reporting if page poisoning is enabled in the >>> kernel but we

On 17.04.20 08:28, Michael S. Tsirkin wrote: > On Thu, Apr 16, 2020 at 04:52:42PM -0700, Alexander Duyck wrote: >> On Thu, Apr 16, 2020 at 3:13 PM Michael S. Tsirkin <mst at redhat.com> wrote: >>> >>> On Thu, Apr 16, 2020 at 12:30:38PM -0700, Alexander Duyck wrote: >>>> From: Alexander Duyck <alexander.h.duyck at linux.intel.com> >>>>

Just following up. It has been a week since I submitted this. I was hoping we could get it in for 5.7 since this affects free page reporting which will be introduced with that kernel release. Thanks. - Alex On Fri, May 8, 2020 at 10:40 AM Alexander Duyck <alexander.duyck at gmail.com> wrote: > > From: Alexander Duyck <alexander.h.duyck at linux.intel.com> > > We should