similar to: [PATCH 0/8] tools/vhost: Reset virtqueue on tests

On Fri, Apr 03, 2020 at 06:51:11PM +0200, Eugenio P??rez wrote: > This series add the tests used to validate the "vhost: Reset batched > descriptors on SET_VRING_BASE call" series, with a small change on the > reset code (delete an extra unneded reset on VHOST_SET_VRING_BASE). > > They are based on the tests sent back them, the ones that were not > included (reasons in

On Fri, Apr 17, 2020 at 09:04:04AM +0200, Eugenio Perez Martin wrote: > On Fri, Apr 17, 2020 at 12:34 AM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > On Thu, Apr 16, 2020 at 09:56:42AM +0200, Eugenio P??rez wrote: > > > This way behavior for vhost is more like a VM. > > > > > > Signed-off-by: Eugenio P??rez <eperezma at redhat.com>

On Thu, Apr 16, 2020 at 09:56:42AM +0200, Eugenio P??rez wrote: > This way behavior for vhost is more like a VM. > > Signed-off-by: Eugenio P??rez <eperezma at redhat.com> I dropped --reset from 5.7 since Linus felt it's unappropriate. I guess I should squash this in with --reset? > --- > tools/virtio/virtio_test.c | 33 ++++++++++++++++++++++++++------- > 1 file

On Wed, Apr 01, 2020 at 08:31:18PM +0200, Eugenio P??rez wrote: > Signed-off-by: Eugenio P??rez <eperezma at redhat.com> I'm still a bit puzzled by this one - could you explain what the rationale here is? > --- > drivers/virtio/virtio_ring.c | 29 +++++++++++++++++++++++++++++ > tools/virtio/linux/virtio.h | 2 ++ > tools/virtio/virtio_test.c | 28

The following changes since commit 48778464bb7d346b47157d21ffde2af6b2d39110: Linux 5.8-rc2 (2020-06-21 15:45:29 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to cb91909e48a4809261ef4e967464e2009b214f06: tools/virtio: Use tools/include/list.h instead of stubs (2020-06-22 12:34:22

On 01.04.20 20:40, Eugenio Perez Martin wrote: > On Wed, Apr 1, 2020 at 9:19 AM Christian Borntraeger > <borntraeger at de.ibm.com> wrote: >> >> On 31.03.20 21:27, Eugenio P?rez wrote: >>> Vhost did not reset properly the batched descriptors on SET_VRING_BASE >>> event. Because of that, is possible to return an invalid descriptor to >>> the guest.

On Thu, Apr 16, 2020 at 09:56:40AM +0200, Eugenio P??rez wrote: > As updated in ("2a2d1382fe9d virtio: Add improved queue allocation API") > > Signed-off-by: Eugenio P??rez <eperezma at redhat.com> Pls add motivation for these changes. > --- > tools/virtio/virtio_test.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git

On 31.03.20 21:27, Eugenio P?rez wrote: > Vhost did not reset properly the batched descriptors on SET_VRING_BASE > event. Because of that, is possible to return an invalid descriptor to > the guest. > > This series ammend this, resetting them every time backend changes, and > creates a test to assert correct behavior. To do that, they need to > expose a new function in

On Wed, Jun 10, 2020 at 04:29:29PM +0200, Eugenio P??rez wrote: > On Wed, 2020-06-10 at 07:36 -0400, Michael S. Tsirkin wrote: > > As testing shows no performance change, switch to that now. > > > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > > Signed-off-by: Eugenio P??rez <eperezma at redhat.com> > > Link:

On Tue, Jun 16, 2020 at 05:23:43PM +0200, Eugenio Perez Martin wrote: > On Mon, Jun 15, 2020 at 6:05 PM Eugenio P??rez <eperezma at redhat.com> wrote: > > > > On Thu, 2020-06-11 at 07:30 -0400, Michael S. Tsirkin wrote: > > > On Wed, Jun 10, 2020 at 06:18:32PM +0200, Eugenio Perez Martin wrote: > > > > On Wed, Jun 10, 2020 at 5:13 PM Michael S. Tsirkin

On 13.02.20 17:29, Eugenio P?rez wrote: > Can we try with this traces? Does not apply on eccb852f1fe6bede630e2e4f1a121a81e34354ab, can you double check? > > From b793b4106085ab1970bdedb340e49f37843ed585 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= <eperezma at redhat.com> > Date: Thu, 13 Feb 2020 17:27:05 +0100 > Subject: [PATCH] vhost: Add debug in

On 14.02.20 13:26, Eugenio P?rez wrote: > On Fri, 2020-02-14 at 13:22 +0100, Christian Borntraeger wrote: >> >> On 14.02.20 13:17, Eugenio P?rez wrote: >>> Can you try the inlined patch over 52c36ce7f334 ("vhost: use batched version by default")? My intention is to check >>> if >>> "strange VHOST_SET_VRING_BASE" line appears. In

On 14.02.20 08:40, Eugenio Perez Martin wrote: > Hi. > > Were the vhost and vhost_net modules loaded with dyndbg='+plt'? I miss > all the others regular debug traces on that one. I did echo -n 'file drivers/vhost/vhost.c +plt' > control and echo -n 'file drivers/vhost/net.c +plt' > control but apparently it did not work...me hates dynamic debug.

On Fri, Feb 03, 2023 at 03:25:01PM +0100, Eugenio P?rez wrote: >Starting from an used_idx different than 0 is needed in use cases like >virtual machine migration. Not doing so and letting the caller set an >avail idx different than 0 causes destination device to try to use old >buffers that source driver already recover and are not available >anymore. > >Since vdpa_sim does

On 14.02.20 13:17, Eugenio P?rez wrote: > Can you try the inlined patch over 52c36ce7f334 ("vhost: use batched version by default")? My intention is to check if > "strange VHOST_SET_VRING_BASE" line appears. In previous tests, it appears very fast, but maybe it takes some time for > it to appear, or it does not appear anymore. LD [M] drivers/vhost/vhost_vsock.o

I did ping -c 20 -f ... ; reboot twice The ping after the first reboot showed .......E this was on the host console [ 55.951885] CPU: 34 PID: 1908 Comm: CPU 0/KVM Not tainted 5.5.0+ #21 [ 55.951891] Hardware name: IBM 3906 M04 704 (LPAR) [ 55.951892] Call Trace: [ 55.951902] [<0000001ede114132>] show_stack+0x8a/0xd0 [ 55.951906] [<0000001edeb0672a>]

Allow building vringh without IOTLB (that's the case for userspace builds, will be useful for CAIF/VOD down the road too). Update for API tweaks. Don't include vringh with userspace builds. Cc: Jason Wang <jasowang at redhat.com> Cc: Eugenio P?rez <eperezma at redhat.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- changes from v1: use IS_REACHEABLE to

Allow building vringh without IOTLB (that's the case for userspace builds, will be useful for CAIF/VOD down the road too). Update for API tweaks. Don't include vringh with userspace builds. Cc: Jason Wang <jasowang at redhat.com> Cc: Eugenio P?rez <eperezma at redhat.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Acked-by: Jason Wang <jasowang at

On Fri, Jun 19, 2020 at 08:22:53PM +0200, Eugenio P??rez wrote: > From: "Michael S. Tsirkin" <mst at redhat.com> > > As testing shows no performance change, switch to that now. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > Signed-off-by: Eugenio P??rez <eperezma at redhat.com> > Link:

This implements a virtio simulator: - adds stubs for enough support functions to compile virtio ring in userspace. - Adds a stub vhost based module this can talk to. This should help us decide things like which ring layout works best. Communication is currently done using an eventfd descriptor. This means there's a shared spinlock there: what I would like to do in the future, is run this