similar to: virtio-mmio: Delete an error message in vm_find_vqs()

On 2020/4/6 ??1:19, Markus Elfring wrote: > From: Markus Elfring <elfring at users.sourceforge.net> > Date: Sun, 5 Apr 2020 19:14:10 +0200 > > The function ?platform_get_irq? can log an error already. > Thus omit a redundant message for the exception handling in the > calling function. It looks to me that not all error path of platform_get_irq() were loggd. And git grep

in vm_find_vqs() irq has a wrong type so, in case of no IRQ resource defined, wrong parameter will be passed to request_irq() Signed-off-by: Ihor Matushchak <ihor.matushchak at foobox.net> --- drivers/virtio/virtio_mmio.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c index f363fbeb5ab0..60dde8ed163b

in vm_find_vqs() irq has a wrong type so, in case of no IRQ resource defined, wrong parameter will be passed to request_irq() Signed-off-by: Ihor Matushchak <ihor.matushchak at foobox.net> --- drivers/virtio/virtio_mmio.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c index f363fbeb5ab0..60dde8ed163b

in vm_find_vqs() irq has a wrong type so, in case of no IRQ resource defined, wrong parameter will be passed to request_irq() Signed-off-by: Ihor Matushchak <ihor.matushchak at foobox.net> --- Changes in v2: Don't overwrite error code value. drivers/virtio/virtio_mmio.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_mmio.c

in vm_find_vqs() irq has a wrong type so, in case of no IRQ resource defined, wrong parameter will be passed to request_irq() Signed-off-by: Ihor Matushchak <ihor.matushchak at foobox.net> --- Changes in v2: Don't overwrite error code value. drivers/virtio/virtio_mmio.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_mmio.c

On Tue, Jul 02, 2019 at 05:48:18PM +0300, Ihor Matushchak wrote: > in vm_find_vqs() irq has a wrong type > so, in case of no IRQ resource defined, > wrong parameter will be passed to request_irq() > > Signed-off-by: Ihor Matushchak <ihor.matushchak at foobox.net> Thanks! pls don't make v2 a response to v1 in the future though. > --- > Changes in v2: > Don't

Hi, Quoting Ihor Matushchak (2019-07-02 12:59:18) > in vm_find_vqs() irq has a wrong type > so, in case of no IRQ resource defined, > wrong parameter will be passed to request_irq() > > Signed-off-by: Ihor Matushchak <ihor.matushchak at foobox.net> > --- > drivers/virtio/virtio_mmio.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff

From: Ihor Matushchak <ihor.matushchak at foobox.net> [ Upstream commit 5e663f0410fa2f355042209154029842ba1abd43 ] in vm_find_vqs() irq has a wrong type so, in case of no IRQ resource defined, wrong parameter will be passed to request_irq() Signed-off-by: Ihor Matushchak <ihor.matushchak at foobox.net> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Reviewed-by: Ivan T.

On Tue, Nov 04, 2014 at 05:35:12PM +0800, Shannon Zhao wrote: > As the current virtio-mmio only support single irq, > so some advanced features such as vhost-net with irqfd > are not supported. And the net performance is not > the best without vhost-net and irqfd supporting. > > This patch support virtio-mmio to request multiple > irqs like virtio-pci. With this patch and

On Thu, Nov 06, 2014 at 05:54:54PM +0800, Shannon Zhao wrote: > On 2014/11/6 17:34, Michael S. Tsirkin wrote: > > On Tue, Nov 04, 2014 at 05:35:12PM +0800, Shannon Zhao wrote: > >> As the current virtio-mmio only support single irq, > >> so some advanced features such as vhost-net with irqfd > >> are not supported. And the net performance is not > >>

On 2014/11/6 17:34, Michael S. Tsirkin wrote: > On Tue, Nov 04, 2014 at 05:35:12PM +0800, Shannon Zhao wrote: >> As the current virtio-mmio only support single irq, >> so some advanced features such as vhost-net with irqfd >> are not supported. And the net performance is not >> the best without vhost-net and irqfd supporting. >> >> This patch support

On 2014/11/6 17:34, Michael S. Tsirkin wrote: > On Tue, Nov 04, 2014 at 05:35:12PM +0800, Shannon Zhao wrote: >> As the current virtio-mmio only support single irq, >> so some advanced features such as vhost-net with irqfd >> are not supported. And the net performance is not >> the best without vhost-net and irqfd supporting. >> >> This patch support

On Sat, Sep 30, 2023 at 4:46?AM Jakub Sitnicki <jakub at cloudflare.com> wrote: > > Some virtual devices, such as the virtio network device, can use multiple > virtqueues (or multiple pairs of virtqueues in the case of a vNIC). In such > case, when there are multiple vCPUs present, it is possible to process > virtqueue events in parallel. Each vCPU can service a subset of all

On Sat, Sep 30, 2023 at 4:46?AM Jakub Sitnicki <jakub at cloudflare.com> wrote: > > Some virtual devices, such as the virtio network device, can use multiple > virtqueues (or multiple pairs of virtqueues in the case of a vNIC). In such > case, when there are multiple vCPUs present, it is possible to process > virtqueue events in parallel. Each vCPU can service a subset of all

As the current virtio-mmio only support single irq, so some advanced features such as vhost-net with irqfd are not supported. And the net performance is not the best without vhost-net and irqfd supporting. This patch support virtio-mmio to request multiple irqs like virtio-pci. With this patch and qemu assigning multiple irqs for virtio-mmio device, it's ok to use vhost-net with irqfd on

As the current virtio-mmio only support single irq, so some advanced features such as vhost-net with irqfd are not supported. And the net performance is not the best without vhost-net and irqfd supporting. This patch support virtio-mmio to request multiple irqs like virtio-pci. With this patch and qemu assigning multiple irqs for virtio-mmio device, it's ok to use vhost-net with irqfd on

The most common issue on arm is that the pci memory window is too narrow to allocate all the BARs. Can you see if there are messages in the kernel to that effect? On Wed, Oct 28, 2020, 9:46 AM Dave Stevenson <dave.stevenson at raspberrypi.com> wrote: > Hi > > Seeing as we (Raspberry Pi) have just launched the Compute Module 4 > with an exposed PCIe x1 lane, people are asking

On Tue, Feb 25, 2020 at 05:45:06PM +0200, Ville Syrj?l? wrote: > On Tue, Feb 25, 2020 at 04:19:27PM +0100, Andrzej Hajda wrote: > > On 25.02.2020 12:21, Ville Syrj?l? wrote: > > > On Mon, Feb 24, 2020 at 03:14:54PM +0100, Andrzej Hajda wrote: > > >> On 19.02.2020 21:35, Ville Syrjala wrote: > > >>> From: Ville Syrj?l? <ville.syrjala at

On 2019/9/24 ??3:21, Ding Xiang wrote: > platform_get_irq already contains error message, Is this message contained in all possible error path? If not, it's probably better to keep it as is. Thanks > so remove > the redundant dev_err message > > Signed-off-by: Ding Xiang <dingxiang at cmss.chinamobile.com> > --- > drivers/virtio/virtio_mmio.c | 4 +--- >

From: Li Liu <john.liuli at huawei.com> This irq handler will get the interrupt reason from a shared memory. And will be assigned only while irqfd enabled. Signed-off-by: Li Liu <john.liuli at huawei.com> --- drivers/virtio/virtio_mmio.c | 34 ++++++++++++++++++++++++++++++++-- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/drivers/virtio/virtio_mmio.c