similar to: [PATCH] virtio-mmio: Delete an error message in vm_find_vqs()

On 2020/4/9 ??2:02, Markus Elfring wrote: >>> The function ?platform_get_irq? can log an error already. >>> Thus omit a redundant message for the exception handling in the >>> calling function. >> It looks to me that not all error path of platform_get_irq() were loggd. > How do you think about to clarify the handling of the error code ?-EPROBE_DEFER? any more?

in vm_find_vqs() irq has a wrong type so, in case of no IRQ resource defined, wrong parameter will be passed to request_irq() Signed-off-by: Ihor Matushchak <ihor.matushchak at foobox.net> --- Changes in v2: Don't overwrite error code value. drivers/virtio/virtio_mmio.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_mmio.c

in vm_find_vqs() irq has a wrong type so, in case of no IRQ resource defined, wrong parameter will be passed to request_irq() Signed-off-by: Ihor Matushchak <ihor.matushchak at foobox.net> --- Changes in v2: Don't overwrite error code value. drivers/virtio/virtio_mmio.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_mmio.c

in vm_find_vqs() irq has a wrong type so, in case of no IRQ resource defined, wrong parameter will be passed to request_irq() Signed-off-by: Ihor Matushchak <ihor.matushchak at foobox.net> --- drivers/virtio/virtio_mmio.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c index f363fbeb5ab0..60dde8ed163b

in vm_find_vqs() irq has a wrong type so, in case of no IRQ resource defined, wrong parameter will be passed to request_irq() Signed-off-by: Ihor Matushchak <ihor.matushchak at foobox.net> --- drivers/virtio/virtio_mmio.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c index f363fbeb5ab0..60dde8ed163b

On Sat, Sep 30, 2023 at 4:46?AM Jakub Sitnicki <jakub at cloudflare.com> wrote: > > Some virtual devices, such as the virtio network device, can use multiple > virtqueues (or multiple pairs of virtqueues in the case of a vNIC). In such > case, when there are multiple vCPUs present, it is possible to process > virtqueue events in parallel. Each vCPU can service a subset of all

On Sat, Sep 30, 2023 at 4:46?AM Jakub Sitnicki <jakub at cloudflare.com> wrote: > > Some virtual devices, such as the virtio network device, can use multiple > virtqueues (or multiple pairs of virtqueues in the case of a vNIC). In such > case, when there are multiple vCPUs present, it is possible to process > virtqueue events in parallel. Each vCPU can service a subset of all

On 2019/9/24 ??3:21, Ding Xiang wrote: > platform_get_irq already contains error message, Is this message contained in all possible error path? If not, it's probably better to keep it as is. Thanks > so remove > the redundant dev_err message > > Signed-off-by: Ding Xiang <dingxiang at cmss.chinamobile.com> > --- > drivers/virtio/virtio_mmio.c | 4 +--- >

On Tue, Jul 02, 2019 at 05:48:18PM +0300, Ihor Matushchak wrote: > in vm_find_vqs() irq has a wrong type > so, in case of no IRQ resource defined, > wrong parameter will be passed to request_irq() > > Signed-off-by: Ihor Matushchak <ihor.matushchak at foobox.net> Thanks! pls don't make v2 a response to v1 in the future though. > --- > Changes in v2: > Don't

From: Ihor Matushchak <ihor.matushchak at foobox.net> [ Upstream commit 5e663f0410fa2f355042209154029842ba1abd43 ] in vm_find_vqs() irq has a wrong type so, in case of no IRQ resource defined, wrong parameter will be passed to request_irq() Signed-off-by: Ihor Matushchak <ihor.matushchak at foobox.net> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Reviewed-by: Ivan T.

On Tue, Nov 04, 2014 at 05:35:12PM +0800, Shannon Zhao wrote: > As the current virtio-mmio only support single irq, > so some advanced features such as vhost-net with irqfd > are not supported. And the net performance is not > the best without vhost-net and irqfd supporting. > > This patch support virtio-mmio to request multiple > irqs like virtio-pci. With this patch and

On Thu, Nov 06, 2014 at 05:54:54PM +0800, Shannon Zhao wrote: > On 2014/11/6 17:34, Michael S. Tsirkin wrote: > > On Tue, Nov 04, 2014 at 05:35:12PM +0800, Shannon Zhao wrote: > >> As the current virtio-mmio only support single irq, > >> so some advanced features such as vhost-net with irqfd > >> are not supported. And the net performance is not > >>

Some vqs may not need to be allocated when their related feature bits are disabled. So callers may pass in such vqs with "names = NULL". Then we skip such vq allocations. Signed-off-by: Wei Wang <wei.w.wang at intel.com> --- drivers/misc/mic/vop/vop_main.c | 9 +++++++-- drivers/remoteproc/remoteproc_virtio.c | 9 +++++++-- drivers/s390/virtio/virtio_ccw.c | 12

Hi, Quoting Ihor Matushchak (2019-07-02 12:59:18) > in vm_find_vqs() irq has a wrong type > so, in case of no IRQ resource defined, > wrong parameter will be passed to request_irq() > > Signed-off-by: Ihor Matushchak <ihor.matushchak at foobox.net> > --- > drivers/virtio/virtio_mmio.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff

On 2014/11/6 17:34, Michael S. Tsirkin wrote: > On Tue, Nov 04, 2014 at 05:35:12PM +0800, Shannon Zhao wrote: >> As the current virtio-mmio only support single irq, >> so some advanced features such as vhost-net with irqfd >> are not supported. And the net performance is not >> the best without vhost-net and irqfd supporting. >> >> This patch support

On 2014/11/6 17:34, Michael S. Tsirkin wrote: > On Tue, Nov 04, 2014 at 05:35:12PM +0800, Shannon Zhao wrote: >> As the current virtio-mmio only support single irq, >> so some advanced features such as vhost-net with irqfd >> are not supported. And the net performance is not >> the best without vhost-net and irqfd supporting. >> >> This patch support

From: Li Liu <john.liuli at huawei.com> This irq handler will get the interrupt reason from a shared memory. And will be assigned only while irqfd enabled. Signed-off-by: Li Liu <john.liuli at huawei.com> --- drivers/virtio/virtio_mmio.c | 34 ++++++++++++++++++++++++++++++++-- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/drivers/virtio/virtio_mmio.c

From: Li Liu <john.liuli at huawei.com> This irq handler will get the interrupt reason from a shared memory. And will be assigned only while irqfd enabled. Signed-off-by: Li Liu <john.liuli at huawei.com> --- drivers/virtio/virtio_mmio.c | 34 ++++++++++++++++++++++++++++++++-- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/drivers/virtio/virtio_mmio.c

On 2014/10/26 19:56, Michael S. Tsirkin wrote: > On Sat, Oct 25, 2014 at 04:24:54PM +0800, john.liuli wrote: >> From: Li Liu <john.liuli at huawei.com> >> >> This irq handler will get the interrupt reason from a >> shared memory. And will be assigned only while irqfd >> enabled. >> >> Signed-off-by: Li Liu <john.liuli at huawei.com> >>

On 2014/10/26 19:56, Michael S. Tsirkin wrote: > On Sat, Oct 25, 2014 at 04:24:54PM +0800, john.liuli wrote: >> From: Li Liu <john.liuli at huawei.com> >> >> This irq handler will get the interrupt reason from a >> shared memory. And will be assigned only while irqfd >> enabled. >> >> Signed-off-by: Li Liu <john.liuli at huawei.com> >>