similar to: [PATCH v2 2/2] vhost: disable for OABI

On Mon, Apr 06, 2020 at 02:45:13PM +0200, Ard Biesheuvel wrote: > On Mon, 6 Apr 2020 at 14:12, Michael S. Tsirkin <mst at redhat.com> wrote: > > > > vhost is currently broken on the default ARM config. > > > > Where did you get this idea? The report from the robot was using a > randconfig build, and in general, AEABI is required to run anything on > any

vhost is currently broken on the some ARM configs. The reason is that the ring element addresses are passed between components with different alignments assumptions. Thus, if guest selects a pointer and host then gets and dereferences it, then alignment assumed by the host's compiler might be greater than the actual alignment of the pointer. compiler on the host from assuming pointer is

vhost is currently broken on the some ARM configs. The reason is that the ring element addresses are passed between components with different alignments assumptions. Thus, if guest selects a pointer and host then gets and dereferences it, then alignment assumed by the host's compiler might be greater than the actual alignment of the pointer. compiler on the host from assuming pointer is

vhost is currently broken on the some ARM configs. The reason is that that uses apcs-gnu which is the ancient OABI that is been deprecated for a long time. Given that virtio support on such ancient systems is not needed in the first place, let's just add something along the lines of depends on !ARM || AEABI to the virtio Kconfig declaration, and add a comment that it has to do with struct

vhost is currently broken on the some ARM configs. The reason is that that uses apcs-gnu which is the ancient OABI that is been deprecated for a long time. Given that virtio support on such ancient systems is not needed in the first place, let's just add something along the lines of depends on !ARM || AEABI to the virtio Kconfig declaration, and add a comment that it has to do with struct

On Mon, Apr 06, 2020 at 02:50:32PM +0200, Arnd Bergmann wrote: > On Mon, Apr 6, 2020 at 2:12 PM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > > +config VHOST_DPN > > + bool "VHOST dependencies" > > + depends on !ARM || AEABI > > + default y > > + help > > + Anything selecting VHOST or

On Mon, Apr 06, 2020 at 02:50:32PM +0200, Arnd Bergmann wrote: > On Mon, Apr 6, 2020 at 2:12 PM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > > +config VHOST_DPN > > + bool "VHOST dependencies" > > + depends on !ARM || AEABI > > + default y > > + help > > + Anything selecting VHOST or

Hi Michael, Thanks for your patch! On Mon, Apr 20, 2020 at 5:13 PM Michael S. Tsirkin <mst at redhat.com> wrote: > vhost is currently broken on the some ARM configs. > > The reason is that the ring element addresses are passed between > components with different alignments assumptions. Thus, if > guest selects a pointer and host then gets and dereferences > it, then

On Mon, Apr 6, 2020 at 3:02 PM Michael S. Tsirkin <mst at redhat.com> wrote: > > On Mon, Apr 06, 2020 at 02:50:32PM +0200, Arnd Bergmann wrote: > > On Mon, Apr 6, 2020 at 2:12 PM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > > > > > +config VHOST_DPN > > > + bool "VHOST dependencies" > > > + depends on

On Mon, Apr 6, 2020 at 2:12 PM Michael S. Tsirkin <mst at redhat.com> wrote: > > +config VHOST_DPN > + bool "VHOST dependencies" > + depends on !ARM || AEABI > + default y > + help > + Anything selecting VHOST or VHOST_RING must depend on VHOST_DPN. > + This excludes the deprecated ARM ABI since that forces a 4 byte

set_dma_ops isn't available on all architectures: make ARCH=um ... drivers/vdpa/vdpa_sim/vdpa_sim.c: In function 'vdpasim_create': >> drivers/vdpa/vdpa_sim/vdpa_sim.c:324:2: error: implicit declaration of function 'set_dma_ops'; did you mean 'set_groups'? +[-Werror=implicit-function-declaration] set_dma_ops(dev, &vdpasim_dma_ops);

set_dma_ops isn't available on all architectures: make ARCH=um ... drivers/vdpa/vdpa_sim/vdpa_sim.c: In function 'vdpasim_create': >> drivers/vdpa/vdpa_sim/vdpa_sim.c:324:2: error: implicit declaration of function 'set_dma_ops'; did you mean 'set_groups'? +[-Werror=implicit-function-declaration] set_dma_ops(dev, &vdpasim_dma_ops);

set_dma_ops isn't available on all architectures: make ARCH=um ... drivers/vdpa/vdpa_sim/vdpa_sim.c: In function 'vdpasim_create': >> drivers/vdpa/vdpa_sim/vdpa_sim.c:324:2: error: implicit declaration of function 'set_dma_ops'; did you mean 'set_groups'? +[-Werror=implicit-function-declaration] set_dma_ops(dev, &vdpasim_dma_ops);

If user did not configure any vdpa drivers, neither vhost nor virtio vdpa are going to be useful. So there's no point in prompting for these and selecting vdpa core automatically. Simplify configuration by making virtio and vhost vdpa drivers depend on vdpa menu entry. Once done, we no longer need a separate menu entry, so also get rid of this. While at it, fix up the IFC entry: VDPA->vDPA

On Wed, Apr 01, 2020 at 10:29:32PM +0800, Jason Wang wrote: > > On 2020/4/1 ??10:13, Michael S. Tsirkin wrote: > > On Wed, Apr 01, 2020 at 10:08:59PM +0800, Jason Wang wrote: > > > On 2020/4/1 ??9:22, Michael S. Tsirkin wrote: > > > > On Thu, Mar 26, 2020 at 10:01:17PM +0800, Jason Wang wrote: > > > > > Currently, CONFIG_VHOST depends on

On 2020/4/1 ??10:13, Michael S. Tsirkin wrote: > On Wed, Apr 01, 2020 at 10:08:59PM +0800, Jason Wang wrote: >> On 2020/4/1 ??9:22, Michael S. Tsirkin wrote: >>> On Thu, Mar 26, 2020 at 10:01:17PM +0800, Jason Wang wrote: >>>> Currently, CONFIG_VHOST depends on CONFIG_VIRTUALIZATION. But vhost is >>>> not necessarily for VM since it's a generic

On 2020/4/1 ??9:22, Michael S. Tsirkin wrote: > On Thu, Mar 26, 2020 at 10:01:17PM +0800, Jason Wang wrote: >> Currently, CONFIG_VHOST depends on CONFIG_VIRTUALIZATION. But vhost is >> not necessarily for VM since it's a generic userspace and kernel >> communication protocol. Such dependency may prevent archs without >> virtualization support from using vhost.

On Wed, Apr 01, 2020 at 10:29:32PM +0800, Jason Wang wrote: > > On 2020/4/1 ??10:13, Michael S. Tsirkin wrote: > > On Wed, Apr 01, 2020 at 10:08:59PM +0800, Jason Wang wrote: > > > On 2020/4/1 ??9:22, Michael S. Tsirkin wrote: > > > > On Thu, Mar 26, 2020 at 10:01:17PM +0800, Jason Wang wrote: > > > > > Currently, CONFIG_VHOST depends on

On Thu, Apr 16, 2020 at 06:20:20PM -0400, Michael S. Tsirkin wrote: > vhost is currently broken on the some ARM configs. > > The reason is that that uses apcs-gnu which is the ancient OABI that is been > deprecated for a long time. > > Given that virtio support on such ancient systems is not needed in the > first place, let's just add something along the lines of >

On 2020/4/17 ??6:55, Michael S. Tsirkin wrote: > On Wed, Apr 15, 2020 at 10:43:56AM +0800, Jason Wang wrote: >> We try to keep the defconfig untouched after decoupling CONFIG_VHOST >> out of CONFIG_VIRTUALIZATION in commit 20c384f1ea1a >> ("vhost: refine vhost and vringh kconfig") by enabling VHOST_MENU by >> default. Then the defconfigs can keep enabling