similar to: [PATCH RFC v2 22/24] scsi: drop scsi command list

On 4/7/20 1:54 PM, John Garry wrote: > On 06/04/2020 10:05, Hannes Reinecke wrote: >> On 3/11/20 7:22 AM, Christoph Hellwig wrote: >>> On Tue, Mar 10, 2020 at 09:08:56PM +0000, John Garry wrote: >>>> On 10/03/2020 18:32, Christoph Hellwig wrote: >>>>> On Wed, Mar 11, 2020 at 12:25:28AM +0800, John Garry wrote: >>>>>> From: Hannes

On 3/11/20 12:08 AM, Ming Lei wrote: > On Wed, Mar 11, 2020 at 12:25:27AM +0800, John Garry wrote: >> From: Hannes Reinecke <hare at suse.com> >> >> Add a new field 'nr_reserved_cmds' to the SCSI host template to >> instruct the block layer to set aside a tag space for reserved >> commands. >> >> Signed-off-by: Hannes Reinecke <hare at

On 4/7/20 4:35 PM, John Garry wrote: > On 07/04/2020 15:00, Hannes Reinecke wrote: >> On 4/7/20 1:54 PM, John Garry wrote: >>> On 06/04/2020 10:05, Hannes Reinecke wrote: [ .. ] >>>> This would be okay if 'this_id' would have been defined by the driver; >>>> sadly, most drivers which are affected here do set 'this_id' to -1.

On 4/23/20 4:13 PM, John Garry wrote: > On 07/04/2020 17:30, Christoph Hellwig wrote: >> On Tue, Apr 07, 2020 at 04:00:10PM +0200, Hannes Reinecke wrote: >>> My concern is this: >>> >>> struct scsi_device *scsi_get_host_dev(struct Scsi_Host *shost) >>> { >>> ????[ .. ] >>> ????starget = scsi_alloc_target(&shost->shost_gendev, 0,

On Wed, Mar 11, 2020 at 12:25:27AM +0800, John Garry wrote: > From: Hannes Reinecke <hare at suse.com> > > Add a new field 'nr_reserved_cmds' to the SCSI host template to > instruct the block layer to set aside a tag space for reserved > commands. > > Signed-off-by: Hannes Reinecke <hare at suse.com> > --- > drivers/scsi/scsi_lib.c | 1 + >

On Wed, Mar 11, 2020 at 12:25:27AM +0800, John Garry wrote: > From: Hannes Reinecke <hare at suse.com> > > Add a new field 'nr_reserved_cmds' to the SCSI host template to > instruct the block layer to set aside a tag space for reserved > commands. > > Signed-off-by: Hannes Reinecke <hare at suse.com> > --- > drivers/scsi/scsi_lib.c | 1 + >

On Tue, Mar 10, 2020 at 09:08:56PM +0000, John Garry wrote: > On 10/03/2020 18:32, Christoph Hellwig wrote: > > On Wed, Mar 11, 2020 at 12:25:28AM +0800, John Garry wrote: > > > From: Hannes Reinecke <hare at suse.com> > > > > > > Allocate a separate 'reserved_cmd_q' for sending reserved commands. > > > > Why? Reserved command

On Tue, Mar 10, 2020 at 09:08:56PM +0000, John Garry wrote: > On 10/03/2020 18:32, Christoph Hellwig wrote: > > On Wed, Mar 11, 2020 at 12:25:28AM +0800, John Garry wrote: > > > From: Hannes Reinecke <hare at suse.com> > > > > > > Allocate a separate 'reserved_cmd_q' for sending reserved commands. > > > > Why? Reserved command

On Wed, Mar 11, 2020 at 12:25:38AM +0800, John Garry wrote: > From: Hannes Reinecke <hare at suse.com> > > Enable the use of reserved commands, and drop the hand-crafted > command allocation. > > Signed-off-by: Hannes Reinecke <hare at suse.com> > --- > drivers/scsi/hpsa.c | 147 ++++++++++++++------------------------------ > drivers/scsi/hpsa.h | 1 -

On Wed, Mar 11, 2020 at 12:25:28AM +0800, John Garry wrote: > From: Hannes Reinecke <hare at suse.com> > > Allocate a separate 'reserved_cmd_q' for sending reserved commands. Why? Reserved command specifically are not in any way tied to queues.

From: Nicholas Bellinger <nab at linux-iscsi.org> This patch changes virtio-scsi to use a new virtio_driver->scan() callback so that scsi_scan_host() can be properly invoked once virtio_dev_probe() has set add_status(dev, VIRTIO_CONFIG_S_DRIVER_OK) to signal active virtio-ring operation, instead of from within virtscsi_probe(). This fixes a bug where SCSI LUN scanning for both

From: Nicholas Bellinger <nab at linux-iscsi.org> This patch changes virtio-scsi to use a new virtio_driver->scan() callback so that scsi_scan_host() can be properly invoked once virtio_dev_probe() has set add_status(dev, VIRTIO_CONFIG_S_DRIVER_OK) to signal active virtio-ring operation, instead of from within virtscsi_probe(). This fixes a bug where SCSI LUN scanning for both

On Mon, Apr 07, 2014 at 01:56:59AM -0700, Nicholas A. Bellinger wrote: > On Mon, 2014-04-07 at 11:45 +0300, Michael S. Tsirkin wrote: > > On Sun, Apr 06, 2014 at 09:32:09PM +0000, Nicholas A. Bellinger wrote: > > > From: Nicholas Bellinger <nab at linux-iscsi.org> > > > > > > This patch updates virtscsi_probe() to setup necessary Scsi_Host > > >

On Mon, Apr 07, 2014 at 01:56:59AM -0700, Nicholas A. Bellinger wrote: > On Mon, 2014-04-07 at 11:45 +0300, Michael S. Tsirkin wrote: > > On Sun, Apr 06, 2014 at 09:32:09PM +0000, Nicholas A. Bellinger wrote: > > > From: Nicholas Bellinger <nab at linux-iscsi.org> > > > > > > This patch updates virtscsi_probe() to setup necessary Scsi_Host > > >

From: Nicholas Bellinger <nab at linux-iscsi.org> This patch changes virtio-scsi to use a new virtio_driver->scan() callback so that scsi_scan_host() can be properly invoked once virtio_dev_probe() has set add_status(dev, VIRTIO_CONFIG_S_DRIVER_OK) to signal active virtio-ring operation, instead of from within virtscsi_probe(). This fixes a bug where SCSI LUN scanning for both

From: Nicholas Bellinger <nab at linux-iscsi.org> This patch changes virtio-scsi to use a new virtio_driver->scan() callback so that scsi_scan_host() can be properly invoked once virtio_dev_probe() has set add_status(dev, VIRTIO_CONFIG_S_DRIVER_OK) to signal active virtio-ring operation, instead of from within virtscsi_probe(). This fixes a bug where SCSI LUN scanning for both

On Mon, Apr 07, 2014 at 01:56:59AM -0700, Nicholas A. Bellinger wrote: > On Mon, 2014-04-07 at 11:45 +0300, Michael S. Tsirkin wrote: > > On Sun, Apr 06, 2014 at 09:32:09PM +0000, Nicholas A. Bellinger wrote: > > > From: Nicholas Bellinger <nab at linux-iscsi.org> > > > > > > This patch updates virtscsi_probe() to setup necessary Scsi_Host > > >

On Mon, Apr 07, 2014 at 01:56:59AM -0700, Nicholas A. Bellinger wrote: > On Mon, 2014-04-07 at 11:45 +0300, Michael S. Tsirkin wrote: > > On Sun, Apr 06, 2014 at 09:32:09PM +0000, Nicholas A. Bellinger wrote: > > > From: Nicholas Bellinger <nab at linux-iscsi.org> > > > > > > This patch updates virtscsi_probe() to setup necessary Scsi_Host > > >

On Sun, Apr 06, 2014 at 09:32:09PM +0000, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger <nab at linux-iscsi.org> > > This patch updates virtscsi_probe() to setup necessary Scsi_Host > level protection resources. (currently hardcoded to 1) > > It changes virtscsi_add_cmd() to attach outgoing / incoming > protection SGLs preceeding the data payload, and is

On Sun, Apr 06, 2014 at 09:32:09PM +0000, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger <nab at linux-iscsi.org> > > This patch updates virtscsi_probe() to setup necessary Scsi_Host > level protection resources. (currently hardcoded to 1) > > It changes virtscsi_add_cmd() to attach outgoing / incoming > protection SGLs preceeding the data payload, and is