similar to: vhost changes (batched) in linux-next after 12/13 trigger random crashes in KVM guests after reboot

On 18.12.19 16:10, Michael S. Tsirkin wrote: > On Wed, Dec 18, 2019 at 03:43:43PM +0100, Christian Borntraeger wrote: >> Michael, >> >> with >> commit db7286b100b503ef80612884453bed53d74c9a16 (refs/bisect/skip-db7286b100b503ef80612884453bed53d74c9a16) >> vhost: use batched version by default >> plus >> commit

On 18.12.19 16:10, Michael S. Tsirkin wrote: > On Wed, Dec 18, 2019 at 03:43:43PM +0100, Christian Borntraeger wrote: >> Michael, >> >> with >> commit db7286b100b503ef80612884453bed53d74c9a16 (refs/bisect/skip-db7286b100b503ef80612884453bed53d74c9a16) >> vhost: use batched version by default >> plus >> commit

On 06.01.20 11:50, Michael S. Tsirkin wrote: > On Wed, Dec 18, 2019 at 04:59:02PM +0100, Christian Borntraeger wrote: >> On 18.12.19 16:10, Michael S. Tsirkin wrote: >>> On Wed, Dec 18, 2019 at 03:43:43PM +0100, Christian Borntraeger wrote: >>>> Michael, >>>> >>>> with >>>> commit db7286b100b503ef80612884453bed53d74c9a16

On 06.01.20 11:50, Michael S. Tsirkin wrote: > On Wed, Dec 18, 2019 at 04:59:02PM +0100, Christian Borntraeger wrote: >> On 18.12.19 16:10, Michael S. Tsirkin wrote: >>> On Wed, Dec 18, 2019 at 03:43:43PM +0100, Christian Borntraeger wrote: >>>> Michael, >>>> >>>> with >>>> commit db7286b100b503ef80612884453bed53d74c9a16

On 07.01.20 10:39, Michael S. Tsirkin wrote: > On Tue, Jan 07, 2020 at 09:59:16AM +0100, Christian Borntraeger wrote: >> >> >> On 06.01.20 11:50, Michael S. Tsirkin wrote: >>> On Wed, Dec 18, 2019 at 04:59:02PM +0100, Christian Borntraeger wrote: >>>> On 18.12.19 16:10, Michael S. Tsirkin wrote: >>>>> On Wed, Dec 18, 2019 at 03:43:43PM

On 07.01.20 10:39, Michael S. Tsirkin wrote: > On Tue, Jan 07, 2020 at 09:59:16AM +0100, Christian Borntraeger wrote: >> >> >> On 06.01.20 11:50, Michael S. Tsirkin wrote: >>> On Wed, Dec 18, 2019 at 04:59:02PM +0100, Christian Borntraeger wrote: >>>> On 18.12.19 16:10, Michael S. Tsirkin wrote: >>>>> On Wed, Dec 18, 2019 at 03:43:43PM

On Tue, Jan 07, 2020 at 12:34:50PM +0100, Christian Borntraeger wrote: > > > On 07.01.20 10:39, Michael S. Tsirkin wrote: > > On Tue, Jan 07, 2020 at 09:59:16AM +0100, Christian Borntraeger wrote: > >> > >> > >> On 06.01.20 11:50, Michael S. Tsirkin wrote: > >>> On Wed, Dec 18, 2019 at 04:59:02PM +0100, Christian Borntraeger wrote: >

On Wed, Dec 18, 2019 at 04:59:02PM +0100, Christian Borntraeger wrote: > On 18.12.19 16:10, Michael S. Tsirkin wrote: > > On Wed, Dec 18, 2019 at 03:43:43PM +0100, Christian Borntraeger wrote: > >> Michael, > >> > >> with > >> commit db7286b100b503ef80612884453bed53d74c9a16 (refs/bisect/skip-db7286b100b503ef80612884453bed53d74c9a16) > >>

On Tue, Jan 07, 2020 at 09:59:16AM +0100, Christian Borntraeger wrote: > > > On 06.01.20 11:50, Michael S. Tsirkin wrote: > > On Wed, Dec 18, 2019 at 04:59:02PM +0100, Christian Borntraeger wrote: > >> On 18.12.19 16:10, Michael S. Tsirkin wrote: > >>> On Wed, Dec 18, 2019 at 03:43:43PM +0100, Christian Borntraeger wrote: > >>>> Michael, >

On Wed, Dec 18, 2019 at 03:43:43PM +0100, Christian Borntraeger wrote: > Michael, > > with > commit db7286b100b503ef80612884453bed53d74c9a16 (refs/bisect/skip-db7286b100b503ef80612884453bed53d74c9a16) > vhost: use batched version by default > plus > commit 6bd262d5eafcdf8cdfae491e2e748e4e434dcda6 (HEAD, refs/bisect/bad) > Revert "vhost/net: add an option to

On Thu, Feb 06, 2020 at 03:22:39PM +0100, eperezma at redhat.com wrote: > Hi Christian. > > Could you try this patch on top of ("38ced0208491 vhost: use batched version by default")? > > It will not solve your first random crash but it should help with the lost of network connectivity. > > Please let me know how does it goes. > > Thanks! > > >From

On 2020/6/8 ??8:52, Michael S. Tsirkin wrote: > As testing shows no performance change, switch to that now. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > Signed-off-by: Eugenio P?rez <eperezma at redhat.com> > Link: https://lore.kernel.org/r/20200401183118.8334-3-eperezma at redhat.com > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> >

On 2020/6/8 ??8:52, Michael S. Tsirkin wrote: > As testing shows no performance change, switch to that now. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > Signed-off-by: Eugenio P?rez <eperezma at redhat.com> > Link: https://lore.kernel.org/r/20200401183118.8334-3-eperezma at redhat.com > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> >

We let the specifics of the ring format seep through to vhost API callers - mostly because there was only one format so it was hard to imagine what an independent API would look like. Now that there's an alternative in form of the packed ring, it's easier to see the issues, and fixing them is perhaps the cleanest way to add support for more formats. This patchset does this by indtroducing

On Thu, Feb 06, 2020 at 04:12:21PM +0100, Christian Borntraeger wrote: > > > On 06.02.20 15:22, eperezma at redhat.com wrote: > > Hi Christian. > > > > Could you try this patch on top of ("38ced0208491 vhost: use batched version by default")? > > > > It will not solve your first random crash but it should help with the lost of network

On Thu, Feb 06, 2020 at 04:12:21PM +0100, Christian Borntraeger wrote: > > > On 06.02.20 15:22, eperezma at redhat.com wrote: > > Hi Christian. > > > > Could you try this patch on top of ("38ced0208491 vhost: use batched version by default")? > > > > It will not solve your first random crash but it should help with the lost of network

On 2020/6/2 ??9:06, Michael S. Tsirkin wrote: > Add a new API that doesn't assume used ring, heads, etc. > For now, we keep the old APIs around to make it easier > to convert drivers. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > --- > drivers/vhost/vhost.c | 52 ++++++++++++++++++++++++++++++++++--------- > drivers/vhost/vhost.h | 17

On 2020/6/2 ??9:06, Michael S. Tsirkin wrote: > Add a new API that doesn't assume used ring, heads, etc. > For now, we keep the old APIs around to make it easier > to convert drivers. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > --- > drivers/vhost/vhost.c | 52 ++++++++++++++++++++++++++++++++++--------- > drivers/vhost/vhost.h | 17

On Fri, 7 Feb 2020 09:13:14 +0100 Christian Borntraeger <borntraeger at de.ibm.com> wrote: > On 07.02.20 08:58, Michael S. Tsirkin wrote: > > On Fri, Feb 07, 2020 at 08:47:14AM +0100, Christian Borntraeger wrote: > >> Also adding Cornelia. > >> > >> > >> On 06.02.20 23:17, Michael S. Tsirkin wrote: > >>> On Thu, Feb 06, 2020 at

This adds infrastructure required for supporting multiple ring formats. The idea is as follows: we convert descriptors to an independent format first, and process that converting to iov later. Used ring is similar: we fetch into an independent struct first, convert that to IOV later. The point is that we have a tight loop that fetches descriptors, which is good for cache utilization. This will