similar to: [PATCH RFC v7 net-next] netdev: pass the stuck queue to the timeout handler

Em qua., 27 de nov. de 2019 ?s 12:12, Martin Habets <mhabets at solarflare.com> escreveu: > > Your @work correctly identifies that the drivers/net/ethernet/sfc drivers need patching, but the actual patches for them are missing. > Please add those. Makes me wonder if any other files are missing patches. Since, I'm adding new stuffs to virtion_net (2/2), I will split this into a

This allows incrementing the correct timeout statistic without any mess. Down the road, devices can learn to reset just the specific queue. The patch was generated with the following script: use strict; use warnings; our $^I = '.bak'; my @work = ( ["arch/m68k/emu/nfeth.c", "nfeth_tx_timeout"], ["arch/um/drivers/net_kern.c", "uml_net_tx_timeout"],

This allows incrementing the correct timeout statistic without any mess. Down the road, devices can learn to reset just the specific queue. The patch was generated with the following script: use strict; use warnings; our $^I = '.bak'; my @work = ( ["arch/m68k/emu/nfeth.c", "nfeth_tx_timeout"], ["arch/um/drivers/net_kern.c", "uml_net_tx_timeout"],

On Sun, Nov 24, 2019 at 03:03:52PM -0800, Jakub Kicinski wrote: > On Sun, 24 Nov 2019 16:48:35 -0500, Michael S. Tsirkin wrote: > > diff --git a/arch/m68k/emu/nfeth.c b/arch/m68k/emu/nfeth.c > > index a4ebd2445eda..8e06e7407854 100644 > > --- a/arch/m68k/emu/nfeth.c > > +++ b/arch/m68k/emu/nfeth.c > > @@ -167,7 +167,7 @@ static int nfeth_xmit(struct sk_buff *skb,

This allows incrementing the correct timeout statistic without any mess. Down the road, devices can learn to reset just the specific queue. The patch was generated with the following script: use strict; use warnings; our $^I = '.bak'; my @work = ( ["arch/m68k/emu/nfeth.c", "nfeth_tx_timeout"], ["arch/um/drivers/net_kern.c", "uml_net_tx_timeout"],

This allows incrementing the correct timeout statistic without any mess. Down the road, devices can learn to reset just the specific queue. The patch was generated with the following script: use strict; use warnings; our $^I = '.bak'; my @work = ( ["arch/m68k/emu/nfeth.c", "nfeth_tx_timeout"], ["arch/um/drivers/net_kern.c", "uml_net_tx_timeout"],

On Fri, Nov 22, 2019 at 09:59:58AM -0300, Julio Faracco wrote: > I need your help with debbuging information. What kind of field shoud > it notify when a TX timeout occurs? So here's v2. Still untested. ---> netdev: pass the stuck queue to the timeout handler This allows incrementing the correct timeout statistic without any mess. Down the road, devices can learn to reset just the

On Fri, Nov 22, 2019 at 09:59:58AM -0300, Julio Faracco wrote: > Hi Michael, > > Em sex., 22 de nov. de 2019 ?s 07:31, Michael S. Tsirkin > <mst at redhat.com> escreveu: > > > > On Thu, Nov 21, 2019 at 10:36:36PM -0300, Julio Faracco wrote: > > > Driver virtio_net is not handling error events for TX provided by > > > dev_watchdog. This event is

Em sex., 22 de nov. de 2019 ?s 11:53, Michael S. Tsirkin <mst at redhat.com> escreveu: > > On Fri, Nov 22, 2019 at 09:59:58AM -0300, Julio Faracco wrote: > > Hi Michael, > > > > Em sex., 22 de nov. de 2019 ?s 07:31, Michael S. Tsirkin > > <mst at redhat.com> escreveu: > > > > > > On Thu, Nov 21, 2019 at 10:36:36PM -0300, Julio Faracco

On Sun, Nov 24, 2019 at 10:05:54AM -0500, Michael S. Tsirkin wrote: > On Fri, Nov 22, 2019 at 09:59:58AM -0300, Julio Faracco wrote: > > I need your help with debbuging information. What kind of field shoud > > it notify when a TX timeout occurs? > > So here's v2. OK this still missed a couple of things. Here's another one - still untested. One good thing is this is

On Sun, Nov 24, 2019 at 10:05:54AM -0500, Michael S. Tsirkin wrote: > On Fri, Nov 22, 2019 at 09:59:58AM -0300, Julio Faracco wrote: > > I need your help with debbuging information. What kind of field shoud > > it notify when a TX timeout occurs? > > So here's v2. OK this still missed a couple of things. Here's another one - still untested. One good thing is this is

A bunch of drivers want to know which tx queue triggered a timeout, and virtio wants to do the same. We actually have the info to hand, let's just pass it on to drivers. Note: tested with an experimental virtio patch by Julio. That patch itself isn't ready yet though, so not included. Other drivers compiled only. Michael S. Tsirkin (3): netdev: pass the stuck queue to the timeout

Sorry about the churn, v10 was based on net - not on net-next by mistake. A bunch of drivers want to know which tx queue triggered a timeout, and virtio wants to do the same. We actually have the info to hand, let's just pass it on to drivers. Note: tested with an experimental virtio patch by Julio. That patch itself isn't ready yet though, so not included. Other drivers compiled only.

Sorry about the churn, v10 was based on net - not on net-next by mistake. A bunch of drivers want to know which tx queue triggered a timeout, and virtio wants to do the same. We actually have the info to hand, let's just pass it on to drivers. Note: tested with an experimental virtio patch by Julio. That patch itself isn't ready yet though, so not included. Other drivers compiled only.

Yet another forward declaration I missed. Hopfully the last one ... A bunch of drivers want to know which tx queue triggered a timeout, and virtio wants to do the same. We actually have the info to hand, let's just pass it on to drivers. Note: tested with an experimental virtio patch by Julio. That patch itself isn't ready yet though, so not included. Other drivers compiled only.

A bunch of drivers want to know which tx queue triggered a timeout, and virtio wants to do the same. We actually have the info to hand, let's just pass it on to drivers. Note: tested with an experimental virtio patch by Julio. That patch itself isn't ready yet though, so not included. Other drivers compiled only. Michael S. Tsirkin (3): netdev: pass the stuck queue to the timeout

A bunch of drivers want to know which tx queue triggered a timeout, and virtio wants to do the same. We actually have the info to hand, let's just pass it on to drivers. Note: tested with an experimental virtio patch by Julio. That patch itself isn't ready yet though, so not included. Other drivers compiled only. Michael S. Tsirkin (3): netdev: pass the stuck queue to the timeout

This series add two important features. One of them changes the .ndo_tx_timeout to include an extra parameter to identify the stuck queue. Many drivers are using a nester loop to identify which queue is stooped/stucked. This is a redundant work since dev_watchdog is doing exactly the same thing. This is so interesting for other drivers to in terms of code optimization. The second part (second

This series add two important features. One of them changes the .ndo_tx_timeout to include an extra parameter to identify the stuck queue. Many drivers are using a nester loop to identify which queue is stooped/stucked. This is a redundant work since dev_watchdog is doing exactly the same thing. This is so interesting for other drivers to in terms of code optimization. The second part (second

I think that it may be appropriate to submit this patch for linux-next instead of 3.15-rc4... On Thu, May 8, 2014 at 1:53 PM, Wilfried Klaebe <w-lkml at lebenslange-mailadresse.de> wrote: > Dave Miller mentioned he'd like to see SET_ETHTOOL_OPS gone. > This does that. > > Compile tested only, but I'd seriously wonder if this broke anything. > > Suggested-by: Dave