similar to: [PATCH net-next 2/6] vsock: add VMADDR_CID_LOCAL definition

v2: - style fixes [Dave] - removed RCU sync and changed 'the_vsock_loopback' in a global static variable [Stefan] - use G2H transport when local transport is not loaded and remote cid is VMADDR_CID_LOCAL [Stefan] - rebased on net-next v1: https://patchwork.kernel.org/cover/11251735/ This series introduces a new transport (vsock_loopback) to handle local communication. This

> From: Stefano Garzarella [mailto:sgarzare at redhat.com] > Sent: Tuesday, November 19, 2019 12:01 PM > This series introduces a new transport (vsock_loopback) to handle > local communication. > This could be useful to test vsock core itself and to allow developers > to test their applications without launching a VM. > > Before this series, vmci and virtio transports

> From: Stefano Garzarella [mailto:sgarzare at redhat.com] > Sent: Tuesday, November 19, 2019 12:01 PM > This series introduces a new transport (vsock_loopback) to handle > local communication. > This could be useful to test vsock core itself and to allow developers > to test their applications without launching a VM. > > Before this series, vmci and virtio transports

On Tue, Nov 19, 2019 at 12:01:15PM +0100, Stefano Garzarella wrote: > This series introduces a new transport (vsock_loopback) to handle > local communication. > This could be useful to test vsock core itself and to allow developers > to test their applications without launching a VM. > > Before this series, vmci and virtio transports allowed this behavior, > but only in the

On Thu, Nov 21, 2019 at 02:45:32PM +0000, Jorgen Hansen wrote: > > From: Stefano Garzarella [mailto:sgarzare at redhat.com] > > Sent: Tuesday, November 19, 2019 12:01 PM > > This series introduces a new transport (vsock_loopback) to handle > > local communication. > > This could be useful to test vsock core itself and to allow developers > > to test their

On Tue, Nov 19, 2019 at 12:01:20PM +0100, Stefano Garzarella wrote: > @@ -420,9 +436,10 @@ int vsock_assign_transport(struct vsock_sock *vsk, struct vsock_sock *psk) > new_transport = transport_dgram; > break; > case SOCK_STREAM: > - if (remote_cid <= VMADDR_CID_HOST || > - (transport_g2h && > - remote_cid == transport_g2h->get_local_cid()))

In the vsock vmci_transport driver, sock_put wasn't safe to call in interrupt context, since that may call the vsock destructor which in turn calls several functions that should only be called from process context. This change defers the callling of these functions to a worker thread. All these functions were deallocation of resources related to the transport itself. Furthermore, an unused

In the vsock vmci_transport driver, sock_put wasn't safe to call in interrupt context, since that may call the vsock destructor which in turn calls several functions that should only be called from process context. This change defers the callling of these functions to a worker thread. All these functions were deallocation of resources related to the transport itself. Furthermore, an unused

On Mon, Feb 10, 2020 at 12:45:47PM +0000, Richard W.M. Jones wrote: > Since Linux >= 5.6 supports vsock in loopback mode, I was able to add > a regression test for this feature to nbdkit / libnbd, and I can > report that it appears to work fine. > > https://github.com/libguestfs/nbdkit/commit/5e4745641bb4676f607fdb3f8750dbf6e9516877 > I'm happy that it works and it is

On Mon, Nov 11, 2019 at 01:53:39PM +0000, Jorgen Hansen wrote: > > From: Stefano Garzarella [mailto:sgarzare at redhat.com] > > Sent: Wednesday, October 23, 2019 11:56 AM > > Thanks a lot for working on this! > Thanks to you for the reviews! > > With the multi-transports support, we can use vsock with nested VMs (using > > also different hypervisors) loading

> From: Stefano Garzarella [mailto:sgarzare at redhat.com] > Sent: Monday, November 11, 2019 6:18 PM > To: Jorgen Hansen <jhansen at vmware.com> > Subject: Re: [PATCH net-next 11/14] vsock: add multi-transports support > > On Mon, Nov 11, 2019 at 01:53:39PM +0000, Jorgen Hansen wrote: > > > From: Stefano Garzarella [mailto:sgarzare at redhat.com] > > >

> From: Stefano Garzarella [mailto:sgarzare at redhat.com] > Sent: Monday, November 11, 2019 6:18 PM > To: Jorgen Hansen <jhansen at vmware.com> > Subject: Re: [PATCH net-next 11/14] vsock: add multi-transports support > > On Mon, Nov 11, 2019 at 01:53:39PM +0000, Jorgen Hansen wrote: > > > From: Stefano Garzarella [mailto:sgarzare at redhat.com] > > >

On Tue, Nov 12, 2019 at 09:59:12AM +0000, Jorgen Hansen wrote: > > From: Stefano Garzarella [mailto:sgarzare at redhat.com] > > Sent: Monday, November 11, 2019 6:18 PM > > To: Jorgen Hansen <jhansen at vmware.com> > > Subject: Re: [PATCH net-next 11/14] vsock: add multi-transports support > > > > On Mon, Nov 11, 2019 at 01:53:39PM +0000, Jorgen Hansen

On Mon, Feb 10, 2020 at 02:05:27PM +0100, Stefano Garzarella wrote: > On Mon, Feb 10, 2020 at 12:45:47PM +0000, Richard W.M. Jones wrote: > > Since Linux >= 5.6 supports vsock in loopback mode, I was able to add > > a regression test for this feature to nbdkit / libnbd, and I can > > report that it appears to work fine. > > > >

> From: Stefano Garzarella [mailto:sgarzare at redhat.com] > Sent: Tuesday, November 12, 2019 11:37 AM > > > > You already mentioned that you are working on a fix for loopback > > > > here for the guest, but presumably a host could also do loopback. > > > > > > IIUC we don't support loopback in the host, because in this case the > > >

This header file now only includes the "uapi/linux/vm_sockets.h". We can include directly it when needed. Signed-off-by: Stefano Garzarella <sgarzare at redhat.com> --- include/linux/vm_sockets.h | 13 ------------- include/net/af_vsock.h | 2 +- include/net/vsock_addr.h | 2 +- net/vmw_vsock/vmci_transport_notify.h | 1 - 4 files

This header file now only includes the "uapi/linux/vm_sockets.h". We can include directly it when needed. Reviewed-by: Stefan Hajnoczi <stefanha at redhat.com> Signed-off-by: Stefano Garzarella <sgarzare at redhat.com> --- include/linux/vm_sockets.h | 13 ------------- include/net/af_vsock.h | 2 +- include/net/vsock_addr.h | 2 +-

The AF_VSOCK protocol added in Linux 5.6 uses a 32 bit port number. For NBD we map this to simple URIs[1] like nbd+vsock://CID:PORT (where CID is a number that acts a bit like a hostname and PORT is a 32 bit port number). eg: nbd+vsock://1:1000000000/ would be port 10^9 on the loopback address VMADDR_CID_LOCAL (== 1). The problem is that libxml2 arbitrarily limits port numbers to 999,999,999.

Now that kernels support vsock loopback, we have no reason to forbid --vsock with --run. Signed-off-by: Eric Blake <eblake@redhat.com> --- I'm hoping to commit something like this, but right now, the testsuite is failing more times than it succeeds, with: + port=1082294412 + nbdkit --vsock --port 1082294412 memory 1M --run 'sleep 1; nbdsh -u "$uri" -c

Update the maintainers file to include maintainers for the VMware vmci driver, af_vsock, and the vsock vmci transport. Signed-off-by: Jorgen Hansen <jhansen at vmware.com> --- MAINTAINERS | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e17ebf7..b9714fc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -16630,6 +16630,14 @@ S: Maintained