similar to: [PATCH RFC net-next 0/2] drivers: net: virtio_net: Implement

Driver virtio_net is not handling error events for TX provided by dev_watchdog. This event is reached when transmission queue is having problems to transmit packets. This could happen for any reason. To enable it, driver should have .ndo_tx_timeout implemented. This commit brings back virtnet_reset method to recover TX queues from a error state. That function is called by schedule_work method and

Driver virtio_net is not handling error events for TX provided by dev_watchdog. This event is reached when transmission queue is having problems to transmit packets. This could happen for any reason. To enable it, driver should have .ndo_tx_timeout implemented. This commit brings back virtnet_reset method to recover TX queues from a error state. That function is called by schedule_work method and

On Sun, Oct 06, 2019 at 03:45:15PM -0300, jcfaracco at gmail.com wrote: > From: Julio Faracco <jcfaracco at gmail.com> > > To enable dev_watchdog, virtio_net should have a tx_timeout defined > (.ndo_tx_timeout). This is only a skeleton to throw a warn message. It > notifies the event in some specific queue of device. This function > still counts tx_timeout statistic and

On Sun, Oct 06, 2019 at 03:45:15PM -0300, jcfaracco at gmail.com wrote: > From: Julio Faracco <jcfaracco at gmail.com> > > To enable dev_watchdog, virtio_net should have a tx_timeout defined > (.ndo_tx_timeout). This is only a skeleton to throw a warn message. It > notifies the event in some specific queue of device. This function > still counts tx_timeout statistic and

Em seg, 7 de out de 2019 ?s 11:15, Julian Wiedmann <jwi at linux.ibm.com> escreveu: > > On 06.10.19 20:45, jcfaracco at gmail.com wrote: > > From: Julio Faracco <jcfaracco at gmail.com> > > > > For debug purpose of TX timeout events, a tx_timeout entry was added to > > monitor this special case: when dev_watchdog identifies a tx_timeout and > > throw

2015-06-24 3:10 GMT-03:00 Michael S. Tsirkin <mst at redhat.com>: > > On Tue, Jun 23, 2015 at 10:44:29PM -0300, Julio Faracco wrote: > > virtio_net paravirtualized driver does not have a tx_timeout() function to > > guarantee that the driver will recover properly after receiving a timeout > > during a transmission of a packet. This patch add this feature and throw a

2015-06-24 3:10 GMT-03:00 Michael S. Tsirkin <mst at redhat.com>: > > On Tue, Jun 23, 2015 at 10:44:29PM -0300, Julio Faracco wrote: > > virtio_net paravirtualized driver does not have a tx_timeout() function to > > guarantee that the driver will recover properly after receiving a timeout > > during a transmission of a packet. This patch add this feature and throw a

virtio_net paravirtualized driver does not have a tx_timeout() function to guarantee that the driver will recover properly after receiving a timeout during a transmission of a packet. This patch add this feature and throw a timeout exception after 5 HZ. Considering some tests, this is the best time to use here. Signed-off-by: Julio Faracco <jcfaracco at gmail.com> Cc: Jason Wang

virtio_net paravirtualized driver does not have a tx_timeout() function to guarantee that the driver will recover properly after receiving a timeout during a transmission of a packet. This patch add this feature and throw a timeout exception after 5 HZ. Considering some tests, this is the best time to use here. Signed-off-by: Julio Faracco <jcfaracco at gmail.com> Cc: Jason Wang

On Thu, Nov 21, 2019 at 10:36:36PM -0300, Julio Faracco wrote: > Driver virtio_net is not handling error events for TX provided by > dev_watchdog. This event is reached when transmission queue is having > problems to transmit packets. This could happen for any reason. To > enable it, driver should have .ndo_tx_timeout implemented. > > This commit brings back virtnet_reset method

Driver virtio_net is not handling error events for TX provided by dev_watchdog. This event is reached when transmission queue is having problems to transmit packets. This could happen for any reason. To enable it, driver should have .ndo_tx_timeout implemented. This commit brings back virtnet_reset method to recover TX queues from a error state. That function is called by schedule_work method and

Driver virtio_net is not handling error events for TX provided by dev_watchdog. This event is reached when transmission queue is having problems to transmit packets. This could happen for any reason. To enable it, driver should have .ndo_tx_timeout implemented. This commit brings back virtnet_reset method to recover TX queues from a error state. That function is called by schedule_work method and

> On Wed, Jun 24, 2015 at 10:31:09PM -0300, Julio Faracco wrote: > > 2015-06-24 3:10 GMT-03:00 Michael S. Tsirkin <mst at redhat.com>: > > > > > > On Tue, Jun 23, 2015 at 10:44:29PM -0300, Julio Faracco wrote: > > > > virtio_net paravirtualized driver does not have a tx_timeout() function > > > > to > > > > guarantee that the

> On Wed, Jun 24, 2015 at 10:31:09PM -0300, Julio Faracco wrote: > > 2015-06-24 3:10 GMT-03:00 Michael S. Tsirkin <mst at redhat.com>: > > > > > > On Tue, Jun 23, 2015 at 10:44:29PM -0300, Julio Faracco wrote: > > > > virtio_net paravirtualized driver does not have a tx_timeout() function > > > > to > > > > guarantee that the

Commit 5b8f3c8d30a6 ("virtio_net: Add XDP related stats") tries to count TX XDP stats in virtnet_receive(). This will cause several issues: - virtnet_xdp_sq() was called without checking whether or not XDP is set. This may cause out of bound access when there's no enough txq for XDP. - Stats were updated even if there's no XDP/XDP_TX. Fixing this by reusing

Commit 5b8f3c8d30a6 ("virtio_net: Add XDP related stats") tries to count TX XDP stats in virtnet_receive(). This will cause several issues: - virtnet_xdp_sq() was called without checking whether or not XDP is set. This may cause out of bound access when there's no enough txq for XDP. - Stats were updated even if there's no XDP/XDP_TX. Fixing this by reusing

Hi Michael, Em sex., 22 de nov. de 2019 ?s 07:31, Michael S. Tsirkin <mst at redhat.com> escreveu: > > On Thu, Nov 21, 2019 at 10:36:36PM -0300, Julio Faracco wrote: > > Driver virtio_net is not handling error events for TX provided by > > dev_watchdog. This event is reached when transmission queue is having > > problems to transmit packets. This could happen for any

Hi Michael, Em sex., 22 de nov. de 2019 ?s 07:31, Michael S. Tsirkin <mst at redhat.com> escreveu: > > On Thu, Nov 21, 2019 at 10:36:36PM -0300, Julio Faracco wrote: > > Driver virtio_net is not handling error events for TX provided by > > dev_watchdog. This event is reached when transmission queue is having > > problems to transmit packets. This could happen for any

This series add two important features. One of them changes the .ndo_tx_timeout to include an extra parameter to identify the stuck queue. Many drivers are using a nester loop to identify which queue is stooped/stucked. This is a redundant work since dev_watchdog is doing exactly the same thing. This is so interesting for other drivers to in terms of code optimization. The second part (second

This series add two important features. One of them changes the .ndo_tx_timeout to include an extra parameter to identify the stuck queue. Many drivers are using a nester loop to identify which queue is stooped/stucked. This is a redundant work since dev_watchdog is doing exactly the same thing. This is so interesting for other drivers to in terms of code optimization. The second part (second