similar to: virtq questions

On Thu, Oct 03, 2019 at 10:42:44AM +0200, Miklos Szeredi wrote: > On Wed, Oct 2, 2019 at 3:27 PM Vivek Goyal <vgoyal at redhat.com> wrote: > > > > On Wed, Oct 02, 2019 at 09:40:11AM +0200, Miklos Szeredi wrote: > > > Looking at the ugly retry logic in virtiofs and have some questions. > > > > Hi Miklos, > > > > What are you thinking w.r.t

With virtio-1, we support more than 32 feature bits. Let's extend both host and guest features to 64, which should suffice for a while. vhost and migration have been ignored for now. Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> --- hw/9pfs/virtio-9p-device.c | 2 +- hw/block/virtio-blk.c | 2 +- hw/char/virtio-serial-bus.c | 2 +-

With virtio-1, we support more than 32 feature bits. Let's extend both host and guest features to 64, which should suffice for a while. vhost and migration have been ignored for now. Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> --- hw/9pfs/virtio-9p-device.c | 2 +- hw/block/virtio-blk.c | 2 +- hw/char/virtio-serial-bus.c | 2 +-

With virtio-1, we support more than 32 feature bits. Let's extend both host and guest features to 64, which should suffice for a while. vhost and migration have been ignored for now. Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> --- hw/9pfs/virtio-9p-device.c | 2 +- hw/block/virtio-blk.c | 2 +- hw/char/virtio-serial-bus.c | 2 +-

With virtio-1, we support more than 32 feature bits. Let's extend both host and guest features to 64, which should suffice for a while. vhost and migration have been ignored for now. Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> --- hw/9pfs/virtio-9p-device.c | 2 +- hw/block/virtio-blk.c | 2 +- hw/char/virtio-serial-bus.c | 2 +-

On Wed, Oct 02, 2019 at 09:40:11AM +0200, Miklos Szeredi wrote: > Looking at the ugly retry logic in virtiofs and have some questions. Hi Miklos, What are you thinking w.r.t cleanup of retry logic. As of now we put requests in a list and retry later with the help of a worker. Other option will probably be block the submitter if queue is full. Make it sleep, wake up after a while and retry

On Sun, Sep 08, 2019 at 07:53:55PM +0800, piaojun wrote: > > > On 2019/9/6 19:52, Miklos Szeredi wrote: > > On Fri, Sep 6, 2019 at 12:36 PM Stefan Hajnoczi <stefanha at redhat.com> wrote: > >> > >> On Fri, Sep 06, 2019 at 10:15:14AM +0200, Miklos Szeredi wrote: > >>> On Thu, Sep 5, 2019 at 9:49 PM Vivek Goyal <vgoyal at redhat.com> wrote:

On Fri, Sep 06, 2019 at 01:52:41PM +0200, Miklos Szeredi wrote: > On Fri, Sep 6, 2019 at 12:36 PM Stefan Hajnoczi <stefanha at redhat.com> wrote: > > > > On Fri, Sep 06, 2019 at 10:15:14AM +0200, Miklos Szeredi wrote: > > > On Thu, Sep 5, 2019 at 9:49 PM Vivek Goyal <vgoyal at redhat.com> wrote: > > > > > > > > Hi, > > > >

On Fri, Sep 06, 2019 at 01:52:41PM +0200, Miklos Szeredi wrote: > On Fri, Sep 6, 2019 at 12:36 PM Stefan Hajnoczi <stefanha at redhat.com> wrote: > > > > On Fri, Sep 06, 2019 at 10:15:14AM +0200, Miklos Szeredi wrote: > > > On Thu, Sep 5, 2019 at 9:49 PM Vivek Goyal <vgoyal at redhat.com> wrote: > > > > > > > > Hi, > > > >

On Tue, Sep 03, 2019 at 10:05:02AM +0200, Miklos Szeredi wrote: > [Cc: virtualization at lists.linux-foundation.org, "Michael S. Tsirkin" > <mst at redhat.com>, Jason Wang <jasowang at redhat.com>] > > It'd be nice to have an ACK for this from the virtio maintainers. > > Thanks, > Miklos Can the patches themselves be posted to the relevant list(s)

On Tue, Sep 03, 2019 at 10:05:02AM +0200, Miklos Szeredi wrote: > [Cc: virtualization at lists.linux-foundation.org, "Michael S. Tsirkin" > <mst at redhat.com>, Jason Wang <jasowang at redhat.com>] > > It'd be nice to have an ACK for this from the virtio maintainers. > > Thanks, > Miklos Can the patches themselves be posted to the relevant list(s)

On Tue, Sep 10, 2019 at 05:12:02PM +0200, Miklos Szeredi wrote: > Git tree for this version is available here: > > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#virtiofs-v5 > > Only post patches that actually add virtiofs (virtiofs-v5-base..virtiofs-v5). > > I've folded the series from Vivek and fixed a couple of TODO comments > myself. AFAICS two

On Tue, Sep 10, 2019 at 05:12:02PM +0200, Miklos Szeredi wrote: > Git tree for this version is available here: > > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#virtiofs-v5 > > Only post patches that actually add virtiofs (virtiofs-v5-base..virtiofs-v5). > > I've folded the series from Vivek and fixed a couple of TODO comments > myself. AFAICS two

On Fri, Sep 06, 2019 at 10:15:14AM +0200, Miklos Szeredi wrote: > On Thu, Sep 5, 2019 at 9:49 PM Vivek Goyal <vgoyal at redhat.com> wrote: > > > > Hi, > > > > Michael Tsirkin pointed out issues w.r.t various locking related TODO > > items and races w.r.t device removal. > > > > In this first round of cleanups, I have taken care of most pressing

On Mon, Aug 10, 2020 at 09:29:47AM +0200, Miklos Szeredi wrote: > On Fri, Aug 7, 2020 at 9:55 PM Vivek Goyal <vgoyal at redhat.com> wrote: > > > > > Most of the changes are limited to fuse/virtiofs. There are couple > > of changes needed in generic dax infrastructure and couple of changes > > in virtio to be able to access shared memory region. > > So

From: Vivek Goyal <vgoyal at redhat.com> [ Upstream commit bb737bbe48bea9854455cb61ea1dc06e92ce586c ] In virtiofs (unlike in regular fuse) processing of async replies is serialized. This can result in a deadlock in rare corner cases when there's a circular dependency between the completion of two or more async replies. Such a deadlock can be reproduced with xfstests:generic/503 if

From: Vivek Goyal <vgoyal at redhat.com> [ Upstream commit bb737bbe48bea9854455cb61ea1dc06e92ce586c ] In virtiofs (unlike in regular fuse) processing of async replies is serialized. This can result in a deadlock in rare corner cases when there's a circular dependency between the completion of two or more async replies. Such a deadlock can be reproduced with xfstests:generic/503 if

This adds a flag to enable/disable bypassing the IOMMU by virtio devices. This is on top of patch http://article.gmane.org/gmane.comp.emulators.qemu/403467 virtio: convert to use DMA api Tested with patchset http://article.gmane.org/gmane.linux.kernel.virtualization/27545 virtio-pci: iommu support Signed-off-by: Michael S. Tsirkin <mst at redhat.com> ---

This adds a flag to enable/disable bypassing the IOMMU by virtio devices. This is on top of patch http://article.gmane.org/gmane.comp.emulators.qemu/403467 virtio: convert to use DMA api Tested with patchset http://article.gmane.org/gmane.linux.kernel.virtualization/27545 virtio-pci: iommu support Signed-off-by: Michael S. Tsirkin <mst at redhat.com> ---

Add Stefano and Anthony On Thu, Apr 21, 2016 at 04:43:45PM +0300, Michael S. Tsirkin wrote: > This adds a flag to enable/disable bypassing the IOMMU by > virtio devices. > > This is on top of patch > http://article.gmane.org/gmane.comp.emulators.qemu/403467 > virtio: convert to use DMA api > > Tested with patchset >