similar to: [PATCH net v5] failover: allow name change on IFF_UP slave interfaces

On Wed, Mar 06, 2019 at 10:08:32PM -0500, Si-Wei Liu wrote: > When a netdev appears through hot plug then gets enslaved by a failover > master that is already up and running, the slave will be opened > right away after getting enslaved. Today there's a race that userspace > (udev) may fail to rename the slave if the kernel (net_failover) > opens the slave earlier than when the

On Wed, Mar 06, 2019 at 10:08:32PM -0500, Si-Wei Liu wrote: > When a netdev appears through hot plug then gets enslaved by a failover > master that is already up and running, the slave will be opened > right away after getting enslaved. Today there's a race that userspace > (udev) may fail to rename the slave if the kernel (net_failover) > opens the slave earlier than when the

On 4/2/2019 8:14 PM, Stephen Hemminger wrote: > On Tue, 2 Apr 2019 15:23:29 -0700 > si-wei liu <si-wei.liu at oracle.com> wrote: > >> On 4/2/2019 2:53 PM, Stephen Hemminger wrote: >>> On Mon, 1 Apr 2019 19:04:53 -0400 >>> Si-Wei Liu <si-wei.liu at oracle.com> wrote: >>> >>>> + if (dev->flags & IFF_UP &&

On Wed, Apr 03, 2019 at 12:52:47AM -0400, Si-Wei Liu wrote: > When a netdev appears through hot plug then gets enslaved by a failover > master that is already up and running, the slave will be opened > right away after getting enslaved. Today there's a race that userspace > (udev) may fail to rename the slave if the kernel (net_failover) > opens the slave earlier than when the

On Wed, Apr 03, 2019 at 12:52:47AM -0400, Si-Wei Liu wrote: > When a netdev appears through hot plug then gets enslaved by a failover > master that is already up and running, the slave will be opened > right away after getting enslaved. Today there's a race that userspace > (udev) may fail to rename the slave if the kernel (net_failover) > opens the slave earlier than when the

On Mon, Apr 08, 2019 at 07:45:27PM -0400, Si-Wei Liu wrote: > When a netdev appears through hot plug then gets enslaved by a failover > master that is already up and running, the slave will be opened > right away after getting enslaved. Today there's a race that userspace > (udev) may fail to rename the slave if the kernel (net_failover) > opens the slave earlier than when the

On Mon, Apr 08, 2019 at 04:24:45PM -0400, Si-Wei Liu wrote: > When a netdev appears through hot plug then gets enslaved by a failover > master that is already up and running, the slave will be opened > right away after getting enslaved. Today there's a race that userspace > (udev) may fail to rename the slave if the kernel (net_failover) > opens the slave earlier than when the

On 3/19/2019 10:20 PM, si-wei liu wrote: > Hi Sridhar, > > Are you fine with leaving the IFF_SLAVE_RENAME_OK flag as is, and thus > can provide your Ack-by or Reviewed-by? I can change the code if you > feel strong. My preference would be not to introduce a new flag unless there is any usecase where we want a IFF_FAILOVER_SLAVE type of device to support 2 different behaviors.

On 3/6/2019 7:08 PM, Si-Wei Liu wrote: > When a netdev appears through hot plug then gets enslaved by a failover > master that is already up and running, the slave will be opened > right away after getting enslaved. Today there's a race that userspace > (udev) may fail to rename the slave if the kernel (net_failover) > opens the slave earlier than when the userspace rename

> On 21 Mar 2019, at 16:04, Michael S. Tsirkin <mst at redhat.com> wrote: > > On Wed, Mar 06, 2019 at 10:08:32PM -0500, Si-Wei Liu wrote: >> When a netdev appears through hot plug then gets enslaved by a failover >> master that is already up and running, the slave will be opened >> right away after getting enslaved. Today there's a race that userspace >>

On Thu, Mar 21, 2019 at 04:20:40PM +0200, Liran Alon wrote: > > > > On 21 Mar 2019, at 16:04, Michael S. Tsirkin <mst at redhat.com> wrote: > > > > On Wed, Mar 06, 2019 at 10:08:32PM -0500, Si-Wei Liu wrote: > >> When a netdev appears through hot plug then gets enslaved by a failover > >> master that is already up and running, the slave will be

On Tue, May 22, 2018 at 05:36:14PM +0200, Jiri Pirko wrote: > Tue, May 22, 2018 at 05:28:42PM CEST, sridhar.samudrala at intel.com wrote: > > > >On 5/22/2018 2:08 AM, Jiri Pirko wrote: > >> Tue, May 22, 2018 at 11:06:37AM CEST, jiri at resnulli.us wrote: > >> > Tue, May 22, 2018 at 04:06:18AM CEST, sridhar.samudrala at intel.com wrote: > >> > >

On Tue, May 22, 2018 at 05:36:14PM +0200, Jiri Pirko wrote: > Tue, May 22, 2018 at 05:28:42PM CEST, sridhar.samudrala at intel.com wrote: > > > >On 5/22/2018 2:08 AM, Jiri Pirko wrote: > >> Tue, May 22, 2018 at 11:06:37AM CEST, jiri at resnulli.us wrote: > >> > Tue, May 22, 2018 at 04:06:18AM CEST, sridhar.samudrala at intel.com wrote: > >> > >

On 5/22/2018 9:12 AM, Jiri Pirko wrote: > Fixing the subj, sorry about that. > > Tue, May 22, 2018 at 05:46:21PM CEST, mst at redhat.com wrote: >> On Tue, May 22, 2018 at 05:36:14PM +0200, Jiri Pirko wrote: >>> Tue, May 22, 2018 at 05:28:42PM CEST, sridhar.samudrala at intel.com wrote: >>>> On 5/22/2018 2:08 AM, Jiri Pirko wrote: >>>>> Tue, May

On 5/22/2018 9:12 AM, Jiri Pirko wrote: > Fixing the subj, sorry about that. > > Tue, May 22, 2018 at 05:46:21PM CEST, mst at redhat.com wrote: >> On Tue, May 22, 2018 at 05:36:14PM +0200, Jiri Pirko wrote: >>> Tue, May 22, 2018 at 05:28:42PM CEST, sridhar.samudrala at intel.com wrote: >>>> On 5/22/2018 2:08 AM, Jiri Pirko wrote: >>>>> Tue, May

On 5/22/2018 2:08 AM, Jiri Pirko wrote: > Tue, May 22, 2018 at 11:06:37AM CEST, jiri at resnulli.us wrote: >> Tue, May 22, 2018 at 04:06:18AM CEST, sridhar.samudrala at intel.com wrote: >>> Use the registration/notification framework supported by the generic >>> failover infrastructure. >>> >>> Signed-off-by: Sridhar Samudrala <sridhar.samudrala at

Tue, May 22, 2018 at 04:06:18AM CEST, sridhar.samudrala at intel.com wrote: >Use the registration/notification framework supported by the generic >failover infrastructure. > >Signed-off-by: Sridhar Samudrala <sridhar.samudrala at intel.com> In previous patchset versions, the common code did netdev_rx_handler_register() and netdev_upper_dev_link() etc (netvsc_vf_join()). Now,

Tue, May 22, 2018 at 04:06:18AM CEST, sridhar.samudrala at intel.com wrote: >Use the registration/notification framework supported by the generic >failover infrastructure. > >Signed-off-by: Sridhar Samudrala <sridhar.samudrala at intel.com> In previous patchset versions, the common code did netdev_rx_handler_register() and netdev_upper_dev_link() etc (netvsc_vf_join()). Now,

Tue, Mar 05, 2019 at 01:50:59AM CET, si-wei.liu at oracle.com wrote: >When a netdev appears through hot plug then gets enslaved by a failover >master that is already up and running, the slave will be opened >right away after getting enslaved. Today there's a race that userspace >(udev) may fail to rename the slave if the kernel (net_failover) >opens the slave earlier than when

On Mon, Mar 04, 2019 at 07:50:59PM -0500, Si-Wei Liu wrote: > When a netdev appears through hot plug then gets enslaved by a failover > master that is already up and running, the slave will be opened > right away after getting enslaved. Today there's a race that userspace > (udev) may fail to rename the slave if the kernel (net_failover) > opens the slave earlier than when the