similar to: [PATCH 0/5] Clean up TTM mmap offsets

Hi, On 11-03-19 17:51, Christian K?nig wrote: > Am 11.03.19 um 17:39 schrieb Hans de Goede: >> Hi, >> >> On 07-02-19 09:59, Thomas Zimmermann wrote: >>> Almost all TTM-based drivers use the same values for the mmap-able >>> range of BO addresses. Each driver therefore duplicates the >>> DRM_FILE_PAGE_OFFSET constant. OTOH, the mmap range's size

On Mon, Mar 11, 2019 at 05:51:39PM +0100, Christian K?nig wrote: > Am 11.03.19 um 17:39 schrieb Hans de Goede: > > Hi, > > > > On 07-02-19 09:59, Thomas Zimmermann wrote: > > > Almost all TTM-based drivers use the same values for the mmap-able > > > range of BO addresses. Each driver therefore duplicates the > > > DRM_FILE_PAGE_OFFSET constant.

Am 07.02.19 um 09:59 schrieb Thomas Zimmermann: > Almost all TTM-based drivers use the same values for the mmap-able > range of BO addresses. Each driver therefore duplicates the > DRM_FILE_PAGE_OFFSET constant. OTOH, the mmap range's size is not > configurable by drivers. > > This patch set replaces driver-specific configuration with a single > setup. All code is located

Hi, On 07-02-19 09:59, Thomas Zimmermann wrote: > Almost all TTM-based drivers use the same values for the mmap-able > range of BO addresses. Each driver therefore duplicates the > DRM_FILE_PAGE_OFFSET constant. OTOH, the mmap range's size is not > configurable by drivers. > > This patch set replaces driver-specific configuration with a single > setup. All code is

Hi, On 08-04-19 11:21, Thomas Zimmermann wrote: > Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de> Patch looks good to me (although perhaps it needs a commit msg): Reviewed-by: Hans de Goede <hdegoede at redhat.com> Regards, Hans > --- > drivers/gpu/drm/vboxvideo/Kconfig | 1 + > drivers/gpu/drm/vboxvideo/vbox_drv.h | 6 +- >

On Thu, 2019-02-07 at 09:59 +0100, Thomas Zimmermann wrote: > Most TTM drivers define the constant DRM_FILE_PAGE_OFFSET of the same > value. The only exception is vboxvideo, which is being converted to > the > new offset by this patch. Unifying the constants in a single place > simplifies the driver code. > > Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>

Rename the embedded struct vma_offset_manager, new name is _vma_manager. ttm_bo_device.vma_manager changed to a pointer. The ttm_bo_device_init() function gets an additional vma_manager argument which allows to initialize ttm with a different vma manager. When passing NULL the embedded _vma_manager is used. All callers are updated to pass NULL, so the behavior doesn't change. Signed-off-by:

Rename the embedded struct vma_offset_manager, new name is _vma_manager. ttm_bo_device.vma_manager changed to a pointer. The ttm_bo_device_init() function gets an additional vma_manager argument which allows to initialize ttm with a different vma manager. When passing NULL the embedded _vma_manager is used. All callers are updated to pass NULL, so the behavior doesn't change. Signed-off-by:

Rename the embedded struct vma_offset_manager, new name is _vma_manager. ttm_bo_device.vma_manager changed to a pointer. The ttm_bo_device_init() function gets an additional vma_manager argument which allows to initialize ttm with a different vma manager. When passing NULL the embedded _vma_manager is used. All callers are updated to pass NULL, so the behavior doesn't change. Signed-off-by:

Hi, On 08-04-19 11:21, Thomas Zimmermann wrote: > This patch replaces |struct vbox_bo| and its helpers with the generic > implementation of |struct drm_gem_ttm_object|. The only change in > semantics is that &ttm_bo_driver.verify_access() now does the actual > verification. > > Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de> Nice cleanup, thank you, patch

From: Jérôme Glisse <jglisse at redhat.com> Allow userspace to create a virtual address range hole for GEM object. Signed-off-by: Jérôme Glisse <jglisse at redhat.com> --- drivers/gpu/drm/nouveau/nouveau_ttm.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c b/drivers/gpu/drm/nouveau/nouveau_ttm.c index

Well first problem is I'm not sure if that is a good idea. Essentially we want to get rid of TTM in the long run. On the other hand this work might aid with that goal, so it might be worth a try. Second is that this might actually not work of hand. The problem is here: > + /* TODO: This test used to be performed by drivers, but can > + * this actually happen? If so, should we put

Hi, most of this patch set still needs reviews. If it's too large for merging or reviewing at once, I could move the driver changes into separate patch sets. The vbox driver's changes have been accepted by Hans already. So only keeping the core changes plus vbox would be an option. Best regards Thomas Am 08.05.19 um 10:26 schrieb Thomas Zimmermann: > Several simple framebuffer

This was only added for the drm's fbdev emulation support, so that it would try harder to show the Oops. Unfortunately this never really worked reliably, and in practice ended up pushing the real Oops off the screen due to plentyfull locking, sleep-while-atomic and other issues. So we removed all that support from the fbdev emulation a while back. Aside: We've also removed the kgdb

Am 16.10.2018 um 10:04 schrieb Thomas Zimmermann: > The functions ttm_bo_global_init() and ttm_bo_global_release() do not > receive an argument of type struct ttm_bo_global. Both take a struct > drm_global_reference that contains points to a struct ttm_bo_global_ref. > Renaming them reflects this. > > Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de> Reviewed and

Several simple framebuffer drivers copy most of the TTM code from each other. The implementation is always the same; except for the name of some data structures. As recently discussed, this patch set provides generic memory-management code for simple framebuffers with dedicated video memory. It further converts the respective drivers to the generic code. The shared code is basically the same

Several simple framebuffer drivers copy most of the TTM code from each other. The implementation is always the same; except for the name of some data structures. As recently discussed, this patch set provides generic memory-management code for simple framebuffers with dedicated video memory. It further converts the respective drivers to the generic code. The shared code is basically the same

Several simple framebuffer drivers copy most of the TTM code from each other. The implementation is always the same; except for the name of some data structures. As recently discussed, this patch set provides generic memory-management code for simple framebuffers with dedicated video memory. It further converts the respective drivers to the generic code. The shared code is basically the same

Several simple framebuffer drivers copy most of the TTM code from each other. The implementation is always the same; except for the name of some data structures. As recently discussed, this patch set provides generic memory-management code for simple framebuffers with dedicated video memory. It further converts the respective drivers to the generic code. The shared code is basically the same

Several simple framebuffer drivers copy most of the TTM code from each other. The implementation is always the same; except for the name of some data structures. As recently discussed, this patch set provides generic memory-management code for simple framebuffers with dedicated video memory. It further converts the respective drivers to the generic code. The shared code is basically the same