similar to: [PATCH net] virtio_net: Account for tx bytes and packets on sending xdp_frames

On 2019/02/01 5:15, Jesper Dangaard Brouer wrote: > On Thu, 31 Jan 2019 09:45:23 -0800 (PST) > David Miller <davem at davemloft.net> wrote: > >> From: "Michael S. Tsirkin" <mst at redhat.com> >> Date: Thu, 31 Jan 2019 10:25:17 -0500 >> >>> On Thu, Jan 31, 2019 at 08:40:30PM +0900, Toshiaki Makita wrote: >>>> Previously

David Ahern <dsahern at gmail.com> writes: > On 2/4/19 3:53 AM, Jesper Dangaard Brouer wrote: >> On Sat, 2 Feb 2019 14:27:26 -0700 >> David Ahern <dsahern at gmail.com> wrote: >> >>> On 1/31/19 1:15 PM, Jesper Dangaard Brouer wrote: >>>>> >>>>> David, Jesper, care to chime in where we ended up in that last thread

On Sat, 2 Feb 2019 14:27:26 -0700 David Ahern <dsahern at gmail.com> wrote: > On 1/31/19 1:15 PM, Jesper Dangaard Brouer wrote: > >> > >> David, Jesper, care to chime in where we ended up in that last thread > >> discussion this? > > > > IHMO packets RX and TX on a device need to be accounted, in standard > > counters, regardless of XDP.

Commit 5b8f3c8d30a6 ("virtio_net: Add XDP related stats") tries to count TX XDP stats in virtnet_receive(). This will cause several issues: - virtnet_xdp_sq() was called without checking whether or not XDP is set. This may cause out of bound access when there's no enough txq for XDP. - Stats were updated even if there's no XDP/XDP_TX. Fixing this by reusing

Commit 5b8f3c8d30a6 ("virtio_net: Add XDP related stats") tries to count TX XDP stats in virtnet_receive(). This will cause several issues: - virtnet_xdp_sq() was called without checking whether or not XDP is set. This may cause out of bound access when there's no enough txq for XDP. - Stats were updated even if there's no XDP/XDP_TX. Fixing this by reusing

On Tue, Jul 24, 2018 at 10:53 AM Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp> wrote: > > On 2018/07/24 2:31, Tonghao Zhang wrote: > > On Mon, Jul 23, 2018 at 10:20 PM Toshiaki Makita > > <toshiaki.makita1 at gmail.com> wrote: > >> > >> On 18/07/23 (?) 21:43, Tonghao Zhang wrote: > >>> On Mon, Jul 23, 2018 at 5:58 PM Toshiaki Makita

On Mon, Jul 23, 2018 at 11:36:03PM +0900, Toshiaki Makita wrote: > From: Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp> > > Add some ethtool stat items useful for performance analysis. > > Signed-off-by: Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp> Series: Acked-by: Michael S. Tsirkin <mst at redhat.com> Patch 1 seems appropriate for stable, even

On Mon, Jul 23, 2018 at 11:36:03PM +0900, Toshiaki Makita wrote: > From: Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp> > > Add some ethtool stat items useful for performance analysis. > > Signed-off-by: Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp> Series: Acked-by: Michael S. Tsirkin <mst at redhat.com> Patch 1 seems appropriate for stable, even

From: Toshiaki Makita <toshiaki.makita1 at gmail.com> Date: Mon, 23 Jul 2018 23:36:03 +0900 > From: Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp> > > Add some ethtool stat items useful for performance analysis. > > Signed-off-by: Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp> Michael and Jason, any objections to these new stats?

On 2017/12/26 1:47, Florian Fainelli wrote: > On December 25, 2017 3:45:36 AM PST, Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp> wrote: >> On 2017/12/25 3:16, Stephen Hemminger wrote: >>> On Wed, 20 Dec 2017 13:40:37 +0900 >>> Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp> wrote: >>> >>>> + >>>> +static const struct

From: "Michael S. Tsirkin" <mst at redhat.com> Date: Wed, 25 Jul 2018 12:40:12 +0300 > On Mon, Jul 23, 2018 at 11:36:03PM +0900, Toshiaki Makita wrote: >> From: Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp> >> >> Add some ethtool stat items useful for performance analysis. >> >> Signed-off-by: Toshiaki Makita <makita.toshiaki at

On 2017/12/25 3:16, Stephen Hemminger wrote: > On Wed, 20 Dec 2017 13:40:37 +0900 > Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp> wrote: > >> + >> +static const struct virtnet_gstats virtnet_gstrings_stats[] = { >> + { "rx_packets", VIRTNET_NETDEV_STAT(rx_packets) }, >> + { "tx_packets", VIRTNET_NETDEV_STAT(tx_packets) }, >>

On 2017/12/25 3:16, Stephen Hemminger wrote: > On Wed, 20 Dec 2017 13:40:37 +0900 > Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp> wrote: > >> + >> +static const struct virtnet_gstats virtnet_gstrings_stats[] = { >> + { "rx_packets", VIRTNET_NETDEV_STAT(rx_packets) }, >> + { "tx_packets", VIRTNET_NETDEV_STAT(tx_packets) }, >>

On December 25, 2017 3:45:36 AM PST, Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp> wrote: >On 2017/12/25 3:16, Stephen Hemminger wrote: >> On Wed, 20 Dec 2017 13:40:37 +0900 >> Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp> wrote: >> >>> + >>> +static const struct virtnet_gstats virtnet_gstrings_stats[] = { >>> + {

On 2018/07/31 18:43, Jason Wang wrote: > We don't maintain tx counters in rx stats any more. There's no need > for an extra container of rq stats. > > Cc: Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp> > Signed-off-by: Jason Wang <jasowang at redhat.com> > --- > drivers/net/virtio_net.c | 80 ++++++++++++++++++++++-------------------------- > 1

On 2018/07/31 18:43, Jason Wang wrote: > We don't maintain tx counters in rx stats any more. There's no need > for an extra container of rq stats. > > Cc: Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp> > Signed-off-by: Jason Wang <jasowang at redhat.com> > --- > drivers/net/virtio_net.c | 80 ++++++++++++++++++++++-------------------------- > 1

On Wed, 6 Feb 2019 00:06:33 +0000 Saeed Mahameed <saeedm at mellanox.com> wrote: > On Mon, 2019-02-04 at 19:13 -0800, David Ahern wrote: [...] > > > > mlx5 needs some work. As I recall it still has the bug/panic > > removing xdp programs - at least I don't recall seeing a patch for > > it. > > Only when xdp_redirect to mlx5, and removing the program

On 05/08/2018 4:15 PM, Tariq Toukan wrote: > > > On 25/07/2018 10:59 PM, David Miller wrote: >> From: "Michael S. Tsirkin" <mst at redhat.com> >> Date: Wed, 25 Jul 2018 12:40:12 +0300 >> >>> On Mon, Jul 23, 2018 at 11:36:03PM +0900, Toshiaki Makita wrote: >>>> From: Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp>

On 25/07/2018 10:59 PM, David Miller wrote: > From: "Michael S. Tsirkin" <mst at redhat.com> > Date: Wed, 25 Jul 2018 12:40:12 +0300 > >> On Mon, Jul 23, 2018 at 11:36:03PM +0900, Toshiaki Makita wrote: >>> From: Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp> >>> >>> Add some ethtool stat items useful for performance analysis.

On 25/07/2018 10:59 PM, David Miller wrote: > From: "Michael S. Tsirkin" <mst at redhat.com> > Date: Wed, 25 Jul 2018 12:40:12 +0300 > >> On Mon, Jul 23, 2018 at 11:36:03PM +0900, Toshiaki Makita wrote: >>> From: Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp> >>> >>> Add some ethtool stat items useful for performance analysis.