Displaying 20 results from an estimated 7000 matches similar to: "[PATCH net] virtio_net: Account for tx bytes and packets on sending xdp_frames"
2019 Feb 04
0
[PATCH net] virtio_net: Account for tx bytes and packets on sending xdp_frames
From: Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp>
Date: Thu, 31 Jan 2019 20:40:30 +0900
> Previously virtnet_xdp_xmit() did not account for device tx counters,
> which caused confusions.
> To be consistent with SKBs, account them on freeing xdp_frames.
>
> Reported-by: David Ahern <dsahern at gmail.com>
> Signed-off-by: Toshiaki Makita <makita.toshiaki at
2019 Apr 18
2
Stats for XDP actions (was: Re: [PATCH net] virtio_net: Account for tx bytes and packets on sending xdp_frames)
David Ahern <dsahern at gmail.com> writes:
> On 2/4/19 3:53 AM, Jesper Dangaard Brouer wrote:
>> On Sat, 2 Feb 2019 14:27:26 -0700
>> David Ahern <dsahern at gmail.com> wrote:
>>
>>> On 1/31/19 1:15 PM, Jesper Dangaard Brouer wrote:
>>>>>
>>>>> David, Jesper, care to chime in where we ended up in that last thread
2019 Feb 04
0
[PATCH net] virtio_net: Account for tx bytes and packets on sending xdp_frames
On Sat, 2 Feb 2019 14:27:26 -0700
David Ahern <dsahern at gmail.com> wrote:
> On 1/31/19 1:15 PM, Jesper Dangaard Brouer wrote:
> >>
> >> David, Jesper, care to chime in where we ended up in that last thread
> >> discussion this?
> >
> > IHMO packets RX and TX on a device need to be accounted, in standard
> > counters, regardless of XDP.
2019 Feb 07
0
Resource management for ndo_xdp_xmit (Was: [PATCH net] virtio_net: Account for tx bytes and packets on sending xdp_frames)
On Wed, 6 Feb 2019 00:06:33 +0000 Saeed Mahameed <saeedm at mellanox.com> wrote:
> On Mon, 2019-02-04 at 19:13 -0800, David Ahern wrote:
[...]
> >
> > mlx5 needs some work. As I recall it still has the bug/panic
> > removing xdp programs - at least I don't recall seeing a patch for
> > it.
>
> Only when xdp_redirect to mlx5, and removing the program
2019 Feb 06
1
[PATCH net] virtio_net: Account for tx bytes and packets on sending xdp_frames
On Wed, 6 Feb 2019 00:06:33 +0000
Saeed Mahameed <saeedm at mellanox.com> wrote:
> 3) Unrelated, In non XDP case, if skb allocation fails or driver fails
> to pass the skb up to the stack for somereason, should the driver
> increase rx packets ? IMHO the answer should be yes if we want to have
> similar behavior between XDP and non XDP cases.
I don't think "skb
2019 Feb 08
0
[PATCH net] virtio_net: Account for tx bytes and packets on sending xdp_frames
On Wed, 6 Feb 2019 00:06:33 +0000 Saeed Mahameed <saeedm at mellanox.com> wrote:
> 2) Driver should keep track of XDP decisions statistics, report them in
> ethtool and in the new API suggested by David. track even (XDP_PASS) ?
>
> Maybe instead of having all drivers track the statistics on their own,
> we should move the responsibility to upper layer.
>
> Idea: since
2018 Jul 31
8
[PATCH net-next 1/2] virtio-net: correctly update XDP_TX counters
Commit 5b8f3c8d30a6 ("virtio_net: Add XDP related stats") tries to
count TX XDP stats in virtnet_receive(). This will cause several
issues:
- virtnet_xdp_sq() was called without checking whether or not XDP is
set. This may cause out of bound access when there's no enough txq
for XDP.
- Stats were updated even if there's no XDP/XDP_TX.
Fixing this by reusing
2018 Jul 31
8
[PATCH net-next 1/2] virtio-net: correctly update XDP_TX counters
Commit 5b8f3c8d30a6 ("virtio_net: Add XDP related stats") tries to
count TX XDP stats in virtnet_receive(). This will cause several
issues:
- virtnet_xdp_sq() was called without checking whether or not XDP is
set. This may cause out of bound access when there's no enough txq
for XDP.
- Stats were updated even if there's no XDP/XDP_TX.
Fixing this by reusing
2019 Feb 09
0
Resource management for ndo_xdp_xmit (Was: [PATCH net] virtio_net: Account for tx bytes and packets on sending xdp_frames)
On Sat, 9 Feb 2019 00:18:31 +0000, Saeed Mahameed wrote:
> On Fri, 2019-02-08 at 15:17 -0800, Saeed Mahameed wrote:
> > On Thu, 2019-02-07 at 19:08 +0000, Saeed Mahameed wrote:
> > >
> > > So
> > > 1) on dev_map_update_elem() we will call
> > > dev->dev->ndo_bpf() to notify the device on the intention to
> > > start/stop
> >
2018 Aug 01
1
[PATCH net-next 1/2] virtio-net: correctly update XDP_TX counters
On 2018?07?31? 17:57, Toshiaki Makita wrote:
> On 2018/07/31 18:43, Jason Wang wrote:
>> Commit 5b8f3c8d30a6 ("virtio_net: Add XDP related stats") tries to
>> count TX XDP stats in virtnet_receive(). This will cause several
>> issues:
>>
>> - virtnet_xdp_sq() was called without checking whether or not XDP is
>> set. This may cause out of bound
2018 Jul 02
1
[PATCH vhost] vhost_net: Fix too many vring kick on busypoll
On 2018/07/02 16:52, Jason Wang wrote:
> On 2018?07?02? 15:11, Toshiaki Makita wrote:
>> On 2018/07/02 15:17, Jason Wang wrote:
>>> On 2018?07?02? 12:37, Toshiaki Makita wrote:
>>>> On 2018/07/02 11:54, Jason Wang wrote:
>>>>> On 2018?07?02? 10:45, Toshiaki Makita wrote:
>>>>>> Hi Jason,
>>>>>>
2018 Jul 02
0
[PATCH vhost] vhost_net: Fix too many vring kick on busypoll
On 2018?07?02? 15:11, Toshiaki Makita wrote:
> On 2018/07/02 15:17, Jason Wang wrote:
>> On 2018?07?02? 12:37, Toshiaki Makita wrote:
>>> On 2018/07/02 11:54, Jason Wang wrote:
>>>> On 2018?07?02? 10:45, Toshiaki Makita wrote:
>>>>> Hi Jason,
>>>>>
>>>>> On 2018/06/29 18:30, Jason Wang wrote:
>>>>>> On
2018 Jul 02
2
[PATCH vhost] vhost_net: Fix too many vring kick on busypoll
On 2018/07/02 15:17, Jason Wang wrote:
> On 2018?07?02? 12:37, Toshiaki Makita wrote:
>> On 2018/07/02 11:54, Jason Wang wrote:
>>> On 2018?07?02? 10:45, Toshiaki Makita wrote:
>>>> Hi Jason,
>>>>
>>>> On 2018/06/29 18:30, Jason Wang wrote:
>>>>> On 2018?06?29? 16:09, Toshiaki Makita wrote:
>>>> ...
2018 Jul 02
2
[PATCH vhost] vhost_net: Fix too many vring kick on busypoll
On 2018/07/02 15:17, Jason Wang wrote:
> On 2018?07?02? 12:37, Toshiaki Makita wrote:
>> On 2018/07/02 11:54, Jason Wang wrote:
>>> On 2018?07?02? 10:45, Toshiaki Makita wrote:
>>>> Hi Jason,
>>>>
>>>> On 2018/06/29 18:30, Jason Wang wrote:
>>>>> On 2018?06?29? 16:09, Toshiaki Makita wrote:
>>>> ...
2018 Jul 02
2
[PATCH vhost] vhost_net: Fix too many vring kick on busypoll
On 2018/07/02 11:54, Jason Wang wrote:
> On 2018?07?02? 10:45, Toshiaki Makita wrote:
>> Hi Jason,
>>
>> On 2018/06/29 18:30, Jason Wang wrote:
>>> On 2018?06?29? 16:09, Toshiaki Makita wrote:
>> ...
>>>> To fix this, poll the work instead of enabling notification when
>>>> busypoll is interrupted by something. IMHO signal_pending() and
2018 Jul 02
2
[PATCH vhost] vhost_net: Fix too many vring kick on busypoll
On 2018/07/02 11:54, Jason Wang wrote:
> On 2018?07?02? 10:45, Toshiaki Makita wrote:
>> Hi Jason,
>>
>> On 2018/06/29 18:30, Jason Wang wrote:
>>> On 2018?06?29? 16:09, Toshiaki Makita wrote:
>> ...
>>>> To fix this, poll the work instead of enabling notification when
>>>> busypoll is interrupted by something. IMHO signal_pending() and
2018 Jul 02
0
[PATCH vhost] vhost_net: Fix too many vring kick on busypoll
On 2018?07?02? 12:37, Toshiaki Makita wrote:
> On 2018/07/02 11:54, Jason Wang wrote:
>> On 2018?07?02? 10:45, Toshiaki Makita wrote:
>>> Hi Jason,
>>>
>>> On 2018/06/29 18:30, Jason Wang wrote:
>>>> On 2018?06?29? 16:09, Toshiaki Makita wrote:
>>> ...
>>>>> To fix this, poll the work instead of enabling notification when
2018 Jul 25
2
[PATCH net-next 0/6] virtio_net: Add ethtool stat items
On Mon, Jul 23, 2018 at 11:36:03PM +0900, Toshiaki Makita wrote:
> From: Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp>
>
> Add some ethtool stat items useful for performance analysis.
>
> Signed-off-by: Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp>
Series:
Acked-by: Michael S. Tsirkin <mst at redhat.com>
Patch 1 seems appropriate for stable, even
2018 Jul 25
2
[PATCH net-next 0/6] virtio_net: Add ethtool stat items
On Mon, Jul 23, 2018 at 11:36:03PM +0900, Toshiaki Makita wrote:
> From: Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp>
>
> Add some ethtool stat items useful for performance analysis.
>
> Signed-off-by: Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp>
Series:
Acked-by: Michael S. Tsirkin <mst at redhat.com>
Patch 1 seems appropriate for stable, even
2018 Jul 02
0
[PATCH vhost] vhost_net: Fix too many vring kick on busypoll
On 2018?07?02? 10:45, Toshiaki Makita wrote:
> Hi Jason,
>
> On 2018/06/29 18:30, Jason Wang wrote:
>> On 2018?06?29? 16:09, Toshiaki Makita wrote:
> ...
>>> To fix this, poll the work instead of enabling notification when
>>> busypoll is interrupted by something. IMHO signal_pending() and
>>> vhost_has_work() are kind of interruptions rather than