similar to: [RFC PATCH 1/1] s390/virtio: handle find on invalid queue gracefully

On Thu, 3 Jan 2019 14:00:10 +0100 Halil Pasic <pasic at linux.ibm.com> wrote: > On Wed, 2 Jan 2019 19:25:49 +0100 > Cornelia Huck <cohuck at redhat.com> wrote: > > > On Wed, 2 Jan 2019 18:50:20 +0100 > > Halil Pasic <pasic at linux.ibm.com> wrote: > > > > > A queue with a capacity of zero is clearly not a valid virtio queue. > >

From: Halil Pasic <pasic at linux.ibm.com> Before virtio-ccw could get away with not using DMA API for the pieces of memory it does ccw I/O with. With protected virtualization this has to change, since the hypervisor needs to read and sometimes also write these pieces of memory. The hypervisor is supposed to poke the classic notifiers, if these are used, out of band with regards to ccw

From: Halil Pasic <pasic at linux.ibm.com> Before virtio-ccw could get away with not using DMA API for the pieces of memory it does ccw I/O with. With protected virtualization this has to change, since the hypervisor needs to read and sometimes also write these pieces of memory. The hypervisor is supposed to poke the classic notifiers, if these are used, out of band with regards to ccw

Before virtio-ccw could get away with not using DMA API for the pieces of memory it does ccw I/O with. With protected virtualization this has to change, since the hypervisor needs to read and sometimes also write these pieces of memory. The hypervisor is supposed to poke the classic notifiers, if these are used, out of band with regards to ccw I/O. So these need to be allocated as DMA memory

On Fri, 5 Apr 2019 01:16:17 +0200 Halil Pasic <pasic at linux.ibm.com> wrote: > Before virtio-ccw could get away with not using DMA API for the pieces of > memory it does ccw I/O with. With protected virtualization this has to > change, since the hypervisor needs to read and sometimes also write these > pieces of memory. > > Let us make sure all ccw I/O is done through

The commit 2a2d1382fe9d ("virtio: Add improved queue allocation API") establishes a new way of allocating virtqueues (as a part of the effort that taught DMA to virtio rings). In the future we will want virtio-ccw to use the DMA API as well. Let us switch from the legacy method of allocating virtqueues to vring_create_virtqueue() as the first step into that direction. Signed-off-by:

Before virtio-ccw could get away with not using DMA API for the pieces of memory it does ccw I/O with. With protected virtualization this has to change, since the hypervisor needs to read and sometimes also write these pieces of memory. The hypervisor is supposed to poke the classic notifiers, if these are used, out of band with regards to ccw I/O. So these need to be allocated as DMA memory

Before virtio-ccw could get away with not using DMA API for the pieces of memory it does ccw I/O with. With protected virtualization this has to change, since the hypervisor needs to read and sometimes also write these pieces of memory. The hypervisor is supposed to poke the classic notifiers, if these are used, out of band with regards to ccw I/O. So these need to be allocated as DMA memory

On Mon, 3 Jun 2019 18:17:16 +0200 Cornelia Huck <cohuck at redhat.com> wrote: > On Wed, 29 May 2019 14:26:56 +0200 > Michael Mueller <mimu at linux.ibm.com> wrote: > > > From: Halil Pasic <pasic at linux.ibm.com> > > > > Before virtio-ccw could get away with not using DMA API for the pieces of > > memory it does ccw I/O with. With protected

On Wed, 29 May 2019 14:26:56 +0200 Michael Mueller <mimu at linux.ibm.com> wrote: > From: Halil Pasic <pasic at linux.ibm.com> > > Before virtio-ccw could get away with not using DMA API for the pieces of > memory it does ccw I/O with. With protected virtualization this has to > change, since the hypervisor needs to read and sometimes also write these > pieces of

On Wed, 29 May 2019 14:26:56 +0200 Michael Mueller <mimu at linux.ibm.com> wrote: > From: Halil Pasic <pasic at linux.ibm.com> > > Before virtio-ccw could get away with not using DMA API for the pieces of > memory it does ccw I/O with. With protected virtualization this has to > change, since the hypervisor needs to read and sometimes also write these > pieces of

On Tue, 4 Jun 2019 15:08:19 +0200 Halil Pasic <pasic at linux.ibm.com> wrote: > On Mon, 3 Jun 2019 18:17:16 +0200 > Cornelia Huck <cohuck at redhat.com> wrote: > > > On Wed, 29 May 2019 14:26:56 +0200 > > Michael Mueller <mimu at linux.ibm.com> wrote: > > (...) > > > > > @@ -176,6 +180,22 @@ static struct virtio_ccw_device

On 26/04/2019 20:32, Halil Pasic wrote: > Before virtio-ccw could get away with not using DMA API for the pieces of > memory it does ccw I/O with. With protected virtualization this has to > change, since the hypervisor needs to read and sometimes also write these > pieces of memory. > > The hypervisor is supposed to poke the classic notifiers, if these are > used, out of

On 26/04/2019 20:32, Halil Pasic wrote: > Before virtio-ccw could get away with not using DMA API for the pieces of > memory it does ccw I/O with. With protected virtualization this has to > change, since the hypervisor needs to read and sometimes also write these > pieces of memory. > > The hypervisor is supposed to poke the classic notifiers, if these are > used, out of

The CCW_CMD_SET_VQ command has a different format for revision 1+ devices, allowing to specify a more complex virtqueue layout. For now, we stay however with the old layout and simply use the new command format for virtio-1 devices. Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> --- drivers/s390/kvm/virtio_ccw.c | 54 ++++++++++++++++++++++++++++++++--------- 1 file changed,

On Fri, 5 Apr 2019 01:16:11 +0200 Halil Pasic <pasic at linux.ibm.com> wrote: > The commit 2a2d1382fe9d ("virtio: Add improved queue allocation API") > establishes a new way of allocating virtqueues (as a part of the effort > that taught DMA to virtio rings). > > In the future we will want virtio-ccw to use the DMA API as well. > > Let us switch from the

On Fri, 5 Apr 2019 01:16:12 +0200 Halil Pasic <pasic at linux.ibm.com> wrote: > Currently we have a problem if a virtio-ccw device has > VIRTIO_F_IOMMU_PLATFORM. Can you please describe what the actual problem is? > In future we do want to support DMA API with > virtio-ccw. > > Let us do the plumbing, so the feature VIRTIO_F_IOMMU_PLATFORM works > with virtio-ccw.

From: Halil Pasic <pasic at linux.ibm.com> Hypervisor needs to interact with the summary indicators, so these need to be DMA memory as well (at least for protected virtualization guests). Signed-off-by: Halil Pasic <pasic at linux.ibm.com> --- drivers/s390/virtio/virtio_ccw.c | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git

From: Halil Pasic <pasic at linux.ibm.com> Hypervisor needs to interact with the summary indicators, so these need to be DMA memory as well (at least for protected virtualization guests). Signed-off-by: Halil Pasic <pasic at linux.ibm.com> Signed-off-by: Michael Mueller <mimu at linux.ibm.com> --- drivers/s390/virtio/virtio_ccw.c | 26 +++++++++++++++++++------- 1 file

Currently virtio-ccw devices do not work if the device has VIRTIO_F_IOMMU_PLATFORM. In future we do want to support DMA API with virtio-ccw. Let us do the plumbing, so the feature VIRTIO_F_IOMMU_PLATFORM works with virtio-ccw. Let us also switch from legacy avail/used accessors to the DMA aware ones (even if it isn't strictly necessary), and remove the legacy accessors (we were the last