similar to: [RFC] Discuss about an new idea "Vsock over Virtio-net"

On 2018/11/15 12:19, Jason Wang wrote: > > On 2018/11/15 ??11:56, jiangyiwen wrote: >> Hi Stefan, Michael, Jason and everyone, >> >> Several days ago, I discussed with jason about "Vsock over Virtio-net". >> This idea has two advantages: >> First, it can use many great features of virtio-net, like batching, >> mergeable rx buffer and multiqueue,

On 2018/11/15 12:19, Jason Wang wrote: > > On 2018/11/15 ??11:56, jiangyiwen wrote: >> Hi Stefan, Michael, Jason and everyone, >> >> Several days ago, I discussed with jason about "Vsock over Virtio-net". >> This idea has two advantages: >> First, it can use many great features of virtio-net, like batching, >> mergeable rx buffer and multiqueue,

On 2018/11/15 16:19, Jason Wang wrote: > > On 2018/11/15 ??2:46, jiangyiwen wrote: >> On 2018/11/15 12:19, Jason Wang wrote: >>> On 2018/11/15 ??11:56, jiangyiwen wrote: >>>> Hi Stefan, Michael, Jason and everyone, >>>> >>>> Several days ago, I discussed with jason about "Vsock over Virtio-net". >>>> This idea has two

On 2018/11/15 16:19, Jason Wang wrote: > > On 2018/11/15 ??2:46, jiangyiwen wrote: >> On 2018/11/15 12:19, Jason Wang wrote: >>> On 2018/11/15 ??11:56, jiangyiwen wrote: >>>> Hi Stefan, Michael, Jason and everyone, >>>> >>>> Several days ago, I discussed with jason about "Vsock over Virtio-net". >>>> This idea has two

On 2018/11/15 17:21, Jason Wang wrote: > > On 2018/11/15 ??5:02, jiangyiwen wrote: >> On 2018/11/15 16:19, Jason Wang wrote: >>> On 2018/11/15 ??2:46, jiangyiwen wrote: >>>> On 2018/11/15 12:19, Jason Wang wrote: >>>>> On 2018/11/15 ??11:56, jiangyiwen wrote: >>>>>> Hi Stefan, Michael, Jason and everyone, >>>>>>

On 2018/11/15 ??2:46, jiangyiwen wrote: > On 2018/11/15 12:19, Jason Wang wrote: >> On 2018/11/15 ??11:56, jiangyiwen wrote: >>> Hi Stefan, Michael, Jason and everyone, >>> >>> Several days ago, I discussed with jason about "Vsock over Virtio-net". >>> This idea has two advantages: >>> First, it can use many great features of

On 2018/11/15 ??11:56, jiangyiwen wrote: > Hi Stefan, Michael, Jason and everyone, > > Several days ago, I discussed with jason about "Vsock over Virtio-net". > This idea has two advantages: > First, it can use many great features of virtio-net, like batching, > mergeable rx buffer and multiqueue, etc. > Second, it can reduce many duplicate codes and make it easy to

On 2018/11/15 ??5:02, jiangyiwen wrote: > On 2018/11/15 16:19, Jason Wang wrote: >> On 2018/11/15 ??2:46, jiangyiwen wrote: >>> On 2018/11/15 12:19, Jason Wang wrote: >>>> On 2018/11/15 ??11:56, jiangyiwen wrote: >>>>> Hi Stefan, Michael, Jason and everyone, >>>>> >>>>> Several days ago, I discussed with jason about

> On 15 Nov 2018, at 05:56, jiangyiwen <jiangyiwen at huawei.com> wrote: > > Hi Stefan, Michael, Jason and everyone, > > Several days ago, I discussed with jason about "Vsock over Virtio-net". > This idea has two advantages: > First, it can use many great features of virtio-net, like batching, > mergeable rx buffer and multiqueue, etc. > Second, it can

On 2018/11/15 15:04, Michael S. Tsirkin wrote: > On Thu, Nov 15, 2018 at 11:56:03AM +0800, jiangyiwen wrote: >> Hi Stefan, Michael, Jason and everyone, >> >> Several days ago, I discussed with jason about "Vsock over Virtio-net". >> This idea has two advantages: >> First, it can use many great features of virtio-net, like batching, >> mergeable rx

On 2018/11/15 15:04, Michael S. Tsirkin wrote: > On Thu, Nov 15, 2018 at 11:56:03AM +0800, jiangyiwen wrote: >> Hi Stefan, Michael, Jason and everyone, >> >> Several days ago, I discussed with jason about "Vsock over Virtio-net". >> This idea has two advantages: >> First, it can use many great features of virtio-net, like batching, >> mergeable rx

When vhost support VIRTIO_VSOCK_F_MRG_RXBUF feature, it will merge big packet into rx vq. Signed-off-by: Yiwen Jiang <jiangyiwen at huawei.com> --- drivers/vhost/vsock.c | 111 ++++++++++++++++++++++++++++++-------- include/linux/virtio_vsock.h | 1 + include/uapi/linux/virtio_vsock.h | 5 ++ 3 files changed, 94 insertions(+), 23 deletions(-) diff --git

When vhost support VIRTIO_VSOCK_F_MRG_RXBUF feature, it will merge big packet into rx vq. Signed-off-by: Yiwen Jiang <jiangyiwen at huawei.com> --- drivers/vhost/vsock.c | 111 ++++++++++++++++++++++++++++++-------- include/linux/virtio_vsock.h | 1 + include/uapi/linux/virtio_vsock.h | 5 ++ 3 files changed, 94 insertions(+), 23 deletions(-) diff --git

On 2018/12/12 23:37, Michael S. Tsirkin wrote: > On Wed, Dec 12, 2018 at 05:29:31PM +0800, jiangyiwen wrote: >> When vhost support VIRTIO_VSOCK_F_MRG_RXBUF feature, >> it will merge big packet into rx vq. >> >> Signed-off-by: Yiwen Jiang <jiangyiwen at huawei.com> > > I feel this approach jumps into making interface changes for > optimizations too

On 2018/12/12 23:37, Michael S. Tsirkin wrote: > On Wed, Dec 12, 2018 at 05:29:31PM +0800, jiangyiwen wrote: >> When vhost support VIRTIO_VSOCK_F_MRG_RXBUF feature, >> it will merge big packet into rx vq. >> >> Signed-off-by: Yiwen Jiang <jiangyiwen at huawei.com> > > I feel this approach jumps into making interface changes for > optimizations too

When vhost support VIRTIO_VSOCK_F_MRG_RXBUF feature, it will merge big packet into rx vq. Signed-off-by: Yiwen Jiang <jiangyiwen at huawei.com> --- drivers/vhost/vsock.c | 117 +++++++++++++++++++++++++++++++------- include/linux/virtio_vsock.h | 1 + include/uapi/linux/virtio_vsock.h | 5 ++ 3 files changed, 102 insertions(+), 21 deletions(-) diff --git

When vhost support VIRTIO_VSOCK_F_MRG_RXBUF feature, it will merge big packet into rx vq. Signed-off-by: Yiwen Jiang <jiangyiwen at huawei.com> --- drivers/vhost/vsock.c | 117 +++++++++++++++++++++++++++++++------- include/linux/virtio_vsock.h | 1 + include/uapi/linux/virtio_vsock.h | 5 ++ 3 files changed, 102 insertions(+), 21 deletions(-) diff --git

Guest receive mergeable rx buffer, it can merge scatter rx buffer into a big buffer and then copy to user space. Signed-off-by: Yiwen Jiang <jiangyiwen at huawei.com> --- include/linux/virtio_vsock.h | 9 ++++ net/vmw_vsock/virtio_transport.c | 75 +++++++++++++++++++++++++++++---- net/vmw_vsock/virtio_transport_common.c | 59 ++++++++++++++++++++++---- 3 files changed,

Guest receive mergeable rx buffer, it can merge scatter rx buffer into a big buffer and then copy to user space. Signed-off-by: Yiwen Jiang <jiangyiwen at huawei.com> --- include/linux/virtio_vsock.h | 9 ++++ net/vmw_vsock/virtio_transport.c | 75 +++++++++++++++++++++++++++++---- net/vmw_vsock/virtio_transport_common.c | 59 ++++++++++++++++++++++---- 3 files changed,

Guest receive mergeable rx buffer, it can merge scatter rx buffer into a big buffer and then copy to user space. In addition, it also use iovec to replace buf in struct virtio_vsock_pkt, keep tx and rx consistency. The only difference is now tx still uses a segment of continuous physical memory to implement. Signed-off-by: Yiwen Jiang <jiangyiwen at huawei.com> --- drivers/vhost/vsock.c