similar to: [PATCH 1/1] vhost: add per-vq worker thread

On 2018/11/3 ??12:07, Vitaly Mayatskikh wrote: > + > +static int vhost_vq_poll_start(struct vhost_virtqueue *vq) > +{ > + if (!vq->worker) { > + vq->worker = kthread_create(vhost_vq_worker, vq, "vhost-%d/%i", > + vq->dev->pid, vq->index); > + if (IS_ERR(vq->worker)) { > + int ret = PTR_ERR(vq->worker); > + > +

On Fri, Jan 20, 2023 at 04:12:20PM -0600, Seth Forshee (DigitalOcean) wrote: > We've fairly regularaly seen liveptches which cannot transition within kpatch's > timeout period due to busy vhost worker kthreads. In looking for a solution the > only answer I found was to call klp_update_patch_state() from a safe location. > I tried adding this call to vhost_worker(), and it

On Wed 2023-01-25 10:57:30, Seth Forshee wrote: > On Wed, Jan 25, 2023 at 12:34:26PM +0100, Petr Mladek wrote: > > On Tue 2023-01-24 11:21:39, Seth Forshee wrote: > > > On Tue, Jan 24, 2023 at 03:17:43PM +0100, Petr Mladek wrote: > > > > On Fri 2023-01-20 16:12:22, Seth Forshee (DigitalOcean) wrote: > > > > > Livepatch relies on stack checking of

On Thu, Jan 26, 2023 at 08:43:55PM -0800, Josh Poimboeuf wrote: > On Thu, Jan 26, 2023 at 03:12:35PM -0600, Seth Forshee (DigitalOcean) wrote: > > On Thu, Jan 26, 2023 at 06:03:16PM +0100, Petr Mladek wrote: > > > On Fri 2023-01-20 16:12:20, Seth Forshee (DigitalOcean) wrote: > > > > We've fairly regularaly seen liveptches which cannot transition within

On 5/5/23 1:22 PM, Linus Torvalds wrote: > On Fri, May 5, 2023 at 6:40?AM Nicolas Dichtel > <nicolas.dichtel at 6wind.com> wrote: >> >> Is this an intended behavior? >> This breaks some of our scripts. > > It doesn't just break your scripts (which counts as a regression), I > think it's really wrong. > > The worker threads should show up as

On Thu 2023-01-26 15:12:35, Seth Forshee (DigitalOcean) wrote: > On Thu, Jan 26, 2023 at 06:03:16PM +0100, Petr Mladek wrote: > > On Fri 2023-01-20 16:12:20, Seth Forshee (DigitalOcean) wrote: > > > We've fairly regularaly seen liveptches which cannot transition within kpatch's > > > timeout period due to busy vhost worker kthreads. > > > > I have

On Mon, Nov 05, 2018 at 11:15:04AM -0500, Vitaly Mayatskih wrote: > On Mon, Nov 5, 2018 at 10:48 AM Christian Borntraeger > <borntraeger at de.ibm.com> wrote: > > > For the record, we still do use virtio-blk a lot. As we see new things like discard/write zero > > support it seems that others do as well. > > Yes, trim/discard and writesame support is planned, at

On 2018/11/5 ??11:23, Vitaly Mayatskih wrote: > On Sun, Nov 4, 2018 at 10:00 PM Jason Wang <jasowang at redhat.com> wrote: > >>> # fio num-jobs >>> # A: bare metal over block >>> # B: bare metal over file >>> # C: virtio-blk over block >>> # D: virtio-blk over file >>> # E: vhost-blk bio over block >>> # F: vhost-blk kiocb

On 2018/11/5 ??11:23, Vitaly Mayatskih wrote: > On Sun, Nov 4, 2018 at 10:00 PM Jason Wang <jasowang at redhat.com> wrote: > >>> # fio num-jobs >>> # A: bare metal over block >>> # B: bare metal over file >>> # C: virtio-blk over block >>> # D: virtio-blk over file >>> # E: vhost-blk bio over block >>> # F: vhost-blk kiocb

On Fri 2023-01-20 16:12:20, Seth Forshee (DigitalOcean) wrote: > We've fairly regularaly seen liveptches which cannot transition within kpatch's > timeout period due to busy vhost worker kthreads. I have missed this detail. Miroslav told me that we have solved something similar some time ago, see https://lore.kernel.org/all/20220507174628.2086373-1-song at kernel.org/ Honestly,

On Fri, Nov 02, 2018 at 03:24:13PM -0400, Vitaly Mayatskih wrote: > On Fri, Nov 2, 2018 at 2:36 PM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > + if (type == VIRTIO_BLK_T_GET_ID) { > > > + char s[] = "vhost_blk"; > > > > Isn't this supposed to return the serial #? > > Yes, that gets a bit tricky here... Disk

On Fri, Nov 02, 2018 at 06:21:23PM +0000, Vitaly Mayatskikh wrote: > This driver accelerates host side of virtio-blk. > > Signed-off-by: Vitaly Mayatskikh <v.mayatskih at gmail.com> > --- > drivers/vhost/Kconfig | 13 ++ > drivers/vhost/Makefile | 3 + > drivers/vhost/blk.c | 510 +++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 526 insertions(+)

On 2018/11/3 ??2:21, Vitaly Mayatskikh wrote: > vhost_blk is a host-side kernel mode accelerator for virtio-blk. The > driver allows VM to reach a near bare-metal disk performance. See IOPS > numbers below (fio --rw=randread --bs=4k). > > This implementation uses kiocb interface. It is slightly slower than > going directly through bio, but is simpler and also works with disk >

On 2018/11/3 ??2:21, Vitaly Mayatskikh wrote: > vhost_blk is a host-side kernel mode accelerator for virtio-blk. The > driver allows VM to reach a near bare-metal disk performance. See IOPS > numbers below (fio --rw=randread --bs=4k). > > This implementation uses kiocb interface. It is slightly slower than > going directly through bio, but is simpler and also works with disk >

On Fri, May 5, 2023 at 6:40?AM Nicolas Dichtel <nicolas.dichtel at 6wind.com> wrote: > > Is this an intended behavior? > This breaks some of our scripts. It doesn't just break your scripts (which counts as a regression), I think it's really wrong. The worker threads should show up as threads of the thing that started them, not as processes. So they should show up in

This patch has the core work flush function take a worker. When we support multiple workers we can then flush each worker during device removal, stoppage, etc. Signed-off-by: Mike Christie <michael.christie at oracle.com> --- drivers/vhost/vhost.c | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c

Wei Liu <wei.liu at kernel.org> writes: > On Tue, Sep 15, 2020 at 12:32:29PM +0200, Vitaly Kuznetsov wrote: >> Wei Liu <wei.liu at kernel.org> writes: >> >> > When Linux is running as the root partition, the hypercall page will >> > have already been setup by Hyper-V. Copy the content over to the >> > allocated page. >> >> And we

On 2018/12/25 ??2:10, Michael S. Tsirkin wrote: > On Mon, Dec 24, 2018 at 03:53:16PM +0800, Jason Wang wrote: >> On 2018/12/14 ??8:36, Michael S. Tsirkin wrote: >>> On Fri, Dec 14, 2018 at 11:57:35AM +0800, Jason Wang wrote: >>>> On 2018/12/13 ??11:44, Michael S. Tsirkin wrote: >>>>> On Thu, Dec 13, 2018 at 06:10:22PM +0800, Jason Wang wrote:

Wei Liu <wei.liu at kernel.org> writes: > On Tue, Sep 15, 2020 at 01:02:08PM +0200, Vitaly Kuznetsov wrote: >> Wei Liu <wei.liu at kernel.org> writes: >> >> > On Tue, Sep 15, 2020 at 12:32:29PM +0200, Vitaly Kuznetsov wrote: >> >> Wei Liu <wei.liu at kernel.org> writes: >> >> >> >> > When Linux is running as the

On 2018/12/25 ??8:50, Michael S. Tsirkin wrote: > On Tue, Dec 25, 2018 at 06:05:25PM +0800, Jason Wang wrote: >> On 2018/12/25 ??2:10, Michael S. Tsirkin wrote: >>> On Mon, Dec 24, 2018 at 03:53:16PM +0800, Jason Wang wrote: >>>> On 2018/12/14 ??8:36, Michael S. Tsirkin wrote: >>>>> On Fri, Dec 14, 2018 at 11:57:35AM +0800, Jason Wang wrote: