similar to: [PATCH net-next V2] vhost: switch to use new message format

On Fri, Aug 03, 2018 at 03:04:51PM +0800, Jason Wang wrote: > We use to have message like: > > struct vhost_msg { > int type; > union { > struct vhost_iotlb_msg iotlb; > __u8 padding[64]; > }; > }; > > Unfortunately, there will be a hole of 32bit in 64bit machine because > of the alignment. This leads a different formats between 32bit API and > 64bit

We use to have message like: struct vhost_msg { int type; union { struct vhost_iotlb_msg iotlb; __u8 padding[64]; }; }; Unfortunately, there will be a hole of 32bit in 64bit machine because of the alignment. This leads a different formats between 32bit API and 64bit API. What's more it will break 32bit program running on 64bit machine. So fixing this by introducing a new message type

We use to have message like: struct vhost_msg { int type; union { struct vhost_iotlb_msg iotlb; __u8 padding[64]; }; }; Unfortunately, there will be a hole of 32bit in 64bit machine because of the alignment. This leads a different formats between 32bit API and 64bit API. What's more it will break 32bit program running on 64bit machine. So fixing this by introducing a new message type

On 2020/2/5 ??1:31, Michael S. Tsirkin wrote: > On Wed, Feb 05, 2020 at 11:12:21AM +0800, Jason Wang wrote: >> On 2020/2/5 ??10:05, Tiwei Bie wrote: >>> On Tue, Feb 04, 2020 at 02:46:16PM +0800, Jason Wang wrote: >>>> On 2020/2/4 ??2:01, Michael S. Tsirkin wrote: >>>>> On Tue, Feb 04, 2020 at 11:30:11AM +0800, Jason Wang wrote: >>>>>>

On 2020/2/5 ??1:31, Michael S. Tsirkin wrote: > On Wed, Feb 05, 2020 at 11:12:21AM +0800, Jason Wang wrote: >> On 2020/2/5 ??10:05, Tiwei Bie wrote: >>> On Tue, Feb 04, 2020 at 02:46:16PM +0800, Jason Wang wrote: >>>> On 2020/2/4 ??2:01, Michael S. Tsirkin wrote: >>>>> On Tue, Feb 04, 2020 at 11:30:11AM +0800, Jason Wang wrote: >>>>>>

On Wed, Feb 05, 2020 at 01:50:28PM +0800, Jason Wang wrote: > > On 2020/2/5 ??1:31, Michael S. Tsirkin wrote: > > On Wed, Feb 05, 2020 at 11:12:21AM +0800, Jason Wang wrote: > > > On 2020/2/5 ??10:05, Tiwei Bie wrote: > > > > On Tue, Feb 04, 2020 at 02:46:16PM +0800, Jason Wang wrote: > > > > > On 2020/2/4 ??2:01, Michael S. Tsirkin wrote: > >

On Wed, Feb 05, 2020 at 02:49:31PM +0800, Jason Wang wrote: > > On 2020/2/5 ??2:30, Michael S. Tsirkin wrote: > > On Wed, Feb 05, 2020 at 01:50:28PM +0800, Jason Wang wrote: > > > On 2020/2/5 ??1:31, Michael S. Tsirkin wrote: > > > > On Wed, Feb 05, 2020 at 11:12:21AM +0800, Jason Wang wrote: > > > > > On 2020/2/5 ??10:05, Tiwei Bie wrote: > >

On 2020/2/5 ??2:30, Michael S. Tsirkin wrote: > On Wed, Feb 05, 2020 at 01:50:28PM +0800, Jason Wang wrote: >> On 2020/2/5 ??1:31, Michael S. Tsirkin wrote: >>> On Wed, Feb 05, 2020 at 11:12:21AM +0800, Jason Wang wrote: >>>> On 2020/2/5 ??10:05, Tiwei Bie wrote: >>>>> On Tue, Feb 04, 2020 at 02:46:16PM +0800, Jason Wang wrote: >>>>>>

On 2020/2/5 ??2:30, Michael S. Tsirkin wrote: > On Wed, Feb 05, 2020 at 01:50:28PM +0800, Jason Wang wrote: >> On 2020/2/5 ??1:31, Michael S. Tsirkin wrote: >>> On Wed, Feb 05, 2020 at 11:12:21AM +0800, Jason Wang wrote: >>>> On 2020/2/5 ??10:05, Tiwei Bie wrote: >>>>> On Tue, Feb 04, 2020 at 02:46:16PM +0800, Jason Wang wrote: >>>>>>

On 2020/2/5 ??3:16, Michael S. Tsirkin wrote: > On Wed, Feb 05, 2020 at 02:49:31PM +0800, Jason Wang wrote: >> On 2020/2/5 ??2:30, Michael S. Tsirkin wrote: >>> On Wed, Feb 05, 2020 at 01:50:28PM +0800, Jason Wang wrote: >>>> On 2020/2/5 ??1:31, Michael S. Tsirkin wrote: >>>>> On Wed, Feb 05, 2020 at 11:12:21AM +0800, Jason Wang wrote:

This patch tries to implement an device IOTLB for vhost. This could be used with for co-operation with userspace(qemu) implementation of DMA remapping. The idea is simple, cache the translation in a software device IOTLB (which was implemented as interval tree) in vhost and use vhost_net file descriptor for reporting IOTLB miss and IOTLB update/invalidation. When vhost meets an IOTLB miss, the

This patches extend the vhost IOTLB API to accept batch updating hints form userspace. When userspace wants update the device IOTLB in a batch, it may do: 1) Write vhost_iotlb_msg with VHOST_IOTLB_BATCH_BEGIN flag 2) Perform a batch of IOTLB updating via VHOST_IOTLB_UPDATE/INVALIDATE 3) Write vhost_iotlb_msg with VHOST_IOTLB_BATCH_END flag Vhost-vdpa may decide to batch the IOMMU/IOTLB updating

On 2020/6/28 ??5:58, Michael S. Tsirkin wrote: > On Thu, Jun 18, 2020 at 01:56:25PM +0800, Jason Wang wrote: >> This patches extend the vhost IOTLB API to accept batch updating hints >> form userspace. When userspace wants update the device IOTLB in a >> batch, it may do: >> >> 1) Write vhost_iotlb_msg with VHOST_IOTLB_BATCH_BEGIN flag >> 2) Perform a batch

On Mon, Jun 29, 2020 at 05:26:03PM +0800, Jason Wang wrote: > > On 2020/6/28 ??5:58, Michael S. Tsirkin wrote: > > On Thu, Jun 18, 2020 at 01:56:25PM +0800, Jason Wang wrote: > > > This patches extend the vhost IOTLB API to accept batch updating hints > > > form userspace. When userspace wants update the device IOTLB in a > > > batch, it may do: > >

On Thu, Jun 18, 2020 at 01:56:25PM +0800, Jason Wang wrote: > This patches extend the vhost IOTLB API to accept batch updating hints > form userspace. When userspace wants update the device IOTLB in a > batch, it may do: > > 1) Write vhost_iotlb_msg with VHOST_IOTLB_BATCH_BEGIN flag > 2) Perform a batch of IOTLB updating via VHOST_IOTLB_UPDATE/INVALIDATE > 3) Write

On Thu, Jun 18, 2020 at 01:56:25PM +0800, Jason Wang wrote: > This patches extend the vhost IOTLB API to accept batch updating hints > form userspace. When userspace wants update the device IOTLB in a > batch, it may do: > > 1) Write vhost_iotlb_msg with VHOST_IOTLB_BATCH_BEGIN flag > 2) Perform a batch of IOTLB updating via VHOST_IOTLB_UPDATE/INVALIDATE > 3) Write

On 2020/2/5 ??10:05, Tiwei Bie wrote: > On Tue, Feb 04, 2020 at 02:46:16PM +0800, Jason Wang wrote: >> On 2020/2/4 ??2:01, Michael S. Tsirkin wrote: >>> On Tue, Feb 04, 2020 at 11:30:11AM +0800, Jason Wang wrote: >>>> 5) generate diffs of memory table and using IOMMU API to setup the dma >>>> mapping in this method >>> Frankly I think that's a

On 2020/2/5 ??10:05, Tiwei Bie wrote: > On Tue, Feb 04, 2020 at 02:46:16PM +0800, Jason Wang wrote: >> On 2020/2/4 ??2:01, Michael S. Tsirkin wrote: >>> On Tue, Feb 04, 2020 at 11:30:11AM +0800, Jason Wang wrote: >>>> 5) generate diffs of memory table and using IOMMU API to setup the dma >>>> mapping in this method >>> Frankly I think that's a

This reverts commit 93c0d549c4c5a7382ad70de6b86610b7aae57406. Unfortunately the padding will break 32 bit userspace. Ouch. Need to add some compat code, revert for now. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/uapi/linux/vhost.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h index 5a8ad06..c51f8e5 100644

On Thu, Dec 13, 2018 at 05:53:50PM +0300, Pavel Tikhomirov wrote: > We've failed to copy and process vhost_iotlb_msg so let userspace at > least know about it. For instance before these patch the code below runs > without any error: > > int main() > { > struct vhost_msg msg; > struct iovec iov; > int fd; > > fd = open("/dev/vhost-net",