similar to: [PATCH v6 3/3] x86: paravirt: make native_save_fl extern inline

- Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) Please consider the environment and don't print this e-mail unless you really need to

From: Geert Uytterhoeven > Sent: 24 February 2020 12:54 > To: Krzysztof Kozlowski <krzk at kernel.org> ... > > > > diff --git a/drivers/net/wireless/ath/ath5k/ahb.c b/drivers/net/wireless/ath/ath5k/ahb.c > > > > index 2c9cec8b53d9..8bd01df369fb 100644 > > > > --- a/drivers/net/wireless/ath/ath5k/ahb.c > > > > +++

From: Michael Matz > Sent: 07 October 2018 16:53 ... > I think the examples I saw from Boris were all indirect inlines: > > static inline void foo() { asm("large-looking-but-small-asm"); } > static void bar1() { ... foo() ... } > static void bar2() { ... foo() ... } > void goo (void) { bar1(); } // bar1 should have been inlined > > So, while the

Hi Geert, Le 08/01/2020 ? 09:43, Geert Uytterhoeven a ?crit?: > Hi Christophe, > > On Wed, Jan 8, 2020 at 9:35 AM Christophe Leroy <christophe.leroy at c-s.fr> wrote: >> Le 08/01/2020 ? 09:18, Krzysztof Kozlowski a ?crit : >>> On Wed, 8 Jan 2020 at 09:13, Geert Uytterhoeven <geert at linux-m68k.org> wrote: >>>> On Wed, Jan 8, 2020 at 9:07 AM Geert

* Nick Desaulniers <ndesaulniers at google.com> wrote: > On Thu, Jun 21, 2018 at 7:24 PM Ingo Molnar <mingo at kernel.org> wrote: > > * Nick Desaulniers <ndesaulniers at google.com> wrote: > > > > > native_save_fl() is marked static inline, but by using it as > > > a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined. > >

* Nick Desaulniers <ndesaulniers at google.com> wrote: > native_save_fl() is marked static inline, but by using it as > a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined. > --- a/arch/x86/include/asm/irqflags.h > +++ b/arch/x86/include/asm/irqflags.h > @@ -13,7 +13,7 @@ > * Interrupt control: > */ > > -static inline unsigned long

On 13/06/18 23:05, Nick Desaulniers wrote: > paravirt depends on a custom calling convention (callee saved), but > expects this from a static inline function that it then forces to be > outlined. This is problematic because different compilers or flags can > then add a stack guard that violates the calling conventions. > > Uses extern inline with the out-of-line definition in

4.17-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nick Desaulniers <ndesaulniers at google.com> commit d0a8d9378d16eb3c69bd8e6d23779fbdbee3a8c7 upstream. native_save_fl() is marked static inline, but by using it as a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined. paravirt's use of native_save_fl() also

4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nick Desaulniers <ndesaulniers at google.com> commit d0a8d9378d16eb3c69bd8e6d23779fbdbee3a8c7 upstream. native_save_fl() is marked static inline, but by using it as a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined. paravirt's use of native_save_fl() also requires

4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nick Desaulniers <ndesaulniers at google.com> commit d0a8d9378d16eb3c69bd8e6d23779fbdbee3a8c7 upstream. native_save_fl() is marked static inline, but by using it as a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined. paravirt's use of native_save_fl() also

On 06/05/18 10:05, Nick Desaulniers wrote: > + > +/* > + * void native_restore_fl(unsigned long flags) > + * %rdi: flags > + */ > +ENTRY(native_restore_fl) > + push %_ASM_DI > + popf > + ret > +ENDPROC(native_restore_fl) > +EXPORT_SYMBOL(native_restore_fl) > To work on i386, this would have to be %_ASM_AX in that case. Something like this added to

On 06/05/18 10:52, Nick Desaulniers wrote: > > Does the kernel have a different calling convention for 32b x86? How > does that work? regparm=3? Does that need to be added to the > declaration? > Yes, -mregparm=3. No, doesn't need to be added to the declaration. >> Something like this added to <asm/asm.h> might be useful; then you can >> simply: >>

On Tue, Jun 5, 2018 at 7:05 PM, Nick Desaulniers <ndesaulniers at google.com> wrote: > > The semantics of extern inline has changed since gnu89. This means that > folks using GCC versions >= 5.1 may see symbol redefinition errors at > link time for subdirs that override KBUILD_CFLAGS (making the C standard > used implicit) regardless of this patch. This has been cleaned up

On 26/06/18 18:22, Nick Desaulniers wrote: > On Tue, Jun 26, 2018 at 3:13 AM Ingo Molnar <mingo at kernel.org> wrote: >> Ok! >> >> Acked-by: Ingo Molnar <mingo at kernel.org> >> >> What's the planned upstreaming route for these patches/fixes? > > While the fix is mainly for paravirt, 2/3 of the patches exclusively > touch arch/x86, so I

On 06/05/18 10:05, Nick Desaulniers wrote: > + > +/* > + * void native_restore_fl(unsigned long flags) > + * %rdi: flags > + */ > +ENTRY(native_restore_fl) > + push %_ASM_DI > + popf > + ret > +ENDPROC(native_restore_fl) > +EXPORT_SYMBOL(native_restore_fl) > To work on i386, this would have to be %_ASM_AX in that case. Something like this added to

4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nick Desaulniers <ndesaulniers at google.com> commit d0a8d9378d16eb3c69bd8e6d23779fbdbee3a8c7 upstream. native_save_fl() is marked static inline, but by using it as a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined. paravirt's use of native_save_fl() also requires

This is a note to let you know that I've just added the patch titled x86/paravirt: Make native_save_fl() extern inline to the 4.17-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: x86-paravirt-make-native_save_fl-extern-inline.patch and it can be found in the queue-4.17 subdirectory.

This is a note to let you know that I've just added the patch titled x86/paravirt: Make native_save_fl() extern inline to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: x86-paravirt-make-native_save_fl-extern-inline.patch and it can be found in the queue-4.14 subdirectory.

This is a note to let you know that I've just added the patch titled x86/paravirt: Make native_save_fl() extern inline to the 4.9-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: x86-paravirt-make-native_save_fl-extern-inline.patch and it can be found in the queue-4.9 subdirectory.

This is a note to let you know that I've just added the patch titled x86/paravirt: Make native_save_fl() extern inline to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: x86-paravirt-make-native_save_fl-extern-inline.patch and it can be found in the queue-4.4 subdirectory.