similar to: [PATCH v5 0/3] extern inline native_save_fl for paravirt

On June 1, 2018 9:55:49 AM PDT, Nick Desaulniers <ndesaulniers at google.com> wrote: >The top level Makefile explicitly sets the C standard used in the >kernel >to gnu89. By overriding KBUILD_CFLAGS, the C standard used for this >subdir is now implicit based on compiler and compiler version. GCC >changes this implicit default from gnu89 to gnu11 in v5.1. > >This implies

This is a note to let you know that I've just added the patch titled x86/paravirt: Make native_save_fl() extern inline to the 4.17-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: x86-paravirt-make-native_save_fl-extern-inline.patch and it can be found in the queue-4.17 subdirectory.

This is a note to let you know that I've just added the patch titled x86/paravirt: Make native_save_fl() extern inline to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: x86-paravirt-make-native_save_fl-extern-inline.patch and it can be found in the queue-4.14 subdirectory.

This is a note to let you know that I've just added the patch titled x86/paravirt: Make native_save_fl() extern inline to the 4.9-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: x86-paravirt-make-native_save_fl-extern-inline.patch and it can be found in the queue-4.9 subdirectory.

On Tue, Jun 5, 2018 at 7:05 PM, Nick Desaulniers <ndesaulniers at google.com> wrote: > > The semantics of extern inline has changed since gnu89. This means that > folks using GCC versions >= 5.1 may see symbol redefinition errors at > link time for subdirs that override KBUILD_CFLAGS (making the C standard > used implicit) regardless of this patch. This has been cleaned up

4.17-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nick Desaulniers <ndesaulniers at google.com> commit d0a8d9378d16eb3c69bd8e6d23779fbdbee3a8c7 upstream. native_save_fl() is marked static inline, but by using it as a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined. paravirt's use of native_save_fl() also

4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nick Desaulniers <ndesaulniers at google.com> commit d0a8d9378d16eb3c69bd8e6d23779fbdbee3a8c7 upstream. native_save_fl() is marked static inline, but by using it as a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined. paravirt's use of native_save_fl() also requires

4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nick Desaulniers <ndesaulniers at google.com> commit d0a8d9378d16eb3c69bd8e6d23779fbdbee3a8c7 upstream. native_save_fl() is marked static inline, but by using it as a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined. paravirt's use of native_save_fl() also

This is a note to let you know that I've just added the patch titled x86/paravirt: Make native_save_fl() extern inline to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: x86-paravirt-make-native_save_fl-extern-inline.patch and it can be found in the queue-4.4 subdirectory.

4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nick Desaulniers <ndesaulniers at google.com> commit d0a8d9378d16eb3c69bd8e6d23779fbdbee3a8c7 upstream. native_save_fl() is marked static inline, but by using it as a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined. paravirt's use of native_save_fl() also requires

This is a note to let you know that I've just added the patch titled compiler-gcc.h: Add __attribute__((gnu_inline)) to all inline declarations to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: compiler-gcc.h-add-__attribute__-gnu_inline-to-all-inline-declarations.patch

This is a note to let you know that I've just added the patch titled compiler-gcc.h: Add __attribute__((gnu_inline)) to all inline declarations to the 4.17-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: compiler-gcc.h-add-__attribute__-gnu_inline-to-all-inline-declarations.patch

This is a note to let you know that I've just added the patch titled compiler-gcc.h: Add __attribute__((gnu_inline)) to all inline declarations to the 4.9-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: compiler-gcc.h-add-__attribute__-gnu_inline-to-all-inline-declarations.patch and

This is a note to let you know that I've just added the patch titled compiler-gcc.h: Add __attribute__((gnu_inline)) to all inline declarations to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: compiler-gcc.h-add-__attribute__-gnu_inline-to-all-inline-declarations.patch and

On 06/05/18 10:05, Nick Desaulniers wrote: > + > +/* > + * void native_restore_fl(unsigned long flags) > + * %rdi: flags > + */ > +ENTRY(native_restore_fl) > + push %_ASM_DI > + popf > + ret > +ENDPROC(native_restore_fl) > +EXPORT_SYMBOL(native_restore_fl) > To work on i386, this would have to be %_ASM_AX in that case. Something like this added to

On 06/05/18 10:05, Nick Desaulniers wrote: > + > +/* > + * void native_restore_fl(unsigned long flags) > + * %rdi: flags > + */ > +ENTRY(native_restore_fl) > + push %_ASM_DI > + popf > + ret > +ENDPROC(native_restore_fl) > +EXPORT_SYMBOL(native_restore_fl) > To work on i386, this would have to be %_ASM_AX in that case. Something like this added to

<caoj.fnst at cn.fujitsu.com>,Greg KH <gregkh at linuxfoundation.org>,jarkko.sakkinen at linux.intel.com,jgross at suse.com,Josh Poimboeuf <jpoimboe at redhat.com>,Matthias Kaehlcke <mka at chromium.org>,thomas.lendacky at amd.com,Thiebaud Weksteen <tweek at google.com>,mjg59 at google.com,joe at perches.com From: hpa at zytor.com Message-ID:

* Nick Desaulniers <ndesaulniers at google.com> wrote: > On Thu, Jun 21, 2018 at 7:24 PM Ingo Molnar <mingo at kernel.org> wrote: > > * Nick Desaulniers <ndesaulniers at google.com> wrote: > > > > > native_save_fl() is marked static inline, but by using it as > > > a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined. > >

On Thu, 2018-06-07 at 11:32 -0700, Nick Desaulniers wrote: > Functions marked extern inline do not emit an externally visible > function when the gnu89 C standard is used. Some KBUILD Makefiles > overwrite KBUILD_CFLAGS. This is an issue for GCC 5.1+ users as without > an explicit C standard specified, the default is gnu11. Since c99, the > semantics of extern inline have changed

* Nick Desaulniers <ndesaulniers at google.com> wrote: > native_save_fl() is marked static inline, but by using it as > a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined. > --- a/arch/x86/include/asm/irqflags.h > +++ b/arch/x86/include/asm/irqflags.h > @@ -13,7 +13,7 @@ > * Interrupt control: > */ > > -static inline unsigned long