similar to: [PATCH 2/3] x86/build: use -std=gnu89 for proper extern inline semantics

On 13/06/18 23:05, Nick Desaulniers wrote: > paravirt depends on a custom calling convention (callee saved), but > expects this from a static inline function that it then forces to be > outlined. This is problematic because different compilers or flags can > then add a stack guard that violates the calling conventions. > > Uses extern inline with the out-of-line definition in

On Tue, Jun 5, 2018 at 7:05 PM, Nick Desaulniers <ndesaulniers at google.com> wrote: > > The semantics of extern inline has changed since gnu89. This means that > folks using GCC versions >= 5.1 may see symbol redefinition errors at > link time for subdirs that override KBUILD_CFLAGS (making the C standard > used implicit) regardless of this patch. This has been cleaned up

<caoj.fnst at cn.fujitsu.com>,Greg KH <gregkh at linuxfoundation.org>,jarkko.sakkinen at linux.intel.com,jgross at suse.com,Josh Poimboeuf <jpoimboe at redhat.com>,Matthias Kaehlcke <mka at chromium.org>,thomas.lendacky at amd.com,Thiebaud Weksteen <tweek at google.com>,mjg59 at google.com,joe at perches.com From: hpa at zytor.com Message-ID:

This is a note to let you know that I've just added the patch titled compiler-gcc.h: Add __attribute__((gnu_inline)) to all inline declarations to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: compiler-gcc.h-add-__attribute__-gnu_inline-to-all-inline-declarations.patch and

This is a note to let you know that I've just added the patch titled compiler-gcc.h: Add __attribute__((gnu_inline)) to all inline declarations to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: compiler-gcc.h-add-__attribute__-gnu_inline-to-all-inline-declarations.patch

This is a note to let you know that I've just added the patch titled compiler-gcc.h: Add __attribute__((gnu_inline)) to all inline declarations to the 4.17-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: compiler-gcc.h-add-__attribute__-gnu_inline-to-all-inline-declarations.patch

This is a note to let you know that I've just added the patch titled compiler-gcc.h: Add __attribute__((gnu_inline)) to all inline declarations to the 4.9-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: compiler-gcc.h-add-__attribute__-gnu_inline-to-all-inline-declarations.patch and

4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nick Desaulniers <ndesaulniers at google.com> commit d03db2bc26f0e4a6849ad649a09c9c73fccdc656 upstream. Functions marked extern inline do not emit an externally visible function when the gnu89 C standard is used. Some KBUILD Makefiles overwrite KBUILD_CFLAGS. This is an issue for GCC 5.1+

4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nick Desaulniers <ndesaulniers at google.com> commit d03db2bc26f0e4a6849ad649a09c9c73fccdc656 upstream. Functions marked extern inline do not emit an externally visible function when the gnu89 C standard is used. Some KBUILD Makefiles overwrite KBUILD_CFLAGS. This is an issue for GCC 5.1+

4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nick Desaulniers <ndesaulniers at google.com> commit d03db2bc26f0e4a6849ad649a09c9c73fccdc656 upstream. Functions marked extern inline do not emit an externally visible function when the gnu89 C standard is used. Some KBUILD Makefiles overwrite KBUILD_CFLAGS. This is an issue for GCC

4.17-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nick Desaulniers <ndesaulniers at google.com> commit d03db2bc26f0e4a6849ad649a09c9c73fccdc656 upstream. Functions marked extern inline do not emit an externally visible function when the gnu89 C standard is used. Some KBUILD Makefiles overwrite KBUILD_CFLAGS. This is an issue for GCC

This is a note to let you know that I've just added the patch titled x86/paravirt: Make native_save_fl() extern inline to the 4.17-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: x86-paravirt-make-native_save_fl-extern-inline.patch and it can be found in the queue-4.17 subdirectory.

This is a note to let you know that I've just added the patch titled x86/paravirt: Make native_save_fl() extern inline to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: x86-paravirt-make-native_save_fl-extern-inline.patch and it can be found in the queue-4.14 subdirectory.

This is a note to let you know that I've just added the patch titled x86/paravirt: Make native_save_fl() extern inline to the 4.9-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: x86-paravirt-make-native_save_fl-extern-inline.patch and it can be found in the queue-4.9 subdirectory.

This is a note to let you know that I've just added the patch titled x86/paravirt: Make native_save_fl() extern inline to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: x86-paravirt-make-native_save_fl-extern-inline.patch and it can be found in the queue-4.4 subdirectory.

4.17-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nick Desaulniers <ndesaulniers at google.com> commit d0a8d9378d16eb3c69bd8e6d23779fbdbee3a8c7 upstream. native_save_fl() is marked static inline, but by using it as a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined. paravirt's use of native_save_fl() also

4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nick Desaulniers <ndesaulniers at google.com> commit d0a8d9378d16eb3c69bd8e6d23779fbdbee3a8c7 upstream. native_save_fl() is marked static inline, but by using it as a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined. paravirt's use of native_save_fl() also requires

4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nick Desaulniers <ndesaulniers at google.com> commit d0a8d9378d16eb3c69bd8e6d23779fbdbee3a8c7 upstream. native_save_fl() is marked static inline, but by using it as a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined. paravirt's use of native_save_fl() also

4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nick Desaulniers <ndesaulniers at google.com> commit d0a8d9378d16eb3c69bd8e6d23779fbdbee3a8c7 upstream. native_save_fl() is marked static inline, but by using it as a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined. paravirt's use of native_save_fl() also requires

On Thu, Jun 7, 2018 at 10:49 PM, Nick Desaulniers <ndesaulniers at google.com> wrote: > Functions marked extern inline do not emit an externally visible > function when the gnu89 C standard is used. Some KBUILD Makefiles > overwrite KBUILD_CFLAGS. This is an issue for GCC 5.1+ users as without > an explicit C standard specified, the default is gnu11. Since c99, the > semantics