similar to: [PATCH net-next] virtio_net: fix error return code in virtnet_probe()

On 2018?05?31? 10:05, Wei Yongjun wrote: > Fix to return a negative error code from the failover create fail error > handling case instead of 0, as done elsewhere in this function. > > Fixes: ba5e4426e80e ("virtio_net: Extend virtio to use VF datapath when available") > Signed-off-by: Wei Yongjun <weiyongjun1 at huawei.com> > --- > drivers/net/virtio_net.c |

From: Wei Yongjun <weiyongjun1 at huawei.com> Date: Thu, 31 May 2018 02:05:07 +0000 > Fix to return a negative error code from the failover create fail error > handling case instead of 0, as done elsewhere in this function. > > Fixes: ba5e4426e80e ("virtio_net: Extend virtio to use VF datapath when available") > Signed-off-by: Wei Yongjun <weiyongjun1 at

This patch enables virtio_net to switch over to a VF datapath when a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct attached VF without the need to setup a bond/team between a VF and virtio net device in the guest. The hypervisor needs to unplug the VF device from the guest on the source host and reset the MAC filter of the VF to initiate failover

This patch enables virtio_net to switch over to a VF datapath when STANDBY feature is enabled and a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct attached VF without the need to setup a bond/team between a VF and virtio net device in the guest. It uses the API that is exported by the net_failover driver to create and and destroy a master failover

From: Wei Yongjun <weiyongjun1 at huawei.com> The error return code PTR_ERR(mc) is always 0 since mc is equal to 0 in this error handling case. Signed-off-by: Wei Yongjun <weiyongjun1 at huawei.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm20b.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm20b.c

Reviewed-by: Karol Herbst <kherbst at redhat.com> On Thu, Sep 5, 2019 at 9:14 AM Wei Yongjun <weiyongjun1 at huawei.com> wrote: > > When using single_open() for opening, single_release() should be > used, otherwise there is a memory leak. > > This is detected by Coccinelle semantic patch. > > Fixes: 6e9fc177399f ("drm/nouveau/debugfs: add copy of sysfs pstate

When using single_open() for opening, single_release() should be used, otherwise there is a memory leak. This is detected by Coccinelle semantic patch. Fixes: 6e9fc177399f ("drm/nouveau/debugfs: add copy of sysfs pstate interface ported to debugfs") Signed-off-by: Wei Yongjun <weiyongjun1 at huawei.com> --- drivers/gpu/drm/nouveau/nouveau_debugfs.c | 1 + 1 file changed, 1

This patch enables virtio_net to switch over to a VF datapath when a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct attached VF without the need to setup a bond/team between a VF and virtio net device in the guest. The hypervisor needs to enable only one datapath at any time so that packets don't get looped back to the VM over the other

On Wed, 27 Feb 2019 23:47:33 -0500, Michael S. Tsirkin wrote: > On Wed, Feb 27, 2019 at 05:52:18PM -0800, Jakub Kicinski wrote: > > > > Can the users who care about the naming put net_failover into > > > > "user space will do the bond enslavement" mode, and do the bond > > > > creation/management themselves from user space (in systemd/ > >

On Wed, Feb 27, 2019 at 05:52:18PM -0800, Jakub Kicinski wrote: > On Wed, 27 Feb 2019 20:26:02 -0500, Michael S. Tsirkin wrote: > > On Wed, Feb 27, 2019 at 04:52:05PM -0800, Jakub Kicinski wrote: > > > On Wed, 27 Feb 2019 19:41:32 -0500, Michael S. Tsirkin wrote: > > > > > As this scheme adds much complexity to the kernel naming convention > > > >

Reviewed-by: Lyude Paul <lyude at redhat.com> Thanks! On Tue, 2020-07-21 at 15:17 +0000, Wei Yongjun wrote: > When using single_open() for opening, single_release() should be > used instead of seq_release(), otherwise there is a memory leak. > > Fixes: 12885ecbfe62 ("drm/nouveau/kms/nvd9-: Add CRC support") > Reported-by: Hulk Robot <hulkci at huawei.com>

On Thu, Feb 28, 2019 at 10:13:56AM -0800, Jakub Kicinski wrote: > On Wed, 27 Feb 2019 23:47:33 -0500, Michael S. Tsirkin wrote: > > On Wed, Feb 27, 2019 at 05:52:18PM -0800, Jakub Kicinski wrote: > > > > > Can the users who care about the naming put net_failover into > > > > > "user space will do the bond enslavement" mode, and do the bond > >

On Tue, Jan 24, 2023 at 12:04:24PM +0100, Laurent Vivier wrote: > On 1/24/23 11:15, Michael S. Tsirkin wrote: > > On Mon, Jan 23, 2023 at 01:00:22PM +0100, Laurent Vivier wrote: > > > In virtnet_probe(), if the device doesn't provide a MAC address the > > > driver assigns a random one. > > > As we modify the MAC address we need to notify the device to allow

Hi, On 05/07/2018 03:10 PM, Sridhar Samudrala wrote: > > Signed-off-by: Sridhar Samudrala <sridhar.samudrala at intel.com> > --- > MAINTAINERS | 7 + > include/linux/netdevice.h | 16 + > include/net/net_failover.h | 52 +++ > net/Kconfig | 10 + > net/core/Makefile | 1 + > net/core/net_failover.c | 1044

When the MAC address is not provided by the vdpa device virtio_net driver assigns a random one without notifying the device. The consequence, in the case of mlx5_vdpa, is the internal routing tables of the device are not updated and this can block the communication between two namespaces. To fix this problem, use virtnet_send_command(VIRTIO_NET_CTRL_MAC) to set the address from virtnet_probe()

The main motivation for this patch is to enable cloud service providers to provide an accelerated datapath to virtio-net enabled VMs in a transparent manner with no/minimal guest userspace changes. This also enables hypervisor controlled live migration to be supported with VMs that have direct attached SR-IOV VF devices. Patch 1 introduces a new feature bit VIRTIO_NET_F_STANDBY that can be used

On Wed, 27 Feb 2019 20:26:02 -0500, Michael S. Tsirkin wrote: > On Wed, Feb 27, 2019 at 04:52:05PM -0800, Jakub Kicinski wrote: > > On Wed, 27 Feb 2019 19:41:32 -0500, Michael S. Tsirkin wrote: > > > > As this scheme adds much complexity to the kernel naming convention > > > > (currently it's just ethX names) that no userspace can understand. > >

This is another update based on feedback from MST and Stephen on the last patchset. Hopefully this series can be integrated and any further enhancements can be made on top of this patchset. v8: - Made the failover managment routines more robust by updating the feature bits/other fields in the failover netdev when slave netdevs are registered/unregistered. (mst) - added support for handling

This provides a generic interface for paravirtual drivers to listen for netdev register/unregister/link change events from pci ethernet devices with the same MAC and takeover their datapath. The notifier and event handling code is based on the existing netvsc implementation. It exposes 2 sets of interfaces to the paravirtual drivers. 1. For paravirtual drivers like virtio_net that use 3 netdev

On Mon, Feb 25, 2019 at 04:58:07PM -0800, si-wei liu wrote: > > > On 2/22/2019 7:14 AM, Michael S. Tsirkin wrote: > > On Thu, Feb 21, 2019 at 11:55:11PM -0800, si-wei liu wrote: > > > > > > On 2/21/2019 11:00 PM, Samudrala, Sridhar wrote: > > > > > > > > On 2/21/2019 7:33 PM, si-wei liu wrote: > > > > > > > >