similar to: [PATCH] virtio_balloon: fix increment of vb->num_pfns in fill_balloon()

Delivered as per https://access.redhat.com/articles/3311301. This is good news. Backporting those updates across three gcc versions does not look like the easiest exercise to me. $ rpm -qp --changelog gcc-4.4.7-18.el6_9.2.x86_64.rpm |head -n 6 * Wed Jan 31 2018 Jeff Law <law at redhat.com> 4.4.7-18.2 - Fix indirect_jump/tablejump patters for retpolines (#1535656) * Tue Jan 23 2018 Jeff Law

The following changes since commit c1d0c3f623ada808904dec676da0126f5b800630: fw_cfg: fix the command line module name (2017-11-14 23:57:40 +0200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to d9e427f6ab8142d6868eb719e6a7851aafea56b6: virtio_balloon: fix increment of vb->num_pfns in

The following changes since commit c1d0c3f623ada808904dec676da0126f5b800630: fw_cfg: fix the command line module name (2017-11-14 23:57:40 +0200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to d9e427f6ab8142d6868eb719e6a7851aafea56b6: virtio_balloon: fix increment of vb->num_pfns in

tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost head: 823b45b4f154384941d57e124ed726847e293b36 commit: 823b45b4f154384941d57e124ed726847e293b36 [1/1] virtio_balloon: fix deadlock on OOM config: i386-randconfig-x001-201745 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: git checkout 823b45b4f154384941d57e124ed726847e293b36

tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost head: 823b45b4f154384941d57e124ed726847e293b36 commit: 823b45b4f154384941d57e124ed726847e293b36 [1/1] virtio_balloon: fix deadlock on OOM config: i386-randconfig-x001-201745 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: git checkout 823b45b4f154384941d57e124ed726847e293b36

tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost head: 74d5d28b9903cd48c22c04f887354a3d49621c13 commit: 47349198d7a879febab785a00c39c2de379f35c2 [1/9] virtio_balloon: fix deadlock on OOM config: sh-allyesconfig (attached as .config) compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget

tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost head: 74d5d28b9903cd48c22c04f887354a3d49621c13 commit: 47349198d7a879febab785a00c39c2de379f35c2 [1/9] virtio_balloon: fix deadlock on OOM config: sh-allyesconfig (attached as .config) compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget

From: Wei Yongjun <yongjun_wei at trendmicro.com.cn> Add the missing unlock before return from function fill_balloon() in the error handling case. Introduced by 9864a8(virtio_balloon: introduce migration primitives to balloon pages) dpatch engine is used to auto generate this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun <yongjun_wei at trendmicro.com.cn> ---

From: Wei Yongjun <yongjun_wei at trendmicro.com.cn> Add the missing unlock before return from function fill_balloon() in the error handling case. Introduced by 9864a8(virtio_balloon: introduce migration primitives to balloon pages) dpatch engine is used to auto generate this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun <yongjun_wei at trendmicro.com.cn> ---

fill_balloon doing memory allocations under balloon_lock can cause a deadlock when leak_balloon is called from virtballoon_oom_notify and tries to take same lock. To fix, split page allocation and enqueue and do allocations outside the lock. Here's a detailed analysis of the deadlock by Tetsuo Handa: In leak_balloon(), mutex_lock(&vb->balloon_lock) is called in order to serialize

fill_balloon doing memory allocations under balloon_lock can cause a deadlock when leak_balloon is called from virtballoon_oom_notify and tries to take same lock. To fix, split page allocation and enqueue and do allocations outside the lock. Here's a detailed analysis of the deadlock by Tetsuo Handa: In leak_balloon(), mutex_lock(&vb->balloon_lock) is called in order to serialize

From: "Michael S. Tsirkin" <mst.redhat.com> fill_balloon doing memory allocations under balloon_lock can cause a deadlock when leak_balloon is called from virtballoon_oom_notify and tries to take same lock. To fix, split page allocation and enqueue and do allocations outside the lock. Here's a detailed analysis of the deadlock by Tetsuo Handa: In leak_balloon(),

We recently added locking in fill_balloon() but there was one error path which was missed. Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> --- Only needed in linux-next. diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index f70151b..1c50e98 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -153,9 +153,10 @@

We recently added locking in fill_balloon() but there was one error path which was missed. Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> --- Only needed in linux-next. diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index f70151b..1c50e98 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -153,9 +153,10 @@

"Michael S. Tsirkin" <mst at redhat.com> writes: > fill_balloon doing memory allocations under balloon_lock > can cause a deadlock when leak_balloon is called from > virtballoon_oom_notify and tries to take same lock. > > To fix, split page allocation and enqueue and do allocations outside the lock. > > Here's a detailed analysis of the deadlock by Tetsuo

On Fri, Dec 01, 2017 at 11:31:08PM +1100, Michael Ellerman wrote: > "Michael S. Tsirkin" <mst at redhat.com> writes: > > > fill_balloon doing memory allocations under balloon_lock > > can cause a deadlock when leak_balloon is called from > > virtballoon_oom_notify and tries to take same lock. > > > > To fix, split page allocation and enqueue and

On Fri, Dec 01, 2017 at 11:31:08PM +1100, Michael Ellerman wrote: > "Michael S. Tsirkin" <mst at redhat.com> writes: > > > fill_balloon doing memory allocations under balloon_lock > > can cause a deadlock when leak_balloon is called from > > virtballoon_oom_notify and tries to take same lock. > > > > To fix, split page allocation and enqueue and

Michael S. Tsirkin wrote: > This is a replacement for > [PATCH] virtio: avoid possible OOM lockup at virtballoon_oom_notify() > but unlike that patch it actually deflates on oom even in presence of > lock contention. But Wei Wang is proposing VIRTIO_BALLOON_F_SG which will try to allocate memory, isn't he? > > drivers/virtio/virtio_balloon.c | 30

On Fri, Oct 13, 2017 at 11:06:23PM +0900, Tetsuo Handa wrote: > Michael S. Tsirkin wrote: > > This is a replacement for > > [PATCH] virtio: avoid possible OOM lockup at virtballoon_oom_notify() > > but unlike that patch it actually deflates on oom even in presence of > > lock contention. > > But Wei Wang is proposing VIRTIO_BALLOON_F_SG which will try to allocate

On Fri, Oct 13, 2017 at 11:06:23PM +0900, Tetsuo Handa wrote: > Michael S. Tsirkin wrote: > > This is a replacement for > > [PATCH] virtio: avoid possible OOM lockup at virtballoon_oom_notify() > > but unlike that patch it actually deflates on oom even in presence of > > lock contention. > > But Wei Wang is proposing VIRTIO_BALLOON_F_SG which will try to allocate