similar to: [PATCH] virtio/ringtest: fix up need_event math

last kicked event index must be updated unconditionally: even if we don't need to kick, we do not want to re-check the same entry for events. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- Changes from v1: fix inverted logic in call_used tools/virtio/ringtest/ring.c | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git

last kicked event index must be updated unconditionally: even if we don't need to kick, we do not want to re-check the same entry for events. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- Changes from v1: fix inverted logic in call_used tools/virtio/ringtest/ring.c | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git

This adds micro-benchmarks useful for tuning virtio ring layouts. Three layouts are currently implemented: - virtio 0.9 compatible one - an experimental extension bypassing the ring index, polling ring itself instead - an experimental extension bypassing avail and used ring completely Typical use: sh run-on-all.sh perf stat -r 10 --log-fd 1 -- ./ring It doesn't depend on the kernel

This adds micro-benchmarks useful for tuning virtio ring layouts. Three layouts are currently implemented: - virtio 0.9 compatible one - an experimental extension bypassing the ring index, polling ring itself instead - an experimental extension bypassing avail and used ring completely Typical use: sh run-on-all.sh perf stat -r 10 --log-fd 1 -- ./ring It doesn't depend on the kernel

last kicked event index must be updated unconditionally: even if we don't need to kick, we do not want to re-check the same entry for events. Reported-by: Cornelia Huck <cohuck at redhat.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- tools/virtio/ringtest/virtio_ring_0_9.c | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git

last kicked event index must be updated unconditionally: even if we don't need to kick, we do not want to re-check the same entry for events. Reported-by: Cornelia Huck <cohuck at redhat.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- tools/virtio/ringtest/virtio_ring_0_9.c | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git

On Thu, 26 Oct 2017 04:48:01 +0300 "Michael S. Tsirkin" <mst at redhat.com> wrote: > last kicked event index must be updated unconditionally: > even if we don't need to kick, we do not want to re-check > the same entry for events. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > --- > tools/virtio/ringtest/ring.c | 24

Having typical usage example in the README file is more convinient than in the git history... Signed-off-by: Mike Rapoport <rppt at linux.vnet.ibm.com> --- tools/virtio/ringtest/README | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/virtio/ringtest/README b/tools/virtio/ringtest/README index 34e94c4..d83707a 100644 --- a/tools/virtio/ringtest/README +++

Having typical usage example in the README file is more convinient than in the git history... Signed-off-by: Mike Rapoport <rppt at linux.vnet.ibm.com> --- tools/virtio/ringtest/README | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/virtio/ringtest/README b/tools/virtio/ringtest/README index 34e94c4..d83707a 100644 --- a/tools/virtio/ringtest/README +++

/dev/cpu is only available on x86 with certain modules (e.g. msr) enabled. Using lscpu to get processors count is more portable. Signed-off-by: Mike Rapoport <rppt at linux.vnet.ibm.com> --- v2: use lspcu instead of /proc/cpuinfo as per Cornelia's suggestion tools/virtio/ringtest/run-on-all.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

/dev/cpu is only available on x86 with certain modules (e.g. msr) enabled. Using lscpu to get processors count is more portable. Signed-off-by: Mike Rapoport <rppt at linux.vnet.ibm.com> --- v2: use lspcu instead of /proc/cpuinfo as per Cornelia's suggestion tools/virtio/ringtest/run-on-all.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

/dev/cpu is only available on x86 with certain modules (e.g. msr) enabled. Using lscpu to get processors count is more portable. Signed-off-by: Mike Rapoport <rppt at linux.vnet.ibm.com> --- v3: simplify by using lscpu -p=cpu v2: use lspcu instead of /proc/cpuinfo as per Cornelia's suggestion tools/virtio/ringtest/run-on-all.sh | 4 ++-- 1 file changed, 2 insertions(+), 2

/dev/cpu is only available on x86 with certain modules (e.g. msr) enabled. Using lscpu to get processors count is more portable. Signed-off-by: Mike Rapoport <rppt at linux.vnet.ibm.com> --- v3: simplify by using lscpu -p=cpu v2: use lspcu instead of /proc/cpuinfo as per Cornelia's suggestion tools/virtio/ringtest/run-on-all.sh | 4 ++-- 1 file changed, 2 insertions(+), 2

/dev/cpu is only available on x86 with certain modules (e.g. msr) enabled. Using /proc/cpuinfo to get processors count is more portable. Signed-off-by: Mike Rapoport <rppt at linux.vnet.ibm.com> --- tools/virtio/ringtest/run-on-all.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virtio/ringtest/run-on-all.sh b/tools/virtio/ringtest/run-on-all.sh index

There is an || vs && typo so the assert can never be triggered. Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> diff --git a/tools/virtio/ringtest/main.c b/tools/virtio/ringtest/main.c index 022ae95a06bd..453ca3c21193 100644 --- a/tools/virtio/ringtest/main.c +++ b/tools/virtio/ringtest/main.c @@ -87,7 +87,7 @@ void set_affinity(const char *arg) cpu = strtol(arg,

There is an || vs && typo so the assert can never be triggered. Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> diff --git a/tools/virtio/ringtest/main.c b/tools/virtio/ringtest/main.c index 022ae95a06bd..453ca3c21193 100644 --- a/tools/virtio/ringtest/main.c +++ b/tools/virtio/ringtest/main.c @@ -87,7 +87,7 @@ void set_affinity(const char *arg) cpu = strtol(arg,

The following changes since commit d8a5b80568a9cb66810e75b182018e9edb68e8ff: Linux 4.15 (2018-01-28 13:20:33 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to d25cc43c6775bff6b8e3dad97c747954b805e421: vhost: don't hold onto file pointer for VHOST_SET_LOG_FD (2018-02-01 16:26:47

skips ring accesses but drops out of order support At high level this follows alf design https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/lib/alf_queue.c but on most (single-threaded) benchmarks this seems to be slower than the layout without index use. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- tools/virtio/ringtest/virtio_ring_0_9.c | 49

skips ring accesses but drops out of order support At high level this follows alf design https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/lib/alf_queue.c but on most (single-threaded) benchmarks this seems to be slower than the layout without index use. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- tools/virtio/ringtest/virtio_ring_0_9.c | 49

The following changes since commit 92e963f50fc74041b5e9e744c330dca48e04f08d: Linux 4.5-rc1 (2016-01-24 13:06:47 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to 481eaec37e91e2b33f17275901172f50ce2c71e8: tools/virtio: add ringtest utilities (2016-01-26 10:18:30 +0200)