similar to: [PATCH net-next] virtio_net: implement VIRTIO_CONFIG_S_NEEDS_RESET

On Fri, Oct 13, 2017 at 11:51:40AM -0400, Willem de Bruijn wrote: > From: Willem de Bruijn <willemb at google.com> > > Implement the reset communication request defined in the VIRTIO 1.0 > specification and introduces in Linux in commit c00bbcf862896 ("virtio: > add VIRTIO_CONFIG_S_NEEDS_RESET device status bit"). > > Use the virtnet_reset function introduced

>> +static int virtnet_reset(struct virtnet_info *vi) >> +{ >> + struct virtio_device *dev = vi->vdev; >> + int ret; >> + >> + virtio_config_disable(dev); >> + dev->failed = dev->config->get_status(dev) & VIRTIO_CONFIG_S_FAILED; >> + virtnet_freeze_down(dev, true); >> + remove_vq_common(vi); >> +

>> +static int virtnet_reset(struct virtnet_info *vi) >> +{ >> + struct virtio_device *dev = vi->vdev; >> + int ret; >> + >> + virtio_config_disable(dev); >> + dev->failed = dev->config->get_status(dev) & VIRTIO_CONFIG_S_FAILED; >> + virtnet_freeze_down(dev, true); >> + remove_vq_common(vi); >> +

On Mon, Oct 16, 2017 at 12:38 PM, Michael S. Tsirkin <mst at redhat.com> wrote: > On Mon, Oct 16, 2017 at 12:04:57PM -0400, Willem de Bruijn wrote: >> On Mon, Oct 16, 2017 at 11:31 AM, Michael S. Tsirkin <mst at redhat.com> wrote: >> > On Mon, Oct 16, 2017 at 11:03:18AM -0400, Willem de Bruijn wrote: >> >> >> +static int virtnet_reset(struct

On Mon, Oct 16, 2017 at 12:38 PM, Michael S. Tsirkin <mst at redhat.com> wrote: > On Mon, Oct 16, 2017 at 12:04:57PM -0400, Willem de Bruijn wrote: >> On Mon, Oct 16, 2017 at 11:31 AM, Michael S. Tsirkin <mst at redhat.com> wrote: >> > On Mon, Oct 16, 2017 at 11:03:18AM -0400, Willem de Bruijn wrote: >> >> >> +static int virtnet_reset(struct

On Tue, Oct 17, 2017 at 11:05:07AM +0800, Jason Wang wrote: > > > On 2017?10?17? 06:34, Willem de Bruijn wrote: > > On Mon, Oct 16, 2017 at 12:38 PM, Michael S. Tsirkin <mst at redhat.com> wrote: > > > On Mon, Oct 16, 2017 at 12:04:57PM -0400, Willem de Bruijn wrote: > > > > On Mon, Oct 16, 2017 at 11:31 AM, Michael S. Tsirkin <mst at redhat.com>

On Mon, Oct 16, 2017 at 11:31 AM, Michael S. Tsirkin <mst at redhat.com> wrote: > On Mon, Oct 16, 2017 at 11:03:18AM -0400, Willem de Bruijn wrote: >> >> +static int virtnet_reset(struct virtnet_info *vi) >> >> +{ >> >> + struct virtio_device *dev = vi->vdev; >> >> + int ret; >> >> + >> >> +

On Mon, Oct 16, 2017 at 11:31 AM, Michael S. Tsirkin <mst at redhat.com> wrote: > On Mon, Oct 16, 2017 at 11:03:18AM -0400, Willem de Bruijn wrote: >> >> +static int virtnet_reset(struct virtnet_info *vi) >> >> +{ >> >> + struct virtio_device *dev = vi->vdev; >> >> + int ret; >> >> + >> >> +

On Tue, Aug 29, 2017 at 4:20 PM, Michael S. Tsirkin <mst at redhat.com> wrote: > On Tue, Aug 29, 2017 at 04:07:58PM -0400, Willem de Bruijn wrote: >> From: Willem de Bruijn <willemb at google.com> >> >> Implement the reset communication request defined in the VIRTIO 1.0 >> specification and introduces in Linux in commit c00bbcf862896 ("virtio: >>

On Tue, Aug 29, 2017 at 4:20 PM, Michael S. Tsirkin <mst at redhat.com> wrote: > On Tue, Aug 29, 2017 at 04:07:58PM -0400, Willem de Bruijn wrote: >> From: Willem de Bruijn <willemb at google.com> >> >> Implement the reset communication request defined in the VIRTIO 1.0 >> specification and introduces in Linux in commit c00bbcf862896 ("virtio: >>

Driver virtio_net is not handling error events for TX provided by dev_watchdog. This event is reached when transmission queue is having problems to transmit packets. This could happen for any reason. To enable it, driver should have .ndo_tx_timeout implemented. This commit brings back virtnet_reset method to recover TX queues from a error state. That function is called by schedule_work method and

Driver virtio_net is not handling error events for TX provided by dev_watchdog. This event is reached when transmission queue is having problems to transmit packets. This could happen for any reason. To enable it, driver should have .ndo_tx_timeout implemented. This commit brings back virtnet_reset method to recover TX queues from a error state. That function is called by schedule_work method and

On 2017?10?17? 06:34, Willem de Bruijn wrote: > On Mon, Oct 16, 2017 at 12:38 PM, Michael S. Tsirkin <mst at redhat.com> wrote: >> On Mon, Oct 16, 2017 at 12:04:57PM -0400, Willem de Bruijn wrote: >>> On Mon, Oct 16, 2017 at 11:31 AM, Michael S. Tsirkin <mst at redhat.com> wrote: >>>> On Mon, Oct 16, 2017 at 11:03:18AM -0400, Willem de Bruijn wrote:

On Mon, Oct 16, 2017 at 11:44 PM, Michael S. Tsirkin <mst at redhat.com> wrote: > On Tue, Oct 17, 2017 at 11:05:07AM +0800, Jason Wang wrote: >> >> >> On 2017?10?17? 06:34, Willem de Bruijn wrote: >> > On Mon, Oct 16, 2017 at 12:38 PM, Michael S. Tsirkin <mst at redhat.com> wrote: >> > > On Mon, Oct 16, 2017 at 12:04:57PM -0400, Willem de

On Mon, Oct 16, 2017 at 11:03:18AM -0400, Willem de Bruijn wrote: > >> +static int virtnet_reset(struct virtnet_info *vi) > >> +{ > >> + struct virtio_device *dev = vi->vdev; > >> + int ret; > >> + > >> + virtio_config_disable(dev); > >> + dev->failed = dev->config->get_status(dev) &

On Mon, Oct 16, 2017 at 12:04:57PM -0400, Willem de Bruijn wrote: > On Mon, Oct 16, 2017 at 11:31 AM, Michael S. Tsirkin <mst at redhat.com> wrote: > > On Mon, Oct 16, 2017 at 11:03:18AM -0400, Willem de Bruijn wrote: > >> >> +static int virtnet_reset(struct virtnet_info *vi) > >> >> +{ > >> >> + struct virtio_device *dev =

On Mon, Jul 17, 2017 at 08:44:00PM +0800, Jason Wang wrote: > We used to reset during XDP set, the main reason is we need allocate > extra headroom for header adjustment but there's no way to know the > headroom of exist receive buffer. This works buy maybe complex and may > cause the network down for a while which is bad for user > experience. So this patch tries to avoid this

On Mon, Jul 17, 2017 at 08:44:00PM +0800, Jason Wang wrote: > We used to reset during XDP set, the main reason is we need allocate > extra headroom for header adjustment but there's no way to know the > headroom of exist receive buffer. This works buy maybe complex and may > cause the network down for a while which is bad for user > experience. So this patch tries to avoid this

We already do a reset once in remove_vq_common - there appears to be no point in doing another one when we add/remove XDP. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/net/virtio_net.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index de42e9a..ed8f548 100644 --- a/drivers/net/virtio_net.c +++

We already do a reset once in remove_vq_common - there appears to be no point in doing another one when we add/remove XDP. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/net/virtio_net.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index de42e9a..ed8f548 100644 --- a/drivers/net/virtio_net.c +++