similar to: [PATCH v2] virtio_net: lower limit on buffer size

commit d85b758f72b0 "virtio_net: fix support for small rings" was supposed to increase the buffer size for small rings but had an unintentional side effect of decreasing it for large rings. This seems to break some setups - it's not yet clear why, but increasing buffer size back to what it was before helps. Fixes: d85b758f72b0 "virtio_net: fix support for small rings"

commit d85b758f72b0 "virtio_net: fix support for small rings" was supposed to increase the buffer size for small rings but had an unintentional side effect of decreasing it for large rings. This seems to break some setups - it's not yet clear why, but increasing buffer size back to what it was before helps. Fixes: d85b758f72b0 "virtio_net: fix support for small rings"

On Tue, May 30, 2017 at 07:26:37PM +0300, Michael S. Tsirkin wrote: > On Fri, May 26, 2017 at 03:31:33PM -0400, bfields at fieldses.org wrote: > > Looks like the culprit is very likely d85b758f72b0 "virtio_net: fix > > support for small rings". > > > > After that patch, my NFS server VM stops responding to packets after a > > few minutes of testing.

On Tue, May 30, 2017 at 07:26:37PM +0300, Michael S. Tsirkin wrote: > On Fri, May 26, 2017 at 03:31:33PM -0400, bfields at fieldses.org wrote: > > Looks like the culprit is very likely d85b758f72b0 "virtio_net: fix > > support for small rings". > > > > After that patch, my NFS server VM stops responding to packets after a > > few minutes of testing.

On Tue, May 30, 2017 at 07:26:37PM +0300, Michael S. Tsirkin wrote: > On Fri, May 26, 2017 at 03:31:33PM -0400, bfields at fieldses.org wrote: > > Looks like the culprit is very likely d85b758f72b0 "virtio_net: fix > > support for small rings". > > > > After that patch, my NFS server VM stops responding to packets after a > > few minutes of testing.

On Tue, May 30, 2017 at 07:26:37PM +0300, Michael S. Tsirkin wrote: > On Fri, May 26, 2017 at 03:31:33PM -0400, bfields at fieldses.org wrote: > > Looks like the culprit is very likely d85b758f72b0 "virtio_net: fix > > support for small rings". > > > > After that patch, my NFS server VM stops responding to packets after a > > few minutes of testing.

On Fri, Jun 02, 2017 at 12:34:57PM +0300, Sergei Shtylyov wrote: > Hello! > > On 6/2/2017 2:56 AM, Michael S. Tsirkin wrote: > > >commit d85b758f72b0 "virtio_net: fix support for small rings" > > Commit d85b758f72b0 ("virtio_net: fix support for small rings") > > >was supposed to increase the buffer size for small rings > >but had

On Fri, Jun 02, 2017 at 12:34:57PM +0300, Sergei Shtylyov wrote: > Hello! > > On 6/2/2017 2:56 AM, Michael S. Tsirkin wrote: > > >commit d85b758f72b0 "virtio_net: fix support for small rings" > > Commit d85b758f72b0 ("virtio_net: fix support for small rings") > > >was supposed to increase the buffer size for small rings > >but had

Probably should have cc'd virtualization at lists.linux-foundation.org too. On Fri, May 26, 2017 at 11:08:39AM -0400, bfields at fieldses.org wrote: > On Tue, May 23, 2017 at 08:23:34AM -0400, bfields at fieldses.org wrote: > > Unfortunately I can't get anything through testing. It's not your > > patches, it's something in -rc1. My server VM stops responding to

Probably should have cc'd virtualization at lists.linux-foundation.org too. On Fri, May 26, 2017 at 11:08:39AM -0400, bfields at fieldses.org wrote: > On Tue, May 23, 2017 at 08:23:34AM -0400, bfields at fieldses.org wrote: > > Unfortunately I can't get anything through testing. It's not your > > patches, it's something in -rc1. My server VM stops responding to

Looks like the culprit is very likely d85b758f72b0 "virtio_net: fix support for small rings". After that patch, my NFS server VM stops responding to packets after a few minutes of testing. Before that patch, my server keeps working. --b.

Hello! On 6/2/2017 2:56 AM, Michael S. Tsirkin wrote: > commit d85b758f72b0 "virtio_net: fix support for small rings" Commit d85b758f72b0 ("virtio_net: fix support for small rings") > was supposed to increase the buffer size for small rings > but had an unintentional side effect of decreasing > it for large rings. This seems to break some setups - >

On Fri, May 26, 2017 at 03:31:33PM -0400, bfields at fieldses.org wrote: > Looks like the culprit is very likely d85b758f72b0 "virtio_net: fix > support for small rings". > > After that patch, my NFS server VM stops responding to packets after a > few minutes of testing. Before that patch, my server keeps working. > > --b. Others complained about that too.

On Mon, 2 Oct 2017 15:22:24 -0400 bfields at fieldses.org (J. Bruce Fields) wrote: > Mainly I'd just like to know which you're asking for. Do you want me to > apply this, or to ACK it so someone else can? If it's sent as a series > I tend to assume the latter. > > But in this case I'm assuming it's the former, so I'll pick up the nfsd > one.... Could

On Thu, Apr 19, 2018 at 12:12:38PM -0400, Mikulas Patocka wrote: > > > On Wed, 18 Apr 2018, Mikulas Patocka wrote: > > > > > > > On Wed, 18 Apr 2018, David Miller wrote: > > > > > From: Mikulas Patocka <mpatocka at redhat.com> > > > Date: Wed, 18 Apr 2018 12:44:25 -0400 (EDT) > > > > > > > The structure

With 2.6.31-rc5 in a KVM guest using dm and virtio_blk, we see the following errors: end_request: I/O error, dev vda, sector 0 end_request: I/O error, dev vda, sector 0 The errors go away if dm stops submitting empty barriers, by reverting: commit 52b1fd5a27c625c78373e024bf570af3c9d44a79 Author: Mikulas Patocka <mpatocka at redhat.com> dm: send empty barriers to targets in

With 2.6.31-rc5 in a KVM guest using dm and virtio_blk, we see the following errors: end_request: I/O error, dev vda, sector 0 end_request: I/O error, dev vda, sector 0 The errors go away if dm stops submitting empty barriers, by reverting: commit 52b1fd5a27c625c78373e024bf570af3c9d44a79 Author: Mikulas Patocka <mpatocka at redhat.com> dm: send empty barriers to targets in

On Wed, 18 Apr 2018, David Miller wrote: > From: Mikulas Patocka <mpatocka at redhat.com> > Date: Wed, 18 Apr 2018 12:44:25 -0400 (EDT) > > > The structure net_device is followed by arbitrary driver-specific data > > (accessible with the function netdev_priv). And for virtio-net, these > > driver-specific data must be in DMA memory. > > And we are saying

On Fri, May 26, 2017 at 03:31:33PM -0400, bfields at fieldses.org wrote: > Looks like the culprit is very likely d85b758f72b0 "virtio_net: fix > support for small rings". > > After that patch, my NFS server VM stops responding to packets after a > few minutes of testing. Before that patch, my server keeps working. > > --b. So I think I know what caused this:

On Wed, 18 Apr 2018, Eric Dumazet wrote: > > > On 04/18/2018 07:34 AM, Mikulas Patocka wrote: > > The patch 74d332c13b21 changes alloc_netdev_mqs to use vzalloc if kzalloc > > fails (later patches change it to kvzalloc). > > > > The problem with this is that if the vzalloc function is actually used, > > virtio_net doesn't work (because it expects