similar to: [PATCH] MAINTAINERS: update my email address

On Fri, Feb 03, 2017 at 04:48:14PM +0530, Amit Shah wrote: > I'm leaving my job at Red Hat, this email address will stop working next week. > Update it to one that I will have access to later. > > Signed-off-by: Amit Shah <amit.shah at redhat.com> It's great that we'll still have you around! Do you want to send a pull request with this patch? Or want me to merge

Amit Shah <amit.shah at redhat.com> writes: > On (Fri) 19 Jul 2013 [18:17:32], Jason Wang wrote: >> On 07/19/2013 03:48 PM, Amit Shah wrote: >> > On (Fri) 19 Jul 2013 [15:03:50], Jason Wang wrote: >> >> On 07/19/2013 04:16 AM, Amit Shah wrote: >> >>> Between poll() being called and processed, the port can be unplugged. >> >>> Check

Amit Shah <amit.shah at redhat.com> writes: > On (Fri) 19 Jul 2013 [18:17:32], Jason Wang wrote: >> On 07/19/2013 03:48 PM, Amit Shah wrote: >> > On (Fri) 19 Jul 2013 [15:03:50], Jason Wang wrote: >> >> On 07/19/2013 04:16 AM, Amit Shah wrote: >> >>> Between poll() being called and processed, the port can be unplugged. >> >>> Check

Amit Shah <amit.shah at redhat.com> writes: > Remove the debugfs path before freeing port->name, to prevent a possible > use-after-free. > > Reported-by: Jason Wang <jasowang at redhat.com> > Signed-off-by: Amit Shah <amit.shah at redhat.com> Applied, Rusty. > --- > drivers/char/virtio_console.c | 3 +-- > 1 file changed, 1 insertion(+), 2

Amit Shah <amit.shah at redhat.com> writes: > Remove the debugfs path before freeing port->name, to prevent a possible > use-after-free. > > Reported-by: Jason Wang <jasowang at redhat.com> > Signed-off-by: Amit Shah <amit.shah at redhat.com> Applied, Rusty. > --- > drivers/char/virtio_console.c | 3 +-- > 1 file changed, 1 insertion(+), 2

On 07/19/2013 03:48 PM, Amit Shah wrote: > On (Fri) 19 Jul 2013 [15:03:50], Jason Wang wrote: >> On 07/19/2013 04:16 AM, Amit Shah wrote: >>> Between poll() being called and processed, the port can be unplugged. >>> Check if this happened, and bail out. >>> >>> Signed-off-by: Amit Shah <amit.shah at redhat.com> >>> --- >>>

On 07/19/2013 03:48 PM, Amit Shah wrote: > On (Fri) 19 Jul 2013 [15:03:50], Jason Wang wrote: >> On 07/19/2013 04:16 AM, Amit Shah wrote: >>> Between poll() being called and processed, the port can be unplugged. >>> Check if this happened, and bail out. >>> >>> Signed-off-by: Amit Shah <amit.shah at redhat.com> >>> --- >>>

Jason Wang <jasowang at redhat.com> writes: > On 07/22/2013 01:45 PM, Rusty Russell wrote: >> Amit Shah <amit.shah at redhat.com> writes: >>> On (Fri) 19 Jul 2013 [18:17:32], Jason Wang wrote: >>>> On 07/19/2013 03:48 PM, Amit Shah wrote: >>>>> On (Fri) 19 Jul 2013 [15:03:50], Jason Wang wrote: >>>>>> On 07/19/2013 04:16

Jason Wang <jasowang at redhat.com> writes: > On 07/22/2013 01:45 PM, Rusty Russell wrote: >> Amit Shah <amit.shah at redhat.com> writes: >>> On (Fri) 19 Jul 2013 [18:17:32], Jason Wang wrote: >>>> On 07/19/2013 03:48 PM, Amit Shah wrote: >>>>> On (Fri) 19 Jul 2013 [15:03:50], Jason Wang wrote: >>>>>> On 07/19/2013 04:16

Amit Shah <amit.shah at redhat.com> writes: > The removal functions act on the vqs, and the vq operations need to be > locked. > > Signed-off-by: Amit Shah <amit.shah at redhat.com> How can userspace access the port now? By the time we are cleaning up buffers, there should be no possibility of such accesses. The number of bugfixes here is deeply disturbing. I wonder if

Amit Shah <amit.shah at redhat.com> writes: > The removal functions act on the vqs, and the vq operations need to be > locked. > > Signed-off-by: Amit Shah <amit.shah at redhat.com> How can userspace access the port now? By the time we are cleaning up buffers, there should be no possibility of such accesses. The number of bugfixes here is deeply disturbing. I wonder if

On 07/19/2013 04:16 AM, Amit Shah wrote: > Between poll() being called and processed, the port can be unplugged. > Check if this happened, and bail out. > > Signed-off-by: Amit Shah <amit.shah at redhat.com> > --- > drivers/char/virtio_console.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/char/virtio_console.c

On 07/19/2013 04:16 AM, Amit Shah wrote: > Between poll() being called and processed, the port can be unplugged. > Check if this happened, and bail out. > > Signed-off-by: Amit Shah <amit.shah at redhat.com> > --- > drivers/char/virtio_console.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/char/virtio_console.c

Fix checkpatch warning: WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required Cc: Amit Shah <amit.shah at redhat.com> Cc: Arnd Bergmann <arnd at arndb.de> Cc: virtualization at lists.linux-foundation.org Signed-off-by: Fabian Frederick <fabf at skynet.be> --- drivers/char/virtio_console.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)

Fix checkpatch warning: WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required Cc: Amit Shah <amit.shah at redhat.com> Cc: Arnd Bergmann <arnd at arndb.de> Cc: virtualization at lists.linux-foundation.org Signed-off-by: Fabian Frederick <fabf at skynet.be> --- drivers/char/virtio_console.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)

Amit Shah <amit.shah at redhat.com> writes: > On (Sat) 28 Feb 2015 [18:42:25], Michael S. Tsirkin wrote: >> when multiport is off, virtio console invokes config access from irq >> context, config access is blocking on s390. >> Fix this up by scheduling work from config irq - similar to what we do >> for multiport configs. >> >> Signed-off-by: Michael

Amit Shah <amit.shah at redhat.com> writes: > On (Sat) 28 Feb 2015 [18:42:25], Michael S. Tsirkin wrote: >> when multiport is off, virtio console invokes config access from irq >> context, config access is blocking on s390. >> Fix this up by scheduling work from config irq - similar to what we do >> for multiport configs. >> >> Signed-off-by: Michael

When removing a port we don't check if a program was blocked for read. This leads to a crash when SIGTERM is sent to the program after hot-unplugging the port. Signed-off-by: Amit Shah <amit.shah at redhat.com> --- drivers/char/virtio_console.c | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c

When removing a port we don't check if a program was blocked for read. This leads to a crash when SIGTERM is sent to the program after hot-unplugging the port. Signed-off-by: Amit Shah <amit.shah at redhat.com> --- drivers/char/virtio_console.c | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c

On 07/19/2013 04:16 AM, Amit Shah wrote: > If a port gets unplugged while a user is blocked on read(), -ENODEV is > returned. However, subsequent read()s returned 0, indicating there's no > host-side connection (but not indicating the device went away). > > This also happened when a port was unplugged and the user didn't have > any blocking operation pending. If the