similar to: [PATCH net] virtio-net: restore VIRTIO_HDR_F_DATA_VALID on receiving

On 2017?01?21? 00:45, Michael S. Tsirkin wrote: > On Fri, Jan 20, 2017 at 02:32:42PM +0800, Jason Wang wrote: >> Commit 501db511397f ("virtio: don't set VIRTIO_NET_HDR_F_DATA_VALID on >> xmit") in fact disables VIRTIO_HDR_F_DATA_VALID on receiving path too, >> fixing this by adding a hint (has_data_valid) and set it only on the >> receiving path. >>

On 2017?01?21? 00:45, Michael S. Tsirkin wrote: > On Fri, Jan 20, 2017 at 02:32:42PM +0800, Jason Wang wrote: >> Commit 501db511397f ("virtio: don't set VIRTIO_NET_HDR_F_DATA_VALID on >> xmit") in fact disables VIRTIO_HDR_F_DATA_VALID on receiving path too, >> fixing this by adding a hint (has_data_valid) and set it only on the >> receiving path. >>

On Fri, Jan 20, 2017 at 02:32:42PM +0800, Jason Wang wrote: > Commit 501db511397f ("virtio: don't set VIRTIO_NET_HDR_F_DATA_VALID on > xmit") in fact disables VIRTIO_HDR_F_DATA_VALID on receiving path too, > fixing this by adding a hint (has_data_valid) and set it only on the > receiving path. > > Cc: Rolf Neugebauer <rolf.neugebauer at docker.com> >

On Sun, Jan 22, 2017 at 10:41:22AM +0800, Jason Wang wrote: > > > On 2017?01?21? 00:45, Michael S. Tsirkin wrote: > > On Fri, Jan 20, 2017 at 02:32:42PM +0800, Jason Wang wrote: > > > Commit 501db511397f ("virtio: don't set VIRTIO_NET_HDR_F_DATA_VALID on > > > xmit") in fact disables VIRTIO_HDR_F_DATA_VALID on receiving path too, > > >

Hi, This patches introduce virtio_net_hdr_{from,to}_skb functions for conversion of GSO information between skb and virtio_net_hdr. Mike Rapoport (6): virtio_net: add _UAPI prefix to virtio_net header guards virtio_net: introduce virtio_net_hdr_{from,to}_skb macvtap: use common code for virtio_net_hdr and skb GSO conversion tuntap: use common code for virtio_net_hdr and skb GSO

Hi, This patches introduce virtio_net_hdr_{from,to}_skb functions for conversion of GSO information between skb and virtio_net_hdr. Mike Rapoport (6): virtio_net: add _UAPI prefix to virtio_net header guards virtio_net: introduce virtio_net_hdr_{from,to}_skb macvtap: use common code for virtio_net_hdr and skb GSO conversion tuntap: use common code for virtio_net_hdr and skb GSO

On Wed, 23 Sep 2015 19:45:08 +0100 David Woodhouse <dwmw2 at infradead.org> wrote: > Commit 7d82410950aa ("virtio: add explicit big-endian support to memory > accessors") accidentally changed the virtio_net header used by > AF_PACKET with PACKET_VNET_HDR from host-endian to big-endian. > Hi David, Oops my bad... I obviously overlooked this one when adding

On Wed, 23 Sep 2015 19:45:08 +0100 David Woodhouse <dwmw2 at infradead.org> wrote: > Commit 7d82410950aa ("virtio: add explicit big-endian support to memory > accessors") accidentally changed the virtio_net header used by > AF_PACKET with PACKET_VNET_HDR from host-endian to big-endian. > Hi David, Oops my bad... I obviously overlooked this one when adding

There's no need for the guest to validate the checksum if it have been validated by host nics. So this patch introduces a new flag - VIRTIO_NET_HDR_F_DATA_VALID which is used to bypass the checksum examing in guest. The backend (tap/macvtap) may set this flag when met skbs with CHECKSUM_UNNECESSARY to save cpu utilization. No feature negotiation is needed as old driver just ignore this flag.

There's no need for the guest to validate the checksum if it have been validated by host nics. So this patch introduces a new flag - VIRTIO_NET_HDR_F_DATA_VALID which is used to bypass the checksum examing in guest. The backend (tap/macvtap) may set this flag when met skbs with CHECKSUM_UNNECESSARY to save cpu utilization. No feature negotiation is needed as old driver just ignore this flag.

Cc Dave, pls remember to do this next time otherwise your patches won't get merged :) On Wed, Dec 17, 2014 at 06:31:50PM -0500, Vlad Yasevich wrote: > On 12/17/2014 05:45 PM, Michael S. Tsirkin wrote: > > On Wed, Dec 17, 2014 at 01:20:46PM -0500, Vladislav Yasevich wrote: > >> Split IPv6 support for UFO into its own feature similiar to TSO. > >> This will later

Cc Dave, pls remember to do this next time otherwise your patches won't get merged :) On Wed, Dec 17, 2014 at 06:31:50PM -0500, Vlad Yasevich wrote: > On 12/17/2014 05:45 PM, Michael S. Tsirkin wrote: > > On Wed, Dec 17, 2014 at 01:20:46PM -0500, Vladislav Yasevich wrote: > >> Split IPv6 support for UFO into its own feature similiar to TSO. > >> This will later

On Thu, Dec 18, 2014 at 10:01:35AM -0500, Vlad Yasevich wrote: > On 12/18/2014 02:54 AM, Michael S. Tsirkin wrote: > > Cc Dave, pls remember to do this next time otherwise > > your patches won't get merged :) > > > > On Wed, Dec 17, 2014 at 06:31:50PM -0500, Vlad Yasevich wrote: > >> On 12/17/2014 05:45 PM, Michael S. Tsirkin wrote: > >>> On

On Thu, Dec 18, 2014 at 10:01:35AM -0500, Vlad Yasevich wrote: > On 12/18/2014 02:54 AM, Michael S. Tsirkin wrote: > > Cc Dave, pls remember to do this next time otherwise > > your patches won't get merged :) > > > > On Wed, Dec 17, 2014 at 06:31:50PM -0500, Vlad Yasevich wrote: > >> On 12/17/2014 05:45 PM, Michael S. Tsirkin wrote: > >>> On

On Wed, Sep 23, 2015 at 07:45:08PM +0100, David Woodhouse wrote: > Commit 7d82410950aa ("virtio: add explicit big-endian support to memory > accessors") accidentally changed the virtio_net header used by > AF_PACKET with PACKET_VNET_HDR from host-endian to big-endian. > > Since virtio_legacy_is_little_endian() is a very long identifier, > define a VIO_LE macro and use

On Wed, Sep 23, 2015 at 07:45:08PM +0100, David Woodhouse wrote: > Commit 7d82410950aa ("virtio: add explicit big-endian support to memory > accessors") accidentally changed the virtio_net header used by > AF_PACKET with PACKET_VNET_HDR from host-endian to big-endian. > > Since virtio_legacy_is_little_endian() is a very long identifier, > define a VIO_LE macro and use

On Thu, Sep 24, 2015 at 09:25:45AM +0200, Greg Kurz wrote: > On Wed, 23 Sep 2015 19:45:08 +0100 > David Woodhouse <dwmw2 at infradead.org> wrote: > > > Commit 7d82410950aa ("virtio: add explicit big-endian support to memory > > accessors") accidentally changed the virtio_net header used by > > AF_PACKET with PACKET_VNET_HDR from host-endian to

On Wed, Dec 17, 2014 at 01:20:46PM -0500, Vladislav Yasevich wrote: > Split IPv6 support for UFO into its own feature similiar to TSO. > This will later allow us to re-enable UFO support for virtio-net > devices. > > Signed-off-by: Vladislav Yasevich <vyasevic at redhat.com> > --- > include/linux/netdev_features.h | 7 +++++-- > include/linux/netdevice.h | 1

On Wed, Dec 17, 2014 at 01:20:46PM -0500, Vladislav Yasevich wrote: > Split IPv6 support for UFO into its own feature similiar to TSO. > This will later allow us to re-enable UFO support for virtio-net > devices. > > Signed-off-by: Vladislav Yasevich <vyasevic at redhat.com> > --- > include/linux/netdev_features.h | 7 +++++-- > include/linux/netdevice.h | 1

Now that we have SCTP offload capabilities in the kernel, we can add them to virtio as well. First step is SCTP checksum. We need a new freature in virtio to negotiate this support since SCTP is excluded with the stardard checksum and requires a little bit extra. This series proposes VIRTIO_NET_F_SCTP_CSUM feature bit. As the "little bit extra", the kernel uses a new bit in the skb