similar to: [PATCH 0/2] virtio: fix complaint by sparse

On Tue, Nov 22, 2016 at 01:51:50PM +0800, Gonglei wrote: > # make C=2 CF="-D__CHECK_ENDIAN__" ./drivers/virtio/ > > drivers/virtio/virtio_ring.c:423:19: warning: incorrect type in assignment (different base types) > drivers/virtio/virtio_ring.c:423:19: expected unsigned int [unsigned] [assigned] i > drivers/virtio/virtio_ring.c:423:19: got restricted __virtio16

On Tue, Nov 22, 2016 at 01:51:50PM +0800, Gonglei wrote: > # make C=2 CF="-D__CHECK_ENDIAN__" ./drivers/virtio/ > > drivers/virtio/virtio_ring.c:423:19: warning: incorrect type in assignment (different base types) > drivers/virtio/virtio_ring.c:423:19: expected unsigned int [unsigned] [assigned] i > drivers/virtio/virtio_ring.c:423:19: got restricted __virtio16

drivers/virtio/virtio_pci_modern.c:66:40: warning: incorrect type in argument 2 (different base types) drivers/virtio/virtio_pci_modern.c:66:40: expected unsigned int [noderef] [usertype] <asn:2>*addr drivers/virtio/virtio_pci_modern.c:66:40: got restricted __le32 [noderef] [usertype] <asn:2>*lo drivers/virtio/virtio_pci_modern.c:67:33: warning: incorrect type in argument 2

# make C=2 CF="-D__CHECK_ENDIAN__" ./drivers/virtio/ drivers/virtio/virtio_ring.c:423:19: warning: incorrect type in assignment (different base types) drivers/virtio/virtio_ring.c:423:19: expected unsigned int [unsigned] [assigned] i drivers/virtio/virtio_ring.c:423:19: got restricted __virtio16 [usertype] next drivers/virtio/virtio_ring.c:423:19: warning: incorrect type in

On 22.11.2016 16:04, Michael S. Tsirkin wrote: > On Tue, Nov 22, 2016 at 01:51:50PM +0800, Gonglei wrote: >> # make C=2 CF="-D__CHECK_ENDIAN__" ./drivers/virtio/ >> >> drivers/virtio/virtio_ring.c:423:19: warning: incorrect type in assignment (different base types) >> drivers/virtio/virtio_ring.c:423:19: expected unsigned int [unsigned] [assigned] i

Hi: This series tries to fix various issues of vhost: - Patch 1 adds a missing write barrier between used idx updating and logging. - Patch 2-3 brings back the protection of device IOTLB through vq mutex, this fixes possible use after free in device IOTLB entries. - Patch 4 fixes the diry page logging when device IOTLB is enabled. We should done through GPA instead of GIOVA, this was done

Hi: This series tries to fix various issues of vhost: - Patch 1 adds a missing write barrier between used idx updating and logging. - Patch 2-3 brings back the protection of device IOTLB through vq mutex, this fixes possible use after free in device IOTLB entries. - Patch 4 fixes the diry page logging when device IOTLB is enabled. We should done through GPA instead of GIOVA, this was done

Some hardware accelerators (like intel aseni or the s390 cpacf functions) have lower priorities than virtio crypto, and those drivers are faster than the same in the host via virtio. So let's lower the priority of virtio-crypto's algorithm, make it's higher than sofeware implimentations but lower than the hardware ones. Suggested-by: Christian Borntraeger <borntraeger at

Some hardware accelerators (like intel aseni or the s390 cpacf functions) have lower priorities than virtio crypto, and those drivers are faster than the same in the host via virtio. So let's lower the priority of virtio-crypto's algorithm, make it's higher than sofeware implimentations but lower than the hardware ones. Suggested-by: Christian Borntraeger <borntraeger at

On Thursday, December 15, 2016 8:45 AM, Gonglei (Arei) Wrote: < > > diff --git a/drivers/crypto/virtio/virtio_crypto_core.c < > b/drivers/crypto/virtio/virtio_crypto_core.c < > > new file mode 100644 < > > index 0000000..c0854a1 < > > --- /dev/null < > > +++ b/drivers/crypto/virtio/virtio_crypto_core.c < > > @@ -0,0 +1,474 @@ < >

On Thursday, December 15, 2016 8:45 AM, Gonglei (Arei) Wrote: < > > diff --git a/drivers/crypto/virtio/virtio_crypto_core.c < > b/drivers/crypto/virtio/virtio_crypto_core.c < > > new file mode 100644 < > > index 0000000..c0854a1 < > > --- /dev/null < > > +++ b/drivers/crypto/virtio/virtio_crypto_core.c < > > @@ -0,0 +1,474 @@ < >

On Mon, Nov 28, 2016 at 01:56:04AM +0000, Gonglei (Arei) wrote: > Hi Michael, > > Thanks for your feedback firstly! > > > -----Original Message----- > > From: virtio-dev at lists.oasis-open.org [mailto:virtio-dev at lists.oasis-open.org] > > On Behalf Of Michael S. Tsirkin > > Sent: Sunday, November 27, 2016 11:33 AM > > To: Gonglei (Arei) > >

On Mon, Nov 28, 2016 at 01:56:04AM +0000, Gonglei (Arei) wrote: > Hi Michael, > > Thanks for your feedback firstly! > > > -----Original Message----- > > From: virtio-dev at lists.oasis-open.org [mailto:virtio-dev at lists.oasis-open.org] > > On Behalf Of Michael S. Tsirkin > > Sent: Sunday, November 27, 2016 11:33 AM > > To: Gonglei (Arei) > >

Ping...? > -----Original Message----- > From: Gonglei (Arei) > Sent: Tuesday, November 22, 2016 1:52 PM > To: virtualization at lists.linux-foundation.org; linux-kernel at vger.kernel.org > Cc: mst at redhat.com; jasowang at redhat.com; Gonglei (Arei) > Subject: [PATCH 0/2] virtio: fix complaint by sparse > > I found some warnings reported by sparse in the virtio code

On Mon, 28 Nov 2016 20:08:23 +0800 Gonglei <arei.gonglei at huawei.com> wrote: > +static int virtcrypto_update_status(struct virtio_crypto *vcrypto) > +{ > + u32 status; > + int err; > + > + virtio_cread(vcrypto->vdev, > + struct virtio_crypto_config, status, &status); > + > + /* Ignore unknown (future) status bits */ > + status &=

On Mon, 28 Nov 2016 20:08:23 +0800 Gonglei <arei.gonglei at huawei.com> wrote: > +static int virtcrypto_update_status(struct virtio_crypto *vcrypto) > +{ > + u32 status; > + int err; > + > + virtio_cread(vcrypto->vdev, > + struct virtio_crypto_config, status, &status); > + > + /* Ignore unknown (future) status bits */ > + status &=

On Tue, Nov 22, 2016 at 04:10:22PM +0800, Gonglei wrote: > Virtio modern devices are always little edian, let's introduce > the LE functions for read/write configuration space for > virtio modern devices, which avoid complaint by Sparse when > we use the virtio_creaed/virtio_cwrite in VIRTIO_1 devices. > > Signed-off-by: Gonglei <arei.gonglei at huawei.com> > ---

On Tue, Nov 22, 2016 at 04:10:22PM +0800, Gonglei wrote: > Virtio modern devices are always little edian, let's introduce > the LE functions for read/write configuration space for > virtio modern devices, which avoid complaint by Sparse when > we use the virtio_creaed/virtio_cwrite in VIRTIO_1 devices. > > Signed-off-by: Gonglei <arei.gonglei at huawei.com> > ---

On Tue, 29 Nov 2016 01:37:44 +0000 "Gonglei (Arei)" <arei.gonglei at huawei.com> wrote: > > On Mon, 28 Nov 2016 20:08:23 +0800 > > Gonglei <arei.gonglei at huawei.com> wrote: > > > > > +static int virtcrypto_update_status(struct virtio_crypto *vcrypto) > > > +{ > > > + u32 status; > > > + int err; > > > + >

On Tue, 29 Nov 2016 01:37:44 +0000 "Gonglei (Arei)" <arei.gonglei at huawei.com> wrote: > > On Mon, 28 Nov 2016 20:08:23 +0800 > > Gonglei <arei.gonglei at huawei.com> wrote: > > > > > +static int virtcrypto_update_status(struct virtio_crypto *vcrypto) > > > +{ > > > + u32 status; > > > + int err; > > > + >