similar to: [PATCH] CodingStyle: add some more error handling guidelines

On Mon, Aug 22, 2016 at 08:16:17AM -0600, Jonathan Corbet wrote: > On Mon, 22 Aug 2016 16:57:46 +0300 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > commit commit ea04036032edda6f771c1381d03832d2ed0f6c31 ("CodingStyle: > > add some more error handling guidelines") suggests never naming goto > > labels after the goto location - that is

On Mon, Aug 22, 2016 at 08:16:17AM -0600, Jonathan Corbet wrote: > On Mon, 22 Aug 2016 16:57:46 +0300 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > commit commit ea04036032edda6f771c1381d03832d2ed0f6c31 ("CodingStyle: > > add some more error handling guidelines") suggests never naming goto > > labels after the goto location - that is

On Mon, 22 Aug 2016 16:57:46 +0300 "Michael S. Tsirkin" <mst at redhat.com> wrote: > commit commit ea04036032edda6f771c1381d03832d2ed0f6c31 ("CodingStyle: > add some more error handling guidelines") suggests never naming goto > labels after the goto location - that is the error that is handled. > > But it's actually pretty common and IMHO it's a

On Tue, Aug 23, 2016 at 01:03:15PM +0200, Bj?rn Mork wrote: > "Michael S. Tsirkin" <mst at redhat.com> writes: > > > foo = kmalloc(SIZE, GFP_KERNEL); > > if (!foo) > > goto err_foo; > > > > foo->bar = kmalloc(SIZE, GFP_KERNEL); > > if (!foo->bar)

"Michael S. Tsirkin" <mst at redhat.com> writes: > foo = kmalloc(SIZE, GFP_KERNEL); > if (!foo) > goto err_foo; > > foo->bar = kmalloc(SIZE, GFP_KERNEL); > if (!foo->bar) > goto err_bar; > ... > >

vhost_dev_set_owner() is an example of why come-from labels are bad style. devel/drivers/vhost/vhost.c 473 /* Caller should have device mutex */ 474 long vhost_dev_set_owner(struct vhost_dev *dev) 475 { 476 struct task_struct *worker; 477 int err; 478 479 /* Is there an owner already? */ 480 if (vhost_dev_has_owner(dev)) { 481

On Mon, Aug 22, 2016 at 05:53:02PM +0300, Michael S. Tsirkin wrote: > The point is really naming label for the part of init that failed > (and so needs to be skipped), rather than the part that will run. Naming labels after what "needs to be skipped" doesn't work. How does that meaning make sense for err_cgroup in vhost_dev_set_owner()? What needs to be skipped here?

Lol. The mossy side of a boulder is the alloc, the non-mossy side is the free! :P regards, dan carpenter

Dan Carpenter <dan.carpenter at oracle.com> writes: > Hike up the mountain, then if you get stuck hike back down using the > exact same path. OK, I understand what you say. I just can't resist objecting to that example ;) In my experience, finding the exact same path back after hiking up a mountain is really hard. Especially if you are in enough trouble already to get stuck. Up

Dan Carpenter <dan.carpenter at oracle.com> writes: > Hike up the mountain, then if you get stuck hike back down using the > exact same path. OK, I understand what you say. I just can't resist objecting to that example ;) In my experience, finding the exact same path back after hiking up a mountain is really hard. Especially if you are in enough trouble already to get stuck. Up

On Tue, Sep 13, 2016 at 1:15 PM, SF Markus Elfring <elfring at users.sourceforge.net> wrote: > From: Markus Elfring <elfring at users.sourceforge.net> > Date: Tue, 13 Sep 2016 13:50:56 +0200 > > Adjust a jump label according to the current Linux coding style convention. I think you mean "goto label". "Jump label" has a different meaning, see

On Tue, Sep 13, 2016 at 1:15 PM, SF Markus Elfring <elfring at users.sourceforge.net> wrote: > From: Markus Elfring <elfring at users.sourceforge.net> > Date: Tue, 13 Sep 2016 13:50:56 +0200 > > Adjust a jump label according to the current Linux coding style convention. I think you mean "goto label". "Jump label" has a different meaning, see

The following changes since commit 92e963f50fc74041b5e9e744c330dca48e04f08d: Linux 4.5-rc1 (2016-01-24 13:06:47 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to 481eaec37e91e2b33f17275901172f50ce2c71e8: tools/virtio: add ringtest utilities (2016-01-26 10:18:30 +0200)

The following changes since commit 92e963f50fc74041b5e9e744c330dca48e04f08d: Linux 4.5-rc1 (2016-01-24 13:06:47 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to 481eaec37e91e2b33f17275901172f50ce2c71e8: tools/virtio: add ringtest utilities (2016-01-26 10:18:30 +0200)

Having typical usage example in the README file is more convinient than in the git history... Signed-off-by: Mike Rapoport <rppt at linux.vnet.ibm.com> --- tools/virtio/ringtest/README | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/virtio/ringtest/README b/tools/virtio/ringtest/README index 34e94c4..d83707a 100644 --- a/tools/virtio/ringtest/README +++

Having typical usage example in the README file is more convinient than in the git history... Signed-off-by: Mike Rapoport <rppt at linux.vnet.ibm.com> --- tools/virtio/ringtest/README | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/virtio/ringtest/README b/tools/virtio/ringtest/README index 34e94c4..d83707a 100644 --- a/tools/virtio/ringtest/README +++

Hello. On 03/10/2016 05:28 PM, Aaron Conole wrote: > This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it > exists, read the advised MTU and use it. > > No proper error handling is provided for the case where a user changes the > negotiated MTU. A future commit will add proper error handling. Instead, a > warning is emitted if the guest changes the device

Hello. On 03/10/2016 05:28 PM, Aaron Conole wrote: > This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it > exists, read the advised MTU and use it. > > No proper error handling is provided for the case where a user changes the > negotiated MTU. A future commit will add proper error handling. Instead, a > warning is emitted if the guest changes the device

The previous patch renamed several files that are cross-referenced along the Kernel documentation. Adjust the links to point to the right places. Most of the work here was made via a perl script. Two files that got renamed (HOWTO and Changes) required manual work, as there's a high number of false positives. <script> #!/usr/bin/perl use File::Find; my $show_string; $show_string=shift

The previous patch renamed several files that are cross-referenced along the Kernel documentation. Adjust the links to point to the right places. Most of the work here was made via a perl script. Two files that got renamed (HOWTO and Changes) required manual work, as there's a high number of false positives. <script> #!/usr/bin/perl use File::Find; my $show_string; $show_string=shift