similar to: [PATCH] virtio: silence compiler warning

Smatch complains that we might not initialize "queue". The issue is callers like setup_vq() from virtio_pci_modern.c where "num" could be something like 2 and "vring_align" is 64. In that case, vring_size() is less than PAGE_SIZE. It won't happen in real life, but we're getting the value of "num" from a register so it's not really possible to

Smatch complains that we might not initialize "queue". The issue is callers like setup_vq() from virtio_pci_modern.c where "num" could be something like 2 and "vring_align" is 64. In that case, vring_size() is less than PAGE_SIZE. It won't happen in real life, but we're getting the value of "num" from a register so it's not really possible to

On 4/5/16 4:04 AM, Michael S. Tsirkin wrote: > On Mon, Apr 04, 2016 at 02:14:19PM -0400, Jeff Mahoney wrote: >> This fixes the following warning: >> drivers/virtio/virtio_ring.c:1032:5: warning: ?queue? may be used >> uninitialized in this function >> >> The conditions that govern when queue is set aren't apparent to gcc. >> >> Setting queue = NULL

On 4/5/16 4:04 AM, Michael S. Tsirkin wrote: > On Mon, Apr 04, 2016 at 02:14:19PM -0400, Jeff Mahoney wrote: >> This fixes the following warning: >> drivers/virtio/virtio_ring.c:1032:5: warning: ?queue? may be used >> uninitialized in this function >> >> The conditions that govern when queue is set aren't apparent to gcc. >> >> Setting queue = NULL

This fixes the following warning: drivers/virtio/virtio_ring.c:1032:5: warning: ?queue? may be used uninitialized in this function The conditions that govern when queue is set aren't apparent to gcc. Setting queue = NULL clears the warning. Signed-off-by: Jeff Mahoney <jeffm at suse.com> --- drivers/virtio/virtio_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---

This fixes the following warning: drivers/virtio/virtio_ring.c:1032:5: warning: ?queue? may be used uninitialized in this function The conditions that govern when queue is set aren't apparent to gcc. Setting queue = NULL clears the warning. Signed-off-by: Jeff Mahoney <jeffm at suse.com> --- drivers/virtio/virtio_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---

This leaves vring_new_virtqueue alone for compatbility, but it adds two new improved APIs: vring_create_virtqueue: Creates a virtqueue backed by automatically allocated coherent memory. (Some day it this could be extended to support non-coherent memory, too, if there ends up being a platform on which it's worthwhile.) __vring_new_virtqueue: Creates a virtqueue with a manually-specified

'queue' may be used uninitialized in vring_create_virtqueue, actually when we compile kernel, gcc can also give this warning. Fixes: 2a2d1382fe9d ("virtio: Add improved queue allocation API") Signed-off-by: Xin Long <lucien.xin at gmail.com> --- drivers/virtio/virtio_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_ring.c

'queue' may be used uninitialized in vring_create_virtqueue, actually when we compile kernel, gcc can also give this warning. Fixes: 2a2d1382fe9d ("virtio: Add improved queue allocation API") Signed-off-by: Xin Long <lucien.xin at gmail.com> --- drivers/virtio/virtio_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_ring.c

On Mon, Feb 01, 2016 at 10:00:56AM -0800, Andy Lutomirski wrote: > This leaves vring_new_virtqueue alone for compatbility, but it > adds two new improved APIs: > > vring_create_virtqueue: Creates a virtqueue backed by automatically > allocated coherent memory. (Some day it this could be extended to > support non-coherent memory, too, if there ends up being a platform > on

On Mon, Feb 01, 2016 at 10:00:56AM -0800, Andy Lutomirski wrote: > This leaves vring_new_virtqueue alone for compatbility, but it > adds two new improved APIs: > > vring_create_virtqueue: Creates a virtqueue backed by automatically > allocated coherent memory. (Some day it this could be extended to > support non-coherent memory, too, if there ends up being a platform > on

On Mon, Apr 04, 2016 at 02:14:19PM -0400, Jeff Mahoney wrote: > This fixes the following warning: > drivers/virtio/virtio_ring.c:1032:5: warning: ?queue? may be used > uninitialized in this function > > The conditions that govern when queue is set aren't apparent to gcc. > > Setting queue = NULL clears the warning. > > Signed-off-by: Jeff Mahoney <jeffm at

On 2018?03?16? 14:10, Tiwei Bie wrote: > On Fri, Mar 16, 2018 at 12:03:25PM +0800, Jason Wang wrote: >> On 2018?02?23? 19:18, Tiwei Bie wrote: >>> Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> >>> --- >>> drivers/virtio/virtio_ring.c | 699 +++++++++++++++++++++++++++++++++++++------ >>> include/linux/virtio_ring.h | 8 +- >>>

On 2018?03?16? 14:10, Tiwei Bie wrote: > On Fri, Mar 16, 2018 at 12:03:25PM +0800, Jason Wang wrote: >> On 2018?02?23? 19:18, Tiwei Bie wrote: >>> Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> >>> --- >>> drivers/virtio/virtio_ring.c | 699 +++++++++++++++++++++++++++++++++++++------ >>> include/linux/virtio_ring.h | 8 +- >>>

Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> --- drivers/virtio/virtio_ring.c | 699 +++++++++++++++++++++++++++++++++++++------ include/linux/virtio_ring.h | 8 +- 2 files changed, 618 insertions(+), 89 deletions(-) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index eb30f3e09a47..393778a2f809 100644 --- a/drivers/virtio/virtio_ring.c +++

On Fri, Mar 16, 2018 at 07:36:47PM +0800, Jason Wang wrote: > > > @@ -1096,17 +1599,21 @@ struct virtqueue *vring_create_virtqueue( > > > > > > > > if (!queue) { > > > > > > > > /* Try to get a single page. You are my only hope! */ > > > > > > > > - queue = vring_alloc_queue(vdev, vring_size(num,

This commit introduces the support for creating packed ring. All split ring specific functions are added _split suffix. Some necessary stubs for packed ring are also added. Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> --- drivers/virtio/virtio_ring.c | 801 +++++++++++++++++++++++------------ include/linux/virtio_ring.h | 8 +- 2 files changed, 546 insertions(+), 263 deletions(-)

This commit introduces the support for creating packed ring. All split ring specific functions are added _split suffix. Some necessary stubs for packed ring are also added. Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> --- drivers/virtio/virtio_ring.c | 801 +++++++++++++++++++++++------------ include/linux/virtio_ring.h | 8 +- 2 files changed, 546 insertions(+), 263 deletions(-)

On Fri, Mar 16, 2018 at 12:03:25PM +0800, Jason Wang wrote: > On 2018?02?23? 19:18, Tiwei Bie wrote: > > Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> > > --- > > drivers/virtio/virtio_ring.c | 699 +++++++++++++++++++++++++++++++++++++------ > > include/linux/virtio_ring.h | 8 +- > > 2 files changed, 618 insertions(+), 89 deletions(-) > >

On Fri, Mar 16, 2018 at 02:44:12PM +0800, Jason Wang wrote: > On 2018?03?16? 14:10, Tiwei Bie wrote: > > On Fri, Mar 16, 2018 at 12:03:25PM +0800, Jason Wang wrote: > > > On 2018?02?23? 19:18, Tiwei Bie wrote: > > > > Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> > > > > --- > > > > drivers/virtio/virtio_ring.c | 699