similar to: [PATCH] virtio: fix "warning: ‘queue’ may be used uninitialized"

On 4/5/16 4:04 AM, Michael S. Tsirkin wrote: > On Mon, Apr 04, 2016 at 02:14:19PM -0400, Jeff Mahoney wrote: >> This fixes the following warning: >> drivers/virtio/virtio_ring.c:1032:5: warning: ?queue? may be used >> uninitialized in this function >> >> The conditions that govern when queue is set aren't apparent to gcc. >> >> Setting queue = NULL

On 4/5/16 4:04 AM, Michael S. Tsirkin wrote: > On Mon, Apr 04, 2016 at 02:14:19PM -0400, Jeff Mahoney wrote: >> This fixes the following warning: >> drivers/virtio/virtio_ring.c:1032:5: warning: ?queue? may be used >> uninitialized in this function >> >> The conditions that govern when queue is set aren't apparent to gcc. >> >> Setting queue = NULL

On Mon, Apr 04, 2016 at 02:14:19PM -0400, Jeff Mahoney wrote: > This fixes the following warning: > drivers/virtio/virtio_ring.c:1032:5: warning: ?queue? may be used > uninitialized in this function > > The conditions that govern when queue is set aren't apparent to gcc. > > Setting queue = NULL clears the warning. > > Signed-off-by: Jeff Mahoney <jeffm at

V1 -> V2: Move kmalloc() before mutex_lock(), suggested by Arjan. file_remove_suid() should be called with i_mutex held, file_update_time() too. So move them after mutex_lock(). Plus, check the return value of kmalloc(). Signed-off-by: WANG Cong <amwang@redhat.com> Cc: Arjan <arjan@infradead.org> Cc: Chris Mason <chris.mason@oracle.com> Cc: Yan Zheng

This switches virtio to use the DMA API on Xen and if requested by module option. This fixes virtio on Xen, and it should break anything because it's off by default on everything except Xen PV on x86. To the Xen people: is this okay? If it doesn't work on other Xen variants (PVH? HVM?), can you submit follow-up patches to fix it? To everyone else: we've waffled on this for way too

This switches virtio to use the DMA API on Xen and if requested by module option. This fixes virtio on Xen, and it should break anything because it's off by default on everything except Xen PV on x86. To the Xen people: is this okay? If it doesn't work on other Xen variants (PVH? HVM?), can you submit follow-up patches to fix it? To everyone else: we've waffled on this for way too

Hi all - Here''s my current error handling patchset, against 3.1-rc8. Almost all of this patchset is preparing for actual error handling. Before we start in on that work, I''m trying to reduce the surface we need to worry about. It turns out that there is a ton of code that returns an error code but never actually reports an error. The patchset has grown to 65 patches. 46 of them

V2 -> V3: set ''err'' to -ENOMEM when kmalloc() fails. Thanks to Tao. V1 -> V2: Move kmalloc() before mutex_lock(), suggested by Arjan. file_remove_suid() should be called with i_mutex held, file_update_time() too. So move them after mutex_lock(). Plus, check the return value of kmalloc(). Signed-off-by: WANG Cong <amwang@redhat.com> Cc: Arjan

On 2018?03?16? 18:04, Tiwei Bie wrote: > On Fri, Mar 16, 2018 at 04:34:28PM +0800, Jason Wang wrote: >> On 2018?03?16? 15:40, Tiwei Bie wrote: >>> On Fri, Mar 16, 2018 at 02:44:12PM +0800, Jason Wang wrote: >>>> On 2018?03?16? 14:10, Tiwei Bie wrote: >>>>> On Fri, Mar 16, 2018 at 12:03:25PM +0800, Jason Wang wrote: >>>>>> On

On 2018?03?16? 18:04, Tiwei Bie wrote: > On Fri, Mar 16, 2018 at 04:34:28PM +0800, Jason Wang wrote: >> On 2018?03?16? 15:40, Tiwei Bie wrote: >>> On Fri, Mar 16, 2018 at 02:44:12PM +0800, Jason Wang wrote: >>>> On 2018?03?16? 14:10, Tiwei Bie wrote: >>>>> On Fri, Mar 16, 2018 at 12:03:25PM +0800, Jason Wang wrote: >>>>>> On

On Mon, Feb 01, 2016 at 10:00:56AM -0800, Andy Lutomirski wrote: > This leaves vring_new_virtqueue alone for compatbility, but it > adds two new improved APIs: > > vring_create_virtqueue: Creates a virtqueue backed by automatically > allocated coherent memory. (Some day it this could be extended to > support non-coherent memory, too, if there ends up being a platform > on

On Mon, Feb 01, 2016 at 10:00:56AM -0800, Andy Lutomirski wrote: > This leaves vring_new_virtqueue alone for compatbility, but it > adds two new improved APIs: > > vring_create_virtqueue: Creates a virtqueue backed by automatically > allocated coherent memory. (Some day it this could be extended to > support non-coherent memory, too, if there ends up being a platform > on

Hello everyone, This RFC implements a subset of packed ring which is described at https://github.com/oasis-tcs/virtio-docs/blob/master/virtio-v1.1-packed-wd08.pdf The code was tested with DPDK vhost (testpmd/vhost-PMD) implemented by Jens at http://dpdk.org/ml/archives/dev/2018-January/089417.html Minor changes are needed for the vhost code, e.g. to kick the guest. It's not a complete

On 2018?02?23? 19:18, Tiwei Bie wrote: > Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> > --- > drivers/virtio/virtio_ring.c | 699 +++++++++++++++++++++++++++++++++++++------ > include/linux/virtio_ring.h | 8 +- > 2 files changed, 618 insertions(+), 89 deletions(-) > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > index

On 2018?02?23? 19:18, Tiwei Bie wrote: > Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> > --- > drivers/virtio/virtio_ring.c | 699 +++++++++++++++++++++++++++++++++++++------ > include/linux/virtio_ring.h | 8 +- > 2 files changed, 618 insertions(+), 89 deletions(-) > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > index

This switches virtio to use the DMA API on Xen and if requested by module option. This fixes virtio on Xen, and it should break anything because it's off by default on everything except Xen PV on x86. To the Xen people: is this okay? If it doesn't work on other Xen variants (PVH? HVM?), can you submit follow-up patches to fix it? To everyone else: we've waffled on this for way too

This switches virtio to use the DMA API on Xen and if requested by module option. This fixes virtio on Xen, and it should break anything because it's off by default on everything except Xen PV on x86. To the Xen people: is this okay? If it doesn't work on other Xen variants (PVH? HVM?), can you submit follow-up patches to fix it? To everyone else: we've waffled on this for way too

This switches virtio to use the DMA API on Xen and if requested by module option. This fixes virtio on Xen, and it should break anything because it's off by default on everything except Xen PV on x86. To the Xen people: is this okay? If it doesn't work on other Xen variants (PVH? HVM?), can you submit follow-up patches to fix it? To everyone else: we've waffled on this for way too

This switches virtio to use the DMA API on Xen and if requested by module option. This fixes virtio on Xen, and it should break anything because it's off by default on everything except Xen PV on x86. To the Xen people: is this okay? If it doesn't work on other Xen variants (PVH? HVM?), can you submit follow-up patches to fix it? To everyone else: we've waffled on this for way too

This switches virtio to use the DMA API unconditionally. I'm sure it breaks things, but it seems to work on x86 using virtio-pci, with and without Xen, and using both the modern 1.0 variant and the legacy variant. This appears to work on native and Xen x86_64 using both modern and legacy virtio-pci. It also appears to work on arm and arm64. It definitely won't work as-is on s390x, and