similar to: [PATCH] virtio_pci: fix use after free on release

There is a new feature bit allocated in virtio spec to support SR-IOV (Single Root I/O Virtualization): https://github.com/oasis-tcs/virtio-spec/issues/11 This patch enables the support for this feature bit in virtio driver. Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> --- v3: - Drop the acks; v2: - Disable VFs when unbinding the driver (Alex, MST); - Don't use

There is a new feature bit allocated in virtio spec to support SR-IOV (Single Root I/O Virtualization): https://github.com/oasis-tcs/virtio-spec/issues/11 This patch enables the support for this feature bit in virtio driver. Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> --- v3: - Drop the acks; v2: - Disable VFs when unbinding the driver (Alex, MST); - Don't use

There is a new feature bit allocated in virtio spec to support SR-IOV (Single Root I/O Virtualization): https://github.com/oasis-tcs/virtio-spec/issues/11 This patch enables the support for this feature bit in virtio driver. Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> Acked-by: Stefan Hajnoczi <stefanha at redhat.com> Acked-by: Michael S. Tsirkin <mst at redhat.com> ---

There is a new feature bit allocated in virtio spec to support SR-IOV (Single Root I/O Virtualization): https://github.com/oasis-tcs/virtio-spec/issues/11 This patch enables the support for this feature bit in virtio driver. Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> Acked-by: Stefan Hajnoczi <stefanha at redhat.com> Acked-by: Michael S. Tsirkin <mst at redhat.com> ---

On Mon, Jun 04, 2018 at 07:32:25PM +0300, Michael S. Tsirkin wrote: > On Fri, Jun 01, 2018 at 12:02:39PM +0800, Tiwei Bie wrote: > > There is a new feature bit allocated in virtio spec to > > support SR-IOV (Single Root I/O Virtualization): > > > > https://github.com/oasis-tcs/virtio-spec/issues/11 > > > > This patch enables the support for this feature bit

On Tue, Jun 05, 2018 at 03:23:11PM +0300, Michael S. Tsirkin wrote: > On Tue, Jun 05, 2018 at 09:36:53AM +0800, Tiwei Bie wrote: > > On Mon, Jun 04, 2018 at 07:32:25PM +0300, Michael S. Tsirkin wrote: > > > On Fri, Jun 01, 2018 at 12:02:39PM +0800, Tiwei Bie wrote: > > > > There is a new feature bit allocated in virtio spec to > > > > support SR-IOV

On Wed, Jun 06, 2018 at 03:44:11PM +0300, Michael S. Tsirkin wrote: > On Wed, Jun 06, 2018 at 08:11:54PM +0800, Tiwei Bie wrote: > > On Tue, Jun 05, 2018 at 03:23:11PM +0300, Michael S. Tsirkin wrote: > > > On Tue, Jun 05, 2018 at 09:36:53AM +0800, Tiwei Bie wrote: > > > > On Mon, Jun 04, 2018 at 07:32:25PM +0300, Michael S. Tsirkin wrote: > > > > > On

Move resource allocation from common code to legacy and modern code. Only request resources actually used, i.e. bar0 in legacy mode and the bar(s) specified by capabilities in modern mode. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/virtio/virtio_pci_common.c | 7 ------- drivers/virtio/virtio_pci_common.h | 2 ++ drivers/virtio/virtio_pci_legacy.c | 13 ++++++++++++-

Move resource allocation from common code to legacy and modern code. Only request resources actually used, i.e. bar0 in legacy mode and the bar(s) specified by capabilities in modern mode. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/virtio/virtio_pci_common.c | 7 ------- drivers/virtio/virtio_pci_common.h | 2 ++ drivers/virtio/virtio_pci_legacy.c | 13 ++++++++++++-

Move resource allocation from common code to legacy and modern code. Only request resources actually used, i.e. bar0 in legacy mode and the bar(s) specified by capabilities in modern mode. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/virtio/virtio_pci_common.c | 7 ------- drivers/virtio/virtio_pci_common.h | 2 ++ drivers/virtio/virtio_pci_legacy.c | 13 ++++++++++++-

Move resource allocation from common code to legacy and modern code. Only request resources actually used, i.e. bar0 in legacy mode and the bar(s) specified by capabilities in modern mode. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/virtio/virtio_pci_common.c | 7 ------- drivers/virtio/virtio_pci_common.h | 2 ++ drivers/virtio/virtio_pci_legacy.c | 13 ++++++++++++-

There is a new feature bit allocated in virtio spec to support SR-IOV (Single Root I/O Virtualization): https://github.com/oasis-tcs/virtio-spec/issues/11 This patch enables the support for this feature bit in virtio driver. Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> --- This patch depends on below proposal: https://lists.oasis-open.org/archives/virtio-dev/201805/msg00154.html

There is a new feature bit allocated in virtio spec to support SR-IOV (Single Root I/O Virtualization): https://github.com/oasis-tcs/virtio-spec/issues/11 This patch enables the support for this feature bit in virtio driver. Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> --- This patch depends on below proposal: https://lists.oasis-open.org/archives/virtio-dev/201805/msg00154.html

Move resource allocation from common code to legacy and modern code. Only request resources actually used, i.e. bar0 in legacy mode and the regions specified by capabilities in modern mode. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/virtio/virtio_pci_common.c | 7 ----- drivers/virtio/virtio_pci_common.h | 5 ++++ drivers/virtio/virtio_pci_legacy.c | 13 +++++++++-

Move resource allocation from common code to legacy and modern code. Only request resources actually used, i.e. bar0 in legacy mode and the regions specified by capabilities in modern mode. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/virtio/virtio_pci_common.c | 7 ----- drivers/virtio/virtio_pci_common.h | 5 ++++ drivers/virtio/virtio_pci_legacy.c | 13 +++++++++-

Move resource allocation from common code to legacy and modern code. Only request resources actually used, i.e. bar0 in legacy mode and the regions specified by capabilities in modern mode. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/virtio/virtio_pci_common.c | 7 ---- drivers/virtio/virtio_pci_common.h | 5 +++ drivers/virtio/virtio_pci_legacy.c | 13 +++++++-

Move resource allocation from common code to legacy and modern code. Only request resources actually used, i.e. bar0 in legacy mode and the regions specified by capabilities in modern mode. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/virtio/virtio_pci_common.c | 7 ---- drivers/virtio/virtio_pci_common.h | 5 +++ drivers/virtio/virtio_pci_legacy.c | 13 +++++++-

On Mon, 11 Dec 2017 23:55:16 +0800 weiping zhang <zhangweiping at didichuxing.com> wrote: > don't free vp_dev until vp_dev->vdev.dev.release be called. Maybe add the same description as in your virtio_mmio patch so that it is clear why the kfree() is not ok? > > Signed-off-by: weiping zhang <zhangweiping at didichuxing.com> > --- >

On Mon, 11 Dec 2017 23:55:16 +0800 weiping zhang <zhangweiping at didichuxing.com> wrote: > don't free vp_dev until vp_dev->vdev.dev.release be called. Maybe add the same description as in your virtio_mmio patch so that it is clear why the kfree() is not ok? > > Signed-off-by: weiping zhang <zhangweiping at didichuxing.com> > --- >

On Tue, Dec 12, 2017 at 09:24:02PM +0800, weiping zhang wrote: > As mentioned at drivers/base/core.c: > /* > * NOTE: _Never_ directly free @dev after calling this function, even > * if it returned an error! Always use put_device() to give up the > * reference initialized in this function instead. > */ > so we don't free vp_dev until vp_dev->vdev.dev.release be