similar to: [PATCH V2] virtio-input: reset device and detach unused during remove

virtio-input is basically evdev-events-over-virtio, so this driver isn't much more than reading configuration from config space and forwarding incoming events to the linux input layer. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- MAINTAINERS | 6 + drivers/virtio/Kconfig | 10 + drivers/virtio/Makefile | 1 +

virtio-input is basically evdev-events-over-virtio, so this driver isn't much more than reading configuration from config space and forwarding incoming events to the linux input layer. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- MAINTAINERS | 6 + drivers/virtio/Kconfig | 10 + drivers/virtio/Makefile | 1 +

On Tue, Mar 24, 2015 at 08:32:01AM +0100, Gerd Hoffmann wrote: > virtio-input is basically evdev-events-over-virtio, so this driver isn't > much more than reading configuration from config space and forwarding > incoming events to the linux input layer. > > Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> Looks pretty neat overall. I think I still see some small

On Tue, Mar 24, 2015 at 08:32:01AM +0100, Gerd Hoffmann wrote: > virtio-input is basically evdev-events-over-virtio, so this driver isn't > much more than reading configuration from config space and forwarding > incoming events to the linux input layer. > > Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> Looks pretty neat overall. I think I still see some small

On Tue, Mar 24, 2015 at 09:23:37AM -0700, Dmitry Torokhov wrote: > On Tue, Mar 24, 2015 at 11:36:31AM +0100, Michael S. Tsirkin wrote: > > On Tue, Mar 24, 2015 at 08:32:01AM +0100, Gerd Hoffmann wrote: > > > virtio-input is basically evdev-events-over-virtio, so this driver isn't > > > much more than reading configuration from config space and forwarding > >

On Tue, Mar 24, 2015 at 09:23:37AM -0700, Dmitry Torokhov wrote: > On Tue, Mar 24, 2015 at 11:36:31AM +0100, Michael S. Tsirkin wrote: > > On Tue, Mar 24, 2015 at 08:32:01AM +0100, Gerd Hoffmann wrote: > > > virtio-input is basically evdev-events-over-virtio, so this driver isn't > > > much more than reading configuration from config space and forwarding > >

Spec requires a device reset during cleanup, so do it and avoid warn in virtio core. Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/virtio/virtio_input.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/virtio/virtio_input.c b/drivers/virtio/virtio_input.c index 60e2a16..6222f9b 100644 --- a/drivers/virtio/virtio_input.c +++ b/drivers/virtio/virtio_input.c @@

Spec requires a device reset during cleanup, so do it and avoid warn in virtio core. Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/virtio/virtio_input.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/virtio/virtio_input.c b/drivers/virtio/virtio_input.c index 60e2a16..6222f9b 100644 --- a/drivers/virtio/virtio_input.c +++ b/drivers/virtio/virtio_input.c @@

virtio-input is basically evdev-events-over-virtio, so this driver isn't much more than reading configuration from config space and forwarding incoming events to the linux input layer. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- MAINTAINERS | 6 + drivers/virtio/Kconfig | 10 ++ drivers/virtio/Makefile | 1 +

virtio-input is basically evdev-events-over-virtio, so this driver isn't much more than reading configuration from config space and forwarding incoming events to the linux input layer. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- MAINTAINERS | 6 + drivers/virtio/Kconfig | 10 ++ drivers/virtio/Makefile | 1 +

virtio-input is basically evdev-events-over-virtio, so this driver isn't much more than reading configuration from config space and forwarding incoming events to the linux input layer. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- MAINTAINERS | 6 + drivers/virtio/Kconfig | 10 ++ drivers/virtio/Makefile | 1 +

virtio-input is basically evdev-events-over-virtio, so this driver isn't much more than reading configuration from config space and forwarding incoming events to the linux input layer. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- MAINTAINERS | 6 + drivers/virtio/Kconfig | 10 ++ drivers/virtio/Makefile | 1 +

On Wed, Aug 05, 2015 at 03:20:18PM +0800, Jason Wang wrote: > Spec requires a device reset during cleanup, so do it and avoid warn > in virtio core. > > Signed-off-by: Jason Wang <jasowang at redhat.com> OK but now that I look at this driver, that's not enough. Need to also detach and free unused buffers, otherwise we leak memory in evt and sts queues. > --- >

virtio-input is basically evdev-events-over-virtio, so this driver isn't much more than reading configuration from config space and forwarding incoming events to the linux input layer. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- MAINTAINERS | 6 + drivers/virtio/Kconfig | 10 ++ drivers/virtio/Makefile | 1 +

virtio-input is basically evdev-events-over-virtio, so this driver isn't much more than reading configuration from config space and forwarding incoming events to the linux input layer. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- MAINTAINERS | 6 + drivers/virtio/Kconfig | 10 ++ drivers/virtio/Makefile | 1 +

virtio-input is basically evdev-events-over-virtio, so this driver isn't much more than reading configuration from config space and forwarding incoming events to the linux input layer. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/virtio/Kconfig | 10 ++ drivers/virtio/Makefile | 1 + drivers/virtio/virtio_input.c | 313

virtio-input is basically evdev-events-over-virtio, so this driver isn't much more than reading configuration from config space and forwarding incoming events to the linux input layer. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/virtio/Kconfig | 10 ++ drivers/virtio/Makefile | 1 + drivers/virtio/virtio_input.c | 313

On Tue, Mar 24, 2015 at 11:36:31AM +0100, Michael S. Tsirkin wrote: > On Tue, Mar 24, 2015 at 08:32:01AM +0100, Gerd Hoffmann wrote: > > virtio-input is basically evdev-events-over-virtio, so this driver isn't > > much more than reading configuration from config space and forwarding > > incoming events to the linux input layer. > > > > Signed-off-by: Gerd

On Tue, Mar 24, 2015 at 11:36:31AM +0100, Michael S. Tsirkin wrote: > On Tue, Mar 24, 2015 at 08:32:01AM +0100, Gerd Hoffmann wrote: > > virtio-input is basically evdev-events-over-virtio, so this driver isn't > > much more than reading configuration from config space and forwarding > > incoming events to the linux input layer. > > > > Signed-off-by: Gerd

Hi, > > +static int virtinput_send_status(struct virtio_input *vi, > > + u16 type, u16 code, s32 value) > > +{ > > + struct virtio_input_event *stsbuf; > > + struct scatterlist sg[1]; > > + > > + stsbuf = kzalloc(sizeof(*stsbuf), GFP_ATOMIC); > > + if (!stsbuf) > > + return -ENOMEM; > > Does this return an error to userspace? >