similar to: [PULL] virtio/vhost: cross endian support

On Wed, Jul 01, 2015 at 12:02:50PM -0700, Linus Torvalds wrote: > On Wed, Jul 1, 2015 at 2:31 AM, Michael S. Tsirkin <mst at redhat.com> wrote: > > virtio/vhost: cross endian support > > Ugh. Does this really have to be dynamic? > > Can't virtio do the sane thing, and just use a _fixed_ endianness? > > Doing a unconditional byte swap is faster and simpler

On Wed, Jul 01, 2015 at 12:02:50PM -0700, Linus Torvalds wrote: > On Wed, Jul 1, 2015 at 2:31 AM, Michael S. Tsirkin <mst at redhat.com> wrote: > > virtio/vhost: cross endian support > > Ugh. Does this really have to be dynamic? > > Can't virtio do the sane thing, and just use a _fixed_ endianness? > > Doing a unconditional byte swap is faster and simpler

On Thu, Jul 02, 2015 at 11:12:56AM +0200, Greg Kurz wrote: > On Thu, 2 Jul 2015 08:01:28 +0200 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > On Wed, Jul 01, 2015 at 12:02:50PM -0700, Linus Torvalds wrote: > > > On Wed, Jul 1, 2015 at 2:31 AM, Michael S. Tsirkin <mst at redhat.com> wrote: > > > > virtio/vhost: cross endian support

On Thu, Jul 02, 2015 at 11:12:56AM +0200, Greg Kurz wrote: > On Thu, 2 Jul 2015 08:01:28 +0200 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > On Wed, Jul 01, 2015 at 12:02:50PM -0700, Linus Torvalds wrote: > > > On Wed, Jul 1, 2015 at 2:31 AM, Michael S. Tsirkin <mst at redhat.com> wrote: > > > > virtio/vhost: cross endian support

On Wed, Jul 1, 2015 at 12:02 PM, Linus Torvalds <torvalds at linux-foundation.org> wrote: > > Doing a unconditional byte swap is faster and simpler than the crazy > conditionals. Unconditional endianness not only makes for simpler and faster code, it also ends up being easier to debug and add things like type annotations for sparse. Linus

On Wed, Jul 1, 2015 at 12:02 PM, Linus Torvalds <torvalds at linux-foundation.org> wrote: > > Doing a unconditional byte swap is faster and simpler than the crazy > conditionals. Unconditional endianness not only makes for simpler and faster code, it also ends up being easier to debug and add things like type annotations for sparse. Linus

On Thu, 2 Jul 2015 08:01:28 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > On Wed, Jul 01, 2015 at 12:02:50PM -0700, Linus Torvalds wrote: > > On Wed, Jul 1, 2015 at 2:31 AM, Michael S. Tsirkin <mst at redhat.com> wrote: > > > virtio/vhost: cross endian support > > > > Ugh. Does this really have to be dynamic? > > > >

On Thu, Jul 02, 2015 at 08:01:28AM +0200, Michael S. Tsirkin wrote: > On Wed, Jul 01, 2015 at 12:02:50PM -0700, Linus Torvalds wrote: > > On Wed, Jul 1, 2015 at 2:31 AM, Michael S. Tsirkin <mst at redhat.com> wrote: > > > virtio/vhost: cross endian support > > > > Ugh. Does this really have to be dynamic? > > > > Can't virtio do the sane thing,

On Fri, 10 Apr 2015 12:15:00 +0200 Greg Kurz <gkurz at linux.vnet.ibm.com> wrote: > Hi, > > This patchset allows vhost to be used with legacy virtio when guest and host > have a different endianness. > > Patch 7 got rewritten according to Cornelia's and Michael's comments. I have > also introduced patch 8 that brings BE vnet headers support to tun/macvtap.

On Fri, Apr 10, 2015 at 12:15:00PM +0200, Greg Kurz wrote: > Hi, > > This patchset allows vhost to be used with legacy virtio when guest and host > have a different endianness. > > Patch 7 got rewritten according to Cornelia's and Michael's comments. I have > also introduced patch 8 that brings BE vnet headers support to tun/macvtap. > > This series is enough

On Fri, 24 Apr 2015 15:31:54 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > On Fri, Apr 24, 2015 at 02:24:15PM +0200, Greg Kurz wrote: > > Only cosmetic and documentation changes since v5. > > > > --- > > Looks sane to me. I plan to review and apply next week. > Hi Michael, I realize you just got back and have tons of things to do... Do

On Fri, 24 Apr 2015 15:31:54 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > On Fri, Apr 24, 2015 at 02:24:15PM +0200, Greg Kurz wrote: > > Only cosmetic and documentation changes since v5. > > > > --- > > Looks sane to me. I plan to review and apply next week. > Hi Michael, I realize you just got back and have tons of things to do... Do

On Tue, Apr 07, 2015 at 02:09:29PM +0200, Greg Kurz wrote: > Hi, > > This patchset allows vhost to be used with legacy virtio when guest and host > have a different endianness. > > Patches 1-6 remain the same as the previous post. Patch 7 was heavily changed > according to MST's comments. This still doesn't actually work, right? tun and macvtap need new ioctls too

On Tue, Jul 07, 2015 at 06:36:53PM +0200, Thomas Huth wrote: > On Thu, 2 Jul 2015 11:32:52 +0200 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > On Thu, Jul 02, 2015 at 11:12:56AM +0200, Greg Kurz wrote: > > > On Thu, 2 Jul 2015 08:01:28 +0200 > > > "Michael S. Tsirkin" <mst at redhat.com> wrote: > ... > > > >

On Tue, Jul 07, 2015 at 06:36:53PM +0200, Thomas Huth wrote: > On Thu, 2 Jul 2015 11:32:52 +0200 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > On Thu, Jul 02, 2015 at 11:12:56AM +0200, Greg Kurz wrote: > > > On Thu, 2 Jul 2015 08:01:28 +0200 > > > "Michael S. Tsirkin" <mst at redhat.com> wrote: > ... > > > >

On Wed, Jul 1, 2015 at 2:31 AM, Michael S. Tsirkin <mst at redhat.com> wrote: > virtio/vhost: cross endian support Ugh. Does this really have to be dynamic? Can't virtio do the sane thing, and just use a _fixed_ endianness? Doing a unconditional byte swap is faster and simpler than the crazy conditionals. That's true regardless of endianness, but gets to be even more so if the

On Fri, Apr 24, 2015 at 02:24:15PM +0200, Greg Kurz wrote: > Only cosmetic and documentation changes since v5. > > --- Looks sane to me. I plan to review and apply next week. > Greg Kurz (8): > virtio: introduce virtio_is_little_endian() helper > tun: add tun_is_little_endian() helper > macvtap: introduce macvtap_is_little_endian() helper >

On Tue, May 12, 2015 at 12:44:26PM +0200, Greg Kurz wrote: > On Fri, 24 Apr 2015 15:31:54 +0200 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > On Fri, Apr 24, 2015 at 02:24:15PM +0200, Greg Kurz wrote: > > > Only cosmetic and documentation changes since v5. > > > > > > --- > > > > Looks sane to me. I plan to review

Hi, This patchset allows vhost to be used with legacy virtio when guest and host have a different endianness. It is a complete rework of my initial post. Patches 1 to 5 are preliminary work: we move the endianness check out of all memory accessors to separate functions. Patch 6 changes the semantics of the accessors so that they have explicit big endian support. Patch 7 brings the cross-endian

Hi, This patchset allows vhost to be used with legacy virtio when guest and host have a different endianness. It is a complete rework of my initial post. Patches 1 to 5 are preliminary work: we move the endianness check out of all memory accessors to separate functions. Patch 6 changes the semantics of the accessors so that they have explicit big endian support. Patch 7 brings the cross-endian