similar to: [PATCH] virtio_net: document VIRTIO_NET_CTRL_GUEST_OFFLOADS

This patch enables the interrupt coalescing setting through ethtool. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/net/virtio_net.c | 67 +++++++++++++++++++++++++++++++++++++++++ include/uapi/linux/virtio_net.h | 12 ++++++++ 2 files changed, 79 insertions(+) diff

This patch enables the interrupt coalescing setting through ethtool. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/net/virtio_net.c | 67 +++++++++++++++++++++++++++++++++++++++++ include/uapi/linux/virtio_net.h | 12 ++++++++ 2 files changed, 79 insertions(+) diff

A draft version of the MTU Advice feature bit was specified as 25. This bit is not within the allowed range for network device feature bits, and should be changed to be feature bit 3 to fully comply with the spec. Fixes 14de9d114a82 ('virtio-net: Add initial MTU advice feature') Signed-off-by: Aaron Conole <aconole at redhat.com> Suggested-by: "Michael S. Tsirkin" <mst

A draft version of the MTU Advice feature bit was specified as 25. This bit is not within the allowed range for network device feature bits, and should be changed to be feature bit 3 to fully comply with the spec. Fixes 14de9d114a82 ('virtio-net: Add initial MTU advice feature') Signed-off-by: Aaron Conole <aconole at redhat.com> Suggested-by: "Michael S. Tsirkin" <mst

On Tue, Feb 10, 2015 at 12:02:37PM +1030, Rusty Russell wrote: > Jason Wang <jasowang at redhat.com> writes: > > This patch enables the interrupt coalescing setting through ethtool. > > The problem is that there's nothing network specific about interrupt > coalescing. I can see other devices wanting exactly the same thing, > which means we'd deprecate this in

On Tue, Feb 10, 2015 at 12:02:37PM +1030, Rusty Russell wrote: > Jason Wang <jasowang at redhat.com> writes: > > This patch enables the interrupt coalescing setting through ethtool. > > The problem is that there's nothing network specific about interrupt > coalescing. I can see other devices wanting exactly the same thing, > which means we'd deprecate this in

To support SCTP checksum offloading, we need to add a new feature to virtio_net, so we can negotiate support between the hypervisor and the guest. The signalling to the guest that an alternate checksum needs to be used is done via a new flag in the virtio_net_hdr. If the flag is set, the host will know to perform an alternate checksum calculation, which right now is only CRC32c. Signed-off-by:

On Tue, Feb 10, 2015 at 9:32 AM, Rusty Russell <rusty at rustcorp.com.au> wrote: > Jason Wang <jasowang at redhat.com> writes: >> This patch enables the interrupt coalescing setting through ethtool. > > The problem is that there's nothing network specific about interrupt > coalescing. I can see other devices wanting exactly the same thing, > which means

On Tue, Feb 10, 2015 at 9:32 AM, Rusty Russell <rusty at rustcorp.com.au> wrote: > Jason Wang <jasowang at redhat.com> writes: >> This patch enables the interrupt coalescing setting through ethtool. > > The problem is that there's nothing network specific about interrupt > coalescing. I can see other devices wanting exactly the same thing, > which means

On 04/11/2018 06:49 PM, Michael S. Tsirkin wrote: > On Mon, Apr 02, 2018 at 09:40:02AM -0400, Vladislav Yasevich wrote: >> To support SCTP checksum offloading, we need to add a new feature >> to virtio_net, so we can negotiate support between the hypervisor >> and the guest. >> >> The signalling to the guest that an alternate checksum needs to >> be used is

On Mon, Apr 16, 2018 at 09:45:48AM -0400, Vlad Yasevich wrote: > On 04/11/2018 06:49 PM, Michael S. Tsirkin wrote: > > On Mon, Apr 02, 2018 at 09:40:02AM -0400, Vladislav Yasevich wrote: > >> To support SCTP checksum offloading, we need to add a new feature > >> to virtio_net, so we can negotiate support between the hypervisor > >> and the guest. > >>

On 08/27/2014 09:45 AM, Hengjinxiao wrote: > Selftest is an important part of network driver, this patch adds selftest for > virtio-net, including loopback test, negotiate test and reset test. Loopback > test checks whether virtio-net can send and receive packets normally. Negotiate test > executes feature negotiation between virtio-net driver in Guest OS and virtio-net > device

On Mon, Apr 02, 2018 at 09:40:02AM -0400, Vladislav Yasevich wrote: > To support SCTP checksum offloading, we need to add a new feature > to virtio_net, so we can negotiate support between the hypervisor > and the guest. > > The signalling to the guest that an alternate checksum needs to > be used is done via a new flag in the virtio_net_hdr. If the > flag is set, the host

On Mon, Apr 02, 2018 at 09:40:02AM -0400, Vladislav Yasevich wrote: > To support SCTP checksum offloading, we need to add a new feature > to virtio_net, so we can negotiate support between the hypervisor > and the guest. > > The signalling to the guest that an alternate checksum needs to > be used is done via a new flag in the virtio_net_hdr. If the > flag is set, the host

Signed-off-by: Yuval Shaia <yuval.shaia at oracle.com> --- drivers/net/virtio_net.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 07c1e81087b2..be1188815c72 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -1587,7 +1587,8 @@ static netdev_tx_t start_xmit(struct sk_buff *skb,

Signed-off-by: Yuval Shaia <yuval.shaia at oracle.com> --- drivers/net/virtio_net.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 07c1e81087b2..be1188815c72 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -1587,7 +1587,8 @@ static netdev_tx_t start_xmit(struct sk_buff *skb,

All the classes of commands are defined without indentation. All the commands are defined with indentation of 1 space. Only the last one (VIRTIO_NET_CTRL_GUEST_OFFLOADS_SET at the end of the file) does not have an indentation. On Mon, Mar 2, 2020 at 12:54 PM Michael S. Tsirkin <mst at redhat.com> wrote: > > On Mon, Mar 02, 2020 at 10:53:14AM +0200, Yuri Benditovich wrote: > > On

Current XDP implementation want guest offloads feature to be disabled on qemu cli. This is inconvenient and means guest can't benefit from offloads if XDP is not used. This patch tries to address this limitation by disable the offloads on demand through control guest offloads. Guest offloads will be disabled and enabled on demand on XDP set. Signed-off-by: Jason Wang <jasowang at

Current XDP implementation wants guest offloads feature to be disabled on device. This is inconvenient and means guest can't benefit from offloads if XDP is not used. This patch tries to address this limitation by disabling the offloads on demand through control guest offloads. Guest offloads will be disabled and enabled on demand on XDP set. Signed-off-by: Jason Wang <jasowang at

On 2017?07?19? 04:07, Michael S. Tsirkin wrote: > On Mon, Jul 17, 2017 at 08:44:01PM +0800, Jason Wang wrote: >> Current XDP implementation want guest offloads feature to be disabled > s/want/wants/ > >> on qemu cli. > on the device. > >> This is inconvenient and means guest can't benefit from >> offloads if XDP is not used. This patch tries to address