similar to: virtio-net: why not always to set avail->flags to VRING_AVAIL_F_NO_INTERRUPT

On 2015/6/4 9:13, Rusty Russell wrote: > Linhaifeng <haifeng.lin at huawei.com> writes: >> Hi, >> >> I'm a newbie and have a question about vring_new_virtqueue function. >> >> Why we set avail->flags to VRING_AVAIL_F_NO_INTERRUPT when no callbacks? >> I think we should set avail->flags to VRING_AVAIL_F_NO_INTERRUPT even if no callbacks. >

On 2015/6/4 9:13, Rusty Russell wrote: > Linhaifeng <haifeng.lin at huawei.com> writes: >> Hi, >> >> I'm a newbie and have a question about vring_new_virtqueue function. >> >> Why we set avail->flags to VRING_AVAIL_F_NO_INTERRUPT when no callbacks? >> I think we should set avail->flags to VRING_AVAIL_F_NO_INTERRUPT even if no callbacks. >

Linhaifeng <haifeng.lin at huawei.com> writes: > Hi, > > I'm a newbie and have a question about vring_new_virtqueue function. > > Why we set avail->flags to VRING_AVAIL_F_NO_INTERRUPT when no callbacks? > I think we should set avail->flags to VRING_AVAIL_F_NO_INTERRUPT even if no callbacks. Hi Linhaifeng, Not sure I understand your question, but I'll

Improves cacheline transfer flow of available ring header. Virtqueues are implemented as a pair of rings, one producer->consumer avail ring and one consumer->producer used ring; preceding the avail ring in memory are two contiguous u16 fields -- avail->flags and avail->idx. A producer posts work by writing to avail->idx and a consumer reads avail->idx. The flags and idx fields

Improves cacheline transfer flow of available ring header. Virtqueues are implemented as a pair of rings, one producer->consumer avail ring and one consumer->producer used ring; preceding the avail ring in memory are two contiguous u16 fields -- avail->flags and avail->idx. A producer posts work by writing to avail->idx and a consumer reads avail->idx. The flags and idx fields

On Tue, Nov 10, 2015 at 04:21:07PM -0800, Venkatesh Srinivas wrote: > Improves cacheline transfer flow of available ring header. > > Virtqueues are implemented as a pair of rings, one producer->consumer > avail ring and one consumer->producer used ring; preceding the > avail ring in memory are two contiguous u16 fields -- avail->flags > and avail->idx. A producer

On Sun, Mar 15, 2015 at 02:50:27PM +0800, Linhaifeng wrote: > Hi,Michael > > I had tested the start_xmit function by the follow code found that the tx queue's state is stopped and can't send any packets anymore. Why don't you Cc all maintainers on this email? Pls check the file MAINTAINERS for the full list. I added Cc for now. > > static netdev_tx_t

On Sun, Mar 15, 2015 at 02:50:27PM +0800, Linhaifeng wrote: > Hi,Michael > > I had tested the start_xmit function by the follow code found that the tx queue's state is stopped and can't send any packets anymore. Why don't you Cc all maintainers on this email? Pls check the file MAINTAINERS for the full list. I added Cc for now. > > static netdev_tx_t

On Fri, Mar 24, 2023 at 02:47:02PM +0800, Jason Wang wrote: > On Fri, Mar 24, 2023 at 2:42?PM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > On Fri, Mar 24, 2023 at 02:32:40PM +0800, Jason Wang wrote: > > > On Fri, Mar 24, 2023 at 1:59?PM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > > > > > On Fri, Mar 24, 2023 at

Hi Michael, Albert, Albert Huang wrote on Sat, Mar 25, 2023 at 06:56:33PM +0800: > in virtio_net, if we disable the napi_tx, when we triger a tx interrupt, > the vq->event_triggered will be set to true. It will no longer be set to > false. Unless we explicitly call virtqueue_enable_cb_delayed or > virtqueue_enable_cb_prepare. This patch (commited as 35395770f803

This adds a way to check ring empty state after enable_cb outside any locks. Will be used by virtio_net. Note: there's room for more optimization: caller is likely to have a memory barrier already, which means we might be able to get rid of a barrier here. Deferring this optimization until we do some benchmarking. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> ---

This adds a way to check ring empty state after enable_cb outside any locks. Will be used by virtio_net. Note: there's room for more optimization: caller is likely to have a memory barrier already, which means we might be able to get rid of a barrier here. Deferring this optimization until we do some benchmarking. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> ---

On Thu, Mar 23, 2023 at 4:01?PM ?? <huangjie.albert at bytedance.com> wrote: > > Jason Wang <jasowang at redhat.com> ?2023?3?22??? 10:37??? > > > > On Tue, Mar 21, 2023 at 5:00?PM Albert Huang > > <huangjie.albert at bytedance.com> wrote: > > > > > > From: "huangjie.albert" <huangjie.albert at bytedance.com> > > >

This patch introduces virtio_enable_cb_avail() to publish avail idx and used event. This could be used by batched buffer submitting to reduce the number of tx interrupts. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/virtio/virtio_ring.c | 22 ++++++++++++++++++++--

This patch introduces virtio_enable_cb_avail() to publish avail idx and used event. This could be used by batched buffer submitting to reduce the number of tx interrupts. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/virtio/virtio_ring.c | 22 ++++++++++++++++++++--

On 10/15/2014 05:28 PM, Michael S. Tsirkin wrote: > On Wed, Oct 15, 2014 at 03:25:26PM +0800, Jason Wang wrote: >> This patch introduces virtio_enable_cb_avail() to publish avail idx >> and used event. This could be used by batched buffer submitting to >> reduce the number of tx interrupts. >> >> Cc: Rusty Russell <rusty at rustcorp.com.au> >> Cc:

On 10/15/2014 05:28 PM, Michael S. Tsirkin wrote: > On Wed, Oct 15, 2014 at 03:25:26PM +0800, Jason Wang wrote: >> This patch introduces virtio_enable_cb_avail() to publish avail idx >> and used event. This could be used by batched buffer submitting to >> reduce the number of tx interrupts. >> >> Cc: Rusty Russell <rusty at rustcorp.com.au> >> Cc:

Hello everyone, This RFC implements packed ring support for virtio driver. The code was tested with DPDK vhost (testpmd/vhost-PMD) implemented by Jens at http://dpdk.org/ml/archives/dev/2018-January/089417.html Minor changes are needed for the vhost code, e.g. to kick the guest. TODO: - Refinements and bug fixes; - Split into small patches; - Test indirect descriptor support; - Test/fix event

Hello everyone, This RFC implements packed ring support for virtio driver. The code was tested with DPDK vhost (testpmd/vhost-PMD) implemented by Jens at http://dpdk.org/ml/archives/dev/2018-January/089417.html Minor changes are needed for the vhost code, e.g. to kick the guest. TODO: - Refinements and bug fixes; - Split into small patches; - Test indirect descriptor support; - Test/fix event

According to David, proper accounting and queueing (at all levels, not just TCP sockets) is more important than trying to skim a bunch of cycles by avoiding TX interrupts. Having an event to free the SKB is absolutely essential for the stack to operate correctly. This series tries to enable tx interrupt for virtio-net. The idea is simple: enable tx interrupt and schedule a tx napi to free old