similar to: [vhost] vhost_get_vq_desc, vq->iov mapping

The address of the iovec &vq->iov[out] is not guaranteed to contain the scsi command's response iovec throughout the lifetime of the command. Rather, it is more likely to contain an iovec from an immediately following command after looping back around to vhost_get_vq_desc(). Pass along the iovec entirely instead. Fixes: 79c14141a487 ("vhost/scsi: Convert completion path to use

The address of the iovec &vq->iov[out] is not guaranteed to contain the scsi command's response iovec throughout the lifetime of the command. Rather, it is more likely to contain an iovec from an immediately following command after looping back around to vhost_get_vq_desc(). Pass along the iovec entirely instead. Fixes: 79c14141a487 ("vhost/scsi: Convert completion path to use

vhost fails to validate negative error code from vhost_get_vq_desc causing a crash: we are using -EFAULT which is 0xfffffff2 as vector size, which exceeds the allocated size. The code in question was introduced in commit 8dd014adfea6f173c1ef6378f7e5e7924866c923 vhost-net: mergeable buffers support CVE-2014-0055 Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- This is needed

vhost fails to validate negative error code from vhost_get_vq_desc causing a crash: we are using -EFAULT which is 0xfffffff2 as vector size, which exceeds the allocated size. The code in question was introduced in commit 8dd014adfea6f173c1ef6378f7e5e7924866c923 vhost-net: mergeable buffers support CVE-2014-0055 Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- This is needed

On Tue, May 13, 2014 at 10:35:33AM +0200, Michael Mueller wrote: > From: Dong Dong Chen <ddongch at cn.ibm.com> > > Under memory pressure we observe load issues with module vhost_net, as the > vhost setup code will try to do an order 4 allocation for the device. > The likeliness of this issue to occur can be reduced when the statically > allocated variable "iov"

From: Dong Dong Chen <ddongch at cn.ibm.com> Under memory pressure we observe load issues with module vhost_net, as the vhost setup code will try to do an order 4 allocation for the device. The likeliness of this issue to occur can be reduced when the statically allocated variable "iov" in "struct vhost_virtqueue" is dynamically allocated with exactly the required size,

Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/vhost/vhost.h | 19 +++++++++++++------ drivers/vhost/net.c | 30 +++++++++++++++++++++--------- drivers/vhost/scsi.c | 23 +++++++++++++++-------- drivers/vhost/test.c | 5 +++-- drivers/vhost/vhost.c | 23 ++++++++++++++++------- 5 files changed, 68 insertions(+), 32 deletions(-) diff --git a/drivers/vhost/vhost.h

Move get_rx_bufs() to vhost.c and rename it to vhost_get_bufs(). This helps to hide vring internal layout from specific device implementation. Packed ring implementation will benefit from this. Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/vhost/net.c | 77 -------------------------------------------------- drivers/vhost/vhost.c | 78

Move get_rx_bufs() to vhost.c and rename it to vhost_get_rx_bufs(). This helps to hide vring internal layout from specific device implementation. Packed ring implementation will benefit from this. Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/vhost/net.c | 83 ++------------------------------------------------- drivers/vhost/vhost.c | 78

This patch splits out ring head fetching logic and leave the descriptor fetching and translation logic. This makes it is possible to batch fetching the descriptor indices. Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/vhost/vhost.c | 75 +++++++++++++++++++++++++++++++++------------------ drivers/vhost/vhost.h | 5 ++++ 2 files changed, 54 insertions(+), 26 deletions(-)

On Mon, Apr 23, 2018 at 01:34:53PM +0800, Jason Wang wrote: > Move get_rx_bufs() to vhost.c and rename it to > vhost_get_rx_bufs(). This helps to hide vring internal layout from A small typo. Based on the code change in this patch, it seems that this function is renamed to vhost_get_bufs(). Thanks > specific device implementation. Packed ring implementation will > benefit from

Switch to buf APIs. Doing this exposes a spec violation in vhost scsi: all used bufs are marked with length 0. Fix that is left for another day. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/vhost/scsi.c | 73 ++++++++++++++++++++++++++------------------ 1 file changed, 44 insertions(+), 29 deletions(-) diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c index

Switch to buf APIs. Doing this exposes a spec violation in vhost scsi: all used bufs are marked with length 0. Fix that is left for another day. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/vhost/scsi.c | 73 ++++++++++++++++++++++++++------------------ 1 file changed, 44 insertions(+), 29 deletions(-) diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c index

When ring parsing fails, we currently handle this as ring empty condition. This means that we enable kicks and recheck ring empty: if this not empty, we re-start polling which of course will fail again. Instead, let's return a negative error code and stop polling. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- Dave, I'm sending this out so it can get reviewed. I'll

When ring parsing fails, we currently handle this as ring empty condition. This means that we enable kicks and recheck ring empty: if this not empty, we re-start polling which of course will fail again. Instead, let's return a negative error code and stop polling. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- Dave, I'm sending this out so it can get reviewed. I'll

Add a new API that doesn't assume used ring, heads, etc. For now, we keep the old APIs around to make it easier to convert drivers. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/vhost/vhost.c | 52 ++++++++++++++++++++++++++++++++++--------- drivers/vhost/vhost.h | 17 +++++++++++++- 2 files changed, 58 insertions(+), 11 deletions(-) diff --git

As testing shows no performance change, switch to that now. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Eugenio P?rez <eperezma at redhat.com> Link: https://lore.kernel.org/r/20200401183118.8334-3-eperezma at redhat.com Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/vhost/vhost.c | 251 +-----------------------------------------

As testing shows no performance change, switch to that now. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Eugenio P?rez <eperezma at redhat.com> Link: https://lore.kernel.org/r/20200401183118.8334-3-eperezma at redhat.com Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/vhost/vhost.c | 251 +-----------------------------------------

As testing shows no performance change, switch to that now. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Eugenio P?rez <eperezma at redhat.com> Link: https://lore.kernel.org/r/20200401183118.8334-3-eperezma at redhat.com Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/vhost/vhost.c | 251 +-----------------------------------------

On Wed, Jun 03, 2020 at 03:58:26PM +0800, Jason Wang wrote: > > On 2020/6/2 ??9:06, Michael S. Tsirkin wrote: > > Add a new API that doesn't assume used ring, heads, etc. > > For now, we keep the old APIs around to make it easier > > to convert drivers. > > > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > > --- > >